From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joe Perches <joe@perches.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Hsiang <Peter.Hsiang@maxim-ic.com>,
Jesse Marroquin <Jesse.Marroquin@maxim-ic.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver
Date: Wed, 13 Oct 2010 09:24:14 +0100 [thread overview]
Message-ID: <20101013082414.GD6424@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1286934472.1117.129.camel@Joe-Laptop>
On Tue, Oct 12, 2010 at 06:47:52PM -0700, Joe Perches wrote:
> On Tue, 2010-10-12 at 18:20 -0700, Peter Hsiang wrote:
> > +static struct {
> > + int readable;
> > + int writable;
> > + int vol;
> > +} max98088_access[M98088_REG_CNT] = {
> bool instead?
> static struct {
> bool readable;
> bool writable,
> bool vol;
> } etc...
The readable and writable fields are being used as bitmasks:
| + { 0x1F, 0x1F, 1 }, /* 03 battery voltage */
so this discards data which we may wish to use in future.
> readable isn't used anywhere, writeable is used as bool
> vol isn't a good name as it's easy to confuse with
> volume. Maybe volatile_register?
vol is traditionally used for this throughout the subsystem. It's
unfortuante that volatile is a keyword.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joe Perches <joe@perches.com>
Cc: Peter Hsiang <Peter.Hsiang@maxim-ic.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jesse Marroquin <Jesse.Marroquin@maxim-ic.com>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver
Date: Wed, 13 Oct 2010 09:24:14 +0100 [thread overview]
Message-ID: <20101013082414.GD6424@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1286934472.1117.129.camel@Joe-Laptop>
On Tue, Oct 12, 2010 at 06:47:52PM -0700, Joe Perches wrote:
> On Tue, 2010-10-12 at 18:20 -0700, Peter Hsiang wrote:
> > +static struct {
> > + int readable;
> > + int writable;
> > + int vol;
> > +} max98088_access[M98088_REG_CNT] = {
> bool instead?
> static struct {
> bool readable;
> bool writable,
> bool vol;
> } etc...
The readable and writable fields are being used as bitmasks:
| + { 0x1F, 0x1F, 1 }, /* 03 battery voltage */
so this discards data which we may wish to use in future.
> readable isn't used anywhere, writeable is used as bool
> vol isn't a good name as it's easy to confuse with
> volume. Maybe volatile_register?
vol is traditionally used for this throughout the subsystem. It's
unfortuante that volatile is a keyword.
next prev parent reply other threads:[~2010-10-13 8:24 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 2:34 [PATCH] ASoC: Add max98088 CODEC driver Peter Hsiang
2010-09-29 2:34 ` Peter Hsiang
2010-09-29 3:37 ` Mark Brown
2010-09-29 3:37 ` Mark Brown
2010-09-29 21:42 ` Peter Hsiang
2010-09-29 21:42 ` Peter Hsiang
2010-09-29 22:18 ` Mark Brown
2010-09-29 22:18 ` Mark Brown
2010-09-30 0:52 ` Peter Hsiang
2010-09-30 0:58 ` Mark Brown
2010-09-30 0:58 ` Mark Brown
2010-09-30 1:20 ` Peter Hsiang
2010-09-30 17:23 ` user space control app driver interface for sound soc Peter Hsiang
2010-09-30 20:31 ` Mark Brown
2010-09-30 21:55 ` Peter Hsiang
2010-09-30 22:09 ` Mark Brown
2010-09-30 23:10 ` Peter Hsiang
2010-09-30 23:34 ` Mark Brown
2010-10-01 1:56 ` Peter Hsiang
2010-10-01 2:37 ` Mark Brown
2010-10-01 6:56 ` Clemens Ladisch
2010-10-01 7:12 ` Mark Brown
2010-10-01 13:42 ` Takashi Iwai
2010-10-01 17:35 ` Mark Brown
2010-10-01 21:57 ` Peter Hsiang
2010-10-03 9:09 ` Takashi Iwai
2010-10-13 1:20 ` [PATCH] ASoC: Add max98088 CODEC driver Peter Hsiang
2010-10-13 1:47 ` Joe Perches
2010-10-13 8:24 ` Mark Brown [this message]
2010-10-13 8:24 ` Mark Brown
2010-10-13 12:10 ` [PATCH] sound/soc: rename vol to volatile_register as appropriate Joe Perches
2010-10-13 12:33 ` Mark Brown
2010-10-13 12:33 ` Mark Brown
2010-10-13 12:55 ` Joe Perches
2010-10-13 15:11 ` Mark Brown
2010-10-13 15:11 ` Mark Brown
2010-10-13 15:27 ` Joe Perches
2010-10-13 15:29 ` Mark Brown
2010-10-13 15:29 ` Mark Brown
2010-10-13 15:35 ` Joe Perches
2010-10-13 19:10 ` [RFC PATCH] sound/soc/codecs/wm8962.c: Use register index, save 100kb text Joe Perches
2010-10-13 19:40 ` Mark Brown
2010-10-13 19:40 ` Mark Brown
2010-10-13 20:06 ` Joe Perches
2010-10-13 20:29 ` Mark Brown
2010-10-13 20:29 ` Mark Brown
2010-10-13 15:19 ` [PATCH] sound/soc/codecs/wm8994.c: Remove unused vol Joe Perches
2010-10-15 10:08 ` Liam Girdwood
2010-10-15 10:08 ` Liam Girdwood
2010-10-15 10:39 ` Mark Brown
2010-10-15 10:39 ` Mark Brown
2010-10-13 10:32 ` [PATCH] ASoC: Add max98088 CODEC driver Mark Brown
2010-10-13 10:32 ` Mark Brown
2010-10-14 3:18 ` Peter Hsiang
2010-10-14 3:18 ` Peter Hsiang
2010-10-14 3:30 ` Peter Hsiang
2010-10-15 10:04 ` Liam Girdwood
2010-10-15 10:04 ` Liam Girdwood
2010-10-15 10:55 ` Mark Brown
2010-10-15 10:55 ` Mark Brown
2010-10-15 17:23 ` Peter Hsiang
2010-10-15 17:23 ` Peter Hsiang
-- strict thread matches above, loose matches on Subject: below --
2010-09-23 2:58 Peter Hsiang
2010-09-23 2:58 ` Peter Hsiang
2010-09-23 12:04 ` Mark Brown
2010-09-23 12:04 ` Mark Brown
2010-09-23 17:56 ` Peter Hsiang
2010-09-23 17:56 ` Peter Hsiang
2010-09-23 18:38 ` Mark Brown
2010-09-23 18:38 ` Mark Brown
2010-08-31 21:08 Peter Hsiang
2010-08-31 21:08 Peter Hsiang
2010-09-01 11:14 ` Mark Brown
2010-09-01 11:14 ` Mark Brown
2010-09-02 23:30 ` Peter Hsiang
2010-09-03 10:17 ` Mark Brown
2010-09-03 10:17 ` Mark Brown
2010-09-22 2:49 ` Peter Hsiang
2010-09-22 2:49 ` Peter Hsiang
2010-09-22 10:38 ` Mark Brown
2010-09-22 10:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013082414.GD6424@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Jesse.Marroquin@maxim-ic.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.