From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jesse Marroquin <Jesse.Marroquin@maxim-ic.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver
Date: Wed, 13 Oct 2010 11:32:24 +0100 [thread overview]
Message-ID: <20101013103224.GK6424@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40D469C124F@ITSVLEX06.it.maxim-ic.internal>
On Tue, Oct 12, 2010 at 06:20:10PM -0700, Peter Hsiang wrote:
This looks pretty good, waiting for Liam's review but I think we can do
further stuff incrementally. Minor comments:
> +
> + /* Setup an array of texts for the equalizer enum.
> + * This is based on Mark Brown's equalizer driver code.
> + * It has been extended to support multiple equalizers.
> + */
The code that you're basing this on supports multiple equalizers too -
things like the WM8994 have several. Given that all those supported by
the original code are identical there didn't seem to be any point in
restricting which EQ a given setup can be deployed on - it's just one
more thing that can go wrong.
> +static int max98088_remove(struct snd_soc_codec *codec)
> +{
> + if (codec->control_data)
> + max98088_set_bias_level(codec, SND_SOC_BIAS_OFF);
The control_data check should be redundant here.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jesse Marroquin <Jesse.Marroquin@maxim-ic.com>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver
Date: Wed, 13 Oct 2010 11:32:24 +0100 [thread overview]
Message-ID: <20101013103224.GK6424@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40D469C124F@ITSVLEX06.it.maxim-ic.internal>
On Tue, Oct 12, 2010 at 06:20:10PM -0700, Peter Hsiang wrote:
This looks pretty good, waiting for Liam's review but I think we can do
further stuff incrementally. Minor comments:
> +
> + /* Setup an array of texts for the equalizer enum.
> + * This is based on Mark Brown's equalizer driver code.
> + * It has been extended to support multiple equalizers.
> + */
The code that you're basing this on supports multiple equalizers too -
things like the WM8994 have several. Given that all those supported by
the original code are identical there didn't seem to be any point in
restricting which EQ a given setup can be deployed on - it's just one
more thing that can go wrong.
> +static int max98088_remove(struct snd_soc_codec *codec)
> +{
> + if (codec->control_data)
> + max98088_set_bias_level(codec, SND_SOC_BIAS_OFF);
The control_data check should be redundant here.
next prev parent reply other threads:[~2010-10-13 10:32 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 2:34 [PATCH] ASoC: Add max98088 CODEC driver Peter Hsiang
2010-09-29 2:34 ` Peter Hsiang
2010-09-29 3:37 ` Mark Brown
2010-09-29 3:37 ` Mark Brown
2010-09-29 21:42 ` Peter Hsiang
2010-09-29 21:42 ` Peter Hsiang
2010-09-29 22:18 ` Mark Brown
2010-09-29 22:18 ` Mark Brown
2010-09-30 0:52 ` Peter Hsiang
2010-09-30 0:58 ` Mark Brown
2010-09-30 0:58 ` Mark Brown
2010-09-30 1:20 ` Peter Hsiang
2010-09-30 17:23 ` user space control app driver interface for sound soc Peter Hsiang
2010-09-30 20:31 ` Mark Brown
2010-09-30 21:55 ` Peter Hsiang
2010-09-30 22:09 ` Mark Brown
2010-09-30 23:10 ` Peter Hsiang
2010-09-30 23:34 ` Mark Brown
2010-10-01 1:56 ` Peter Hsiang
2010-10-01 2:37 ` Mark Brown
2010-10-01 6:56 ` Clemens Ladisch
2010-10-01 7:12 ` Mark Brown
2010-10-01 13:42 ` Takashi Iwai
2010-10-01 17:35 ` Mark Brown
2010-10-01 21:57 ` Peter Hsiang
2010-10-03 9:09 ` Takashi Iwai
2010-10-13 1:20 ` [PATCH] ASoC: Add max98088 CODEC driver Peter Hsiang
2010-10-13 1:47 ` Joe Perches
2010-10-13 8:24 ` Mark Brown
2010-10-13 8:24 ` Mark Brown
2010-10-13 12:10 ` [PATCH] sound/soc: rename vol to volatile_register as appropriate Joe Perches
2010-10-13 12:33 ` Mark Brown
2010-10-13 12:33 ` Mark Brown
2010-10-13 12:55 ` Joe Perches
2010-10-13 15:11 ` Mark Brown
2010-10-13 15:11 ` Mark Brown
2010-10-13 15:27 ` Joe Perches
2010-10-13 15:29 ` Mark Brown
2010-10-13 15:29 ` Mark Brown
2010-10-13 15:35 ` Joe Perches
2010-10-13 19:10 ` [RFC PATCH] sound/soc/codecs/wm8962.c: Use register index, save 100kb text Joe Perches
2010-10-13 19:40 ` Mark Brown
2010-10-13 19:40 ` Mark Brown
2010-10-13 20:06 ` Joe Perches
2010-10-13 20:29 ` Mark Brown
2010-10-13 20:29 ` Mark Brown
2010-10-13 15:19 ` [PATCH] sound/soc/codecs/wm8994.c: Remove unused vol Joe Perches
2010-10-15 10:08 ` Liam Girdwood
2010-10-15 10:08 ` Liam Girdwood
2010-10-15 10:39 ` Mark Brown
2010-10-15 10:39 ` Mark Brown
2010-10-13 10:32 ` Mark Brown [this message]
2010-10-13 10:32 ` [PATCH] ASoC: Add max98088 CODEC driver Mark Brown
2010-10-14 3:18 ` Peter Hsiang
2010-10-14 3:18 ` Peter Hsiang
2010-10-14 3:30 ` Peter Hsiang
2010-10-15 10:04 ` Liam Girdwood
2010-10-15 10:04 ` Liam Girdwood
2010-10-15 10:55 ` Mark Brown
2010-10-15 10:55 ` Mark Brown
2010-10-15 17:23 ` Peter Hsiang
2010-10-15 17:23 ` Peter Hsiang
-- strict thread matches above, loose matches on Subject: below --
2010-09-23 2:58 Peter Hsiang
2010-09-23 2:58 ` Peter Hsiang
2010-09-23 12:04 ` Mark Brown
2010-09-23 12:04 ` Mark Brown
2010-09-23 17:56 ` Peter Hsiang
2010-09-23 17:56 ` Peter Hsiang
2010-09-23 18:38 ` Mark Brown
2010-09-23 18:38 ` Mark Brown
2010-08-31 21:08 Peter Hsiang
2010-09-01 11:14 ` Mark Brown
2010-09-01 11:14 ` Mark Brown
2010-09-02 23:30 ` Peter Hsiang
2010-09-03 10:17 ` Mark Brown
2010-09-03 10:17 ` Mark Brown
2010-09-22 2:49 ` Peter Hsiang
2010-09-22 2:49 ` Peter Hsiang
2010-09-22 10:38 ` Mark Brown
2010-09-22 10:38 ` Mark Brown
2010-08-31 21:08 Peter Hsiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013103224.GK6424@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Jesse.Marroquin@maxim-ic.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.