Re: [PATCH 14/28] Blackfin: SPI: expand SPI bitmasks

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Sun, Oct 17, 2010 at 06:59:27PM -0400, Mike Frysinger wrote:
> Expand the BIT_CTL defines to use the naming convention of the hardware,
> and expand the masks to cover all documented bits.
> 
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
> ---
>  arch/blackfin/include/asm/bfin5xx_spi.h |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/blackfin/include/asm/bfin5xx_spi.h b/arch/blackfin/include/asm/bfin5xx_spi.h
> index ee3ecb9..126d25e 100644
> --- a/arch/blackfin/include/asm/bfin5xx_spi.h
> +++ b/arch/blackfin/include/asm/bfin5xx_spi.h
> @@ -26,11 +26,14 @@
>  #define BIT_CTL_ENABLE      0x4000
>  #define BIT_CTL_OPENDRAIN   0x2000
>  #define BIT_CTL_MASTER      0x1000
> -#define BIT_CTL_POLAR       0x0800
> -#define BIT_CTL_PHASE       0x0400
> -#define BIT_CTL_BITORDER    0x0200
> +#define BIT_CTL_CPOL        0x0800
> +#define BIT_CTL_CPHA        0x0400
> +#define BIT_CTL_LSBF        0x0200
>  #define BIT_CTL_WORDSIZE    0x0100
> -#define BIT_CTL_MISOENABLE  0x0020
> +#define BIT_CTL_EMISO       0x0020
> +#define BIT_CTL_PSSE        0x0010
> +#define BIT_CTL_GM          0x0008
> +#define BIT_CTL_SZ          0x0004
>  #define BIT_CTL_RXMOD       0x0000
>  #define BIT_CTL_TXMOD       0x0001
>  #define BIT_CTL_TIMOD_DMA_TX 0x0003

Can I assume that these changed values are as-of-this-point unused?
Otherwise this patch has bisect issues.

g.

> -- 
> 1.7.3.1
>