Re: [PATCH 00/28] Blackfin SPI updates for 2.6.36

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Sun, Oct 17, 2010 at 06:59:13PM -0400, Mike Frysinger wrote:
> Quite a bit here, but these patches have been around for a while.  The
> reason they haven't been pushed up before was that some of the first
> changes introduced known bugs themselves and needed some manual fixing.
> 
> Also, while some files touch Blackfin headers in arch/blackfin/, I'd
> like to keep them in this series and merge through the SPI tree to keep
> conflict issues down, as well as possible breakage due to desync.
> 
> These are also available in my 'for-spi' branch of my git tree:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/vapier/blackfin.git

On brief review, the series looks good with a couple of minor comments
(already sent).

For the spi branch that I push to Linus, I always use the prefix
spi/<driver-name>.  If the patches in your branch also use that
prefix, then I'd be happy to pull your tree directly instead of
committing the patches myself.  Otherwise, I need to commit them
manually.

I *might* pick these up for .36, but it is very late for picking up
stuff that hasn't had any linux-next exposure yet.

Thanks,
g.

> 
> Barry Song (6):
>   Blackfin SPI: fix CS handling
>   Blackfin SPI: redo GPIO CS handling
>   Blackfin SPI: save/restore state when suspending/resuming
>   Blackfin SPI: sync hardware state before reprogramming everything
>   Blackfin SPI: use dma_disable_irq_nosync() in irq handler
>   Blackfin SPI: warn when CS is driven by hardware (CPHA=0)
> 
> Bob Liu (1):
>   Blackfin SPI: check per-transfer bits_per_word
> 
> Daniel Mack (1):
>   Blackfin SPI: fix resources leakage
> 
> Michael Hennerich (1):
>   Blackfin SPI: init early
> 
> Mike Frysinger (13):
>   Blackfin SPI: drop custom cs_change_per_word support
>   Blackfin SPI: punt useless null read/write funcs
>   Blackfin SPI: fix up some unused/misleading comments
>   Blackfin SPI: convert queue run state to true/false
>   Blackfin SPI: convert read/write/duplex funcs to a dedicated ops
>     structure
>   Blackfin SPI: convert struct names to something more logical
>   Blackfin SPI: drop extra memory we don't need
>   Blackfin SPI: use the SPI namespaced bit names
>   Blackfin: SPI: expand SPI bitmasks
>   Blackfin SPI: push all size checks into the transfer function
>   Blackfin SPI: reset ctl_reg bits when setup is run again on a device
>   Blackfin SPI: combine duplicate SPI_CTL read/write logic
>   Blackfin SPI: reject unsupported SPI modes
> 
> Rob Maris (2):
>   Blackfin SPI: fix typo in comment
>   Blackfin SPI: cs should be always low when a new transfer begins
> 
> Sonic Zhang (1):
>   Blackfin SPI: work around anomaly 05000119
> 
> Wolfgang Muees (1):
>   Blackfin SPI: force sane master-mode state at boot
> 
> Yi Li (2):
>   Blackfin SPI: utilize the SPI interrupt in PIO mode
>   Blackfin SPI: use nosync when disabling the IRQ from the IRQ handler
> 
>  arch/blackfin/include/asm/bfin5xx_spi.h |   81 +---
>  drivers/spi/spi_bfin5xx.c               |  839 ++++++++++++++++---------------
>  2 files changed, 441 insertions(+), 479 deletions(-)
> 
> -- 
> 1.7.3.1
>