From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Anthony Liguori <aliguori@us.ibm.com>,
Khoa Huynh <khoa@us.ibm.com>,
sri@linux.vnet.ibm.com, Steve Dobbelstein <steved@us.ibm.com>
Subject: Re: [PATCH] virtio: Use ioeventfd for virtqueue notify
Date: Tue, 19 Oct 2010 15:43:15 +0200 [thread overview]
Message-ID: <20101019134315.GA18740@redhat.com> (raw)
In-Reply-To: <AANLkTi=0YgTGorUvznRi+JG10hh7V1aqsN1SpNL1eCqN@mail.gmail.com>
On Tue, Oct 19, 2010 at 02:44:35PM +0100, Stefan Hajnoczi wrote:
> On Tue, Oct 19, 2010 at 2:35 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote:
> >> On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote:
> >> >Is there anything stopping this patch from being merged?
> >>
> >> Michael, any objections? If not, I'll merge it.
> >
> > I don't really understand what's going on there. The extra state in
> > notifiers especially scares me. If you do and are comfortable with the
> > code, go ahead :)
>
> I'm happy to address your comments. The state machine was a bit icky
> but I don't see a way around it.
I think the situation is similar to irqfd in qemu-kvm - take a look
there, specifically msix mask notifiers.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Steve Dobbelstein <steved@us.ibm.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Khoa Huynh <khoa@us.ibm.com>,
sri@linux.vnet.ibm.com
Subject: [Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify
Date: Tue, 19 Oct 2010 15:43:15 +0200 [thread overview]
Message-ID: <20101019134315.GA18740@redhat.com> (raw)
In-Reply-To: <AANLkTi=0YgTGorUvznRi+JG10hh7V1aqsN1SpNL1eCqN@mail.gmail.com>
On Tue, Oct 19, 2010 at 02:44:35PM +0100, Stefan Hajnoczi wrote:
> On Tue, Oct 19, 2010 at 2:35 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote:
> >> On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote:
> >> >Is there anything stopping this patch from being merged?
> >>
> >> Michael, any objections? If not, I'll merge it.
> >
> > I don't really understand what's going on there. The extra state in
> > notifiers especially scares me. If you do and are comfortable with the
> > code, go ahead :)
>
> I'm happy to address your comments. The state machine was a bit icky
> but I don't see a way around it.
I think the situation is similar to irqfd in qemu-kvm - take a look
there, specifically msix mask notifiers.
--
MST
next prev parent reply other threads:[~2010-10-19 13:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 14:01 [PATCH] virtio: Use ioeventfd for virtqueue notify Stefan Hajnoczi
2010-09-30 14:01 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-03 11:01 ` Avi Kivity
2010-10-03 11:01 ` [Qemu-devel] " Avi Kivity
2010-10-03 13:51 ` Michael S. Tsirkin
2010-10-03 13:51 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-03 14:21 ` Avi Kivity
2010-10-03 14:21 ` [Qemu-devel] " Avi Kivity
2010-10-03 14:28 ` Michael S. Tsirkin
2010-10-03 14:28 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-04 1:18 ` Anthony Liguori
2010-10-04 1:18 ` [Qemu-devel] " Anthony Liguori
2010-10-04 8:04 ` Avi Kivity
2010-10-04 8:04 ` [Qemu-devel] " Avi Kivity
2010-10-04 14:01 ` Anthony Liguori
2010-10-04 14:01 ` Anthony Liguori
2010-10-04 16:12 ` Michael S. Tsirkin
2010-10-04 16:12 ` Michael S. Tsirkin
2010-10-04 16:20 ` Anthony Liguori
2010-10-04 16:20 ` Anthony Liguori
2010-10-04 16:25 ` Michael S. Tsirkin
2010-10-04 16:25 ` Michael S. Tsirkin
2010-10-04 14:30 ` Stefan Hajnoczi
2010-10-04 14:30 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-05 11:00 ` rukhsana ansari
2010-10-05 11:00 ` [Qemu-devel] " rukhsana ansari
2010-10-05 11:58 ` Avi Kivity
2010-10-05 11:58 ` [Qemu-devel] " Avi Kivity
2010-10-19 13:07 ` Stefan Hajnoczi
2010-10-19 13:07 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:12 ` Anthony Liguori
2010-10-19 13:12 ` [Qemu-devel] " Anthony Liguori
2010-10-19 13:35 ` Michael S. Tsirkin
2010-10-19 13:35 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-19 13:44 ` Stefan Hajnoczi
2010-10-19 13:44 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:43 ` Michael S. Tsirkin [this message]
2010-10-19 13:43 ` Michael S. Tsirkin
2010-11-10 14:52 ` Stefan Hajnoczi
2010-11-10 14:52 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:33 ` Michael S. Tsirkin
2010-10-19 13:33 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-25 13:25 ` Stefan Hajnoczi
2010-10-25 13:25 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-25 15:01 ` Stefan Hajnoczi
2010-10-25 15:01 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019134315.GA18740@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=khoa@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=sri@linux.vnet.ibm.com \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=steved@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.