All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: rukhsana ansari <ruk.ansari@gmail.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Khoa Huynh <khoa@us.ibm.com>, Sridhar Samudrala <sri@us.ibm.com>,
	Steve Dobbelstein <steved@us.ibm.com>
Subject: Re: [PATCH] virtio: Use ioeventfd for virtqueue notify
Date: Tue, 05 Oct 2010 13:58:44 +0200	[thread overview]
Message-ID: <4CAB12F4.30701@redhat.com> (raw)
In-Reply-To: <AANLkTimg=mg0OR=uQ1prO9kxof+bRCZnB1jDaMNm78rr@mail.gmail.com>

  On 10/05/2010 01:00 PM, rukhsana ansari wrote:
> Hi,
>
> W.r.t:
> >  Note that this is a tradeoff.  If an idle core is available and the
> >  scheduler places the iothread on that core, then the heavyweight exit is
> >  replaced by a lightweight exit + IPI.  If the iothread is co-located with
> >  the vcpu, then we'll take a heavyweight exit in any case.
> >
> Q: Does the kvm kernel code check for such a condition and take a
> heavyweight exit?

No.  The heavyweight exit is caused by a context switch (partial) or 
return to userspace (full).

> >  The first case is very likely if the host cpu is undercommitted and there is
> >  heavy I/O activity.  This is a typical subsystem benchmark scenario (as
> >  opposed to a system benchmark like specvirt).  My feeling is that total
> >  system throughput will be decreased unless the scheduler is clever enough to
> >  place the iothread and vcpu on the same host cpu when the system is
> >  overcommitted.
> >
> >
> Q: Sorry if the answer is obvious here.
> If the heavyweight exit is taken when both threads are assigned to the
> same core, how will the system throughput increase?
>

Co-locating threads on the same core reduces cross-core traffic.

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: rukhsana ansari <ruk.ansari@gmail.com>
Cc: Steve Dobbelstein <steved@us.ibm.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Khoa Huynh <khoa@us.ibm.com>,
	Sridhar Samudrala <sri@us.ibm.com>
Subject: [Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify
Date: Tue, 05 Oct 2010 13:58:44 +0200	[thread overview]
Message-ID: <4CAB12F4.30701@redhat.com> (raw)
In-Reply-To: <AANLkTimg=mg0OR=uQ1prO9kxof+bRCZnB1jDaMNm78rr@mail.gmail.com>

  On 10/05/2010 01:00 PM, rukhsana ansari wrote:
> Hi,
>
> W.r.t:
> >  Note that this is a tradeoff.  If an idle core is available and the
> >  scheduler places the iothread on that core, then the heavyweight exit is
> >  replaced by a lightweight exit + IPI.  If the iothread is co-located with
> >  the vcpu, then we'll take a heavyweight exit in any case.
> >
> Q: Does the kvm kernel code check for such a condition and take a
> heavyweight exit?

No.  The heavyweight exit is caused by a context switch (partial) or 
return to userspace (full).

> >  The first case is very likely if the host cpu is undercommitted and there is
> >  heavy I/O activity.  This is a typical subsystem benchmark scenario (as
> >  opposed to a system benchmark like specvirt).  My feeling is that total
> >  system throughput will be decreased unless the scheduler is clever enough to
> >  place the iothread and vcpu on the same host cpu when the system is
> >  overcommitted.
> >
> >
> Q: Sorry if the answer is obvious here.
> If the heavyweight exit is taken when both threads are assigned to the
> same core, how will the system throughput increase?
>

Co-locating threads on the same core reduces cross-core traffic.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2010-10-05 11:58 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 14:01 [PATCH] virtio: Use ioeventfd for virtqueue notify Stefan Hajnoczi
2010-09-30 14:01 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-03 11:01 ` Avi Kivity
2010-10-03 11:01   ` [Qemu-devel] " Avi Kivity
2010-10-03 13:51   ` Michael S. Tsirkin
2010-10-03 13:51     ` [Qemu-devel] " Michael S. Tsirkin
2010-10-03 14:21     ` Avi Kivity
2010-10-03 14:21       ` [Qemu-devel] " Avi Kivity
2010-10-03 14:28       ` Michael S. Tsirkin
2010-10-03 14:28         ` [Qemu-devel] " Michael S. Tsirkin
2010-10-04  1:18         ` Anthony Liguori
2010-10-04  1:18           ` [Qemu-devel] " Anthony Liguori
2010-10-04  8:04           ` Avi Kivity
2010-10-04  8:04             ` [Qemu-devel] " Avi Kivity
2010-10-04 14:01             ` Anthony Liguori
2010-10-04 14:01               ` Anthony Liguori
2010-10-04 16:12               ` Michael S. Tsirkin
2010-10-04 16:12                 ` Michael S. Tsirkin
2010-10-04 16:20                 ` Anthony Liguori
2010-10-04 16:20                   ` Anthony Liguori
2010-10-04 16:25                   ` Michael S. Tsirkin
2010-10-04 16:25                     ` Michael S. Tsirkin
2010-10-04 14:30   ` Stefan Hajnoczi
2010-10-04 14:30     ` [Qemu-devel] " Stefan Hajnoczi
2010-10-05 11:00   ` rukhsana ansari
2010-10-05 11:00     ` [Qemu-devel] " rukhsana ansari
2010-10-05 11:58     ` Avi Kivity [this message]
2010-10-05 11:58       ` Avi Kivity
2010-10-19 13:07 ` Stefan Hajnoczi
2010-10-19 13:07   ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:12   ` Anthony Liguori
2010-10-19 13:12     ` [Qemu-devel] " Anthony Liguori
2010-10-19 13:35     ` Michael S. Tsirkin
2010-10-19 13:35       ` [Qemu-devel] " Michael S. Tsirkin
2010-10-19 13:44       ` Stefan Hajnoczi
2010-10-19 13:44         ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:43         ` Michael S. Tsirkin
2010-10-19 13:43           ` [Qemu-devel] " Michael S. Tsirkin
2010-11-10 14:52           ` Stefan Hajnoczi
2010-11-10 14:52             ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:33 ` Michael S. Tsirkin
2010-10-19 13:33   ` [Qemu-devel] " Michael S. Tsirkin
2010-10-25 13:25   ` Stefan Hajnoczi
2010-10-25 13:25     ` [Qemu-devel] " Stefan Hajnoczi
2010-10-25 15:01   ` Stefan Hajnoczi
2010-10-25 15:01     ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAB12F4.30701@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=khoa@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ruk.ansari@gmail.com \
    --cc=sri@us.ibm.com \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=steved@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.