From: Dan Carpenter <error27@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] perf: off by one in perf_swevent_init()
Date: Sun, 24 Oct 2010 19:50:42 +0000 [thread overview]
Message-ID: <20101024195041.GT5985@bicker> (raw)
The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index f309e80..c45396d 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -4687,7 +4687,7 @@ static int perf_swevent_init(struct perf_event *event)
break;
}
- if (event_id > PERF_COUNT_SW_MAX)
+ if (event_id >= PERF_COUNT_SW_MAX)
return -ENOENT;
if (!event->parent) {
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] perf: off by one in perf_swevent_init()
Date: Sun, 24 Oct 2010 21:50:42 +0200 [thread overview]
Message-ID: <20101024195041.GT5985@bicker> (raw)
The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index f309e80..c45396d 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -4687,7 +4687,7 @@ static int perf_swevent_init(struct perf_event *event)
break;
}
- if (event_id > PERF_COUNT_SW_MAX)
+ if (event_id >= PERF_COUNT_SW_MAX)
return -ENOENT;
if (!event->parent) {
next reply other threads:[~2010-10-24 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 19:50 Dan Carpenter [this message]
2010-10-24 19:50 ` [patch] perf: off by one in perf_swevent_init() Dan Carpenter
2010-12-13 19:46 ` Dan Carpenter
2010-12-13 19:46 ` Dan Carpenter
2010-12-13 22:38 ` Peter Zijlstra
2010-12-13 22:38 ` Peter Zijlstra
2010-12-16 10:42 ` [tip:perf/urgent] perf: Fix " tip-bot for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024195041.GT5985@bicker \
--to=error27@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.