* [patch] perf: off by one in perf_swevent_init()
@ 2010-10-24 19:50 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2010-10-24 19:50 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Paul Mackerras, Ingo Molnar, Arnaldo Carvalho de Melo,
Frederic Weisbecker, Stephane Eranian, linux-kernel,
kernel-janitors
The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index f309e80..c45396d 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -4687,7 +4687,7 @@ static int perf_swevent_init(struct perf_event *event)
break;
}
- if (event_id > PERF_COUNT_SW_MAX)
+ if (event_id >= PERF_COUNT_SW_MAX)
return -ENOENT;
if (!event->parent) {
^ permalink raw reply related [flat|nested] 7+ messages in thread* [patch] perf: off by one in perf_swevent_init()
@ 2010-10-24 19:50 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2010-10-24 19:50 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Paul Mackerras, Ingo Molnar, Arnaldo Carvalho de Melo,
Frederic Weisbecker, Stephane Eranian, linux-kernel,
kernel-janitors
The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index f309e80..c45396d 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -4687,7 +4687,7 @@ static int perf_swevent_init(struct perf_event *event)
break;
}
- if (event_id > PERF_COUNT_SW_MAX)
+ if (event_id >= PERF_COUNT_SW_MAX)
return -ENOENT;
if (!event->parent) {
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [patch] perf: off by one in perf_swevent_init()
2010-10-24 19:50 ` Dan Carpenter
@ 2010-12-13 19:46 ` Dan Carpenter
-1 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2010-12-13 19:46 UTC (permalink / raw)
To: Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Frederic Weisbecker, Stephane Eranian,
linux-kernel, kernel-janitors
On Sun, Oct 24, 2010 at 09:50:42PM +0200, Dan Carpenter wrote:
> The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Ping.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] perf: off by one in perf_swevent_init()
@ 2010-12-13 19:46 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2010-12-13 19:46 UTC (permalink / raw)
To: Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Frederic Weisbecker, Stephane Eranian,
linux-kernel, kernel-janitors
On Sun, Oct 24, 2010 at 09:50:42PM +0200, Dan Carpenter wrote:
> The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Ping.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] perf: off by one in perf_swevent_init()
2010-12-13 19:46 ` Dan Carpenter
@ 2010-12-13 22:38 ` Peter Zijlstra
-1 siblings, 0 replies; 7+ messages in thread
From: Peter Zijlstra @ 2010-12-13 22:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Paul Mackerras, Ingo Molnar, Arnaldo Carvalho de Melo,
Frederic Weisbecker, Stephane Eranian, linux-kernel,
kernel-janitors
On Mon, 2010-12-13 at 22:46 +0300, Dan Carpenter wrote:
> On Sun, Oct 24, 2010 at 09:50:42PM +0200, Dan Carpenter wrote:
> > The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Ping.
Thanks for the reminder, queued!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] perf: off by one in perf_swevent_init()
@ 2010-12-13 22:38 ` Peter Zijlstra
0 siblings, 0 replies; 7+ messages in thread
From: Peter Zijlstra @ 2010-12-13 22:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Paul Mackerras, Ingo Molnar, Arnaldo Carvalho de Melo,
Frederic Weisbecker, Stephane Eranian, linux-kernel,
kernel-janitors
On Mon, 2010-12-13 at 22:46 +0300, Dan Carpenter wrote:
> On Sun, Oct 24, 2010 at 09:50:42PM +0200, Dan Carpenter wrote:
> > The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Ping.
Thanks for the reminder, queued!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:perf/urgent] perf: Fix off by one in perf_swevent_init()
2010-10-24 19:50 ` Dan Carpenter
(?)
(?)
@ 2010-12-16 10:42 ` tip-bot for Dan Carpenter
-1 siblings, 0 replies; 7+ messages in thread
From: tip-bot for Dan Carpenter @ 2010-12-16 10:42 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, a.p.zijlstra, error27, tglx, mingo
Commit-ID: ce677831a4abd0f9f957c90ac6f6a0d0472bafb4
Gitweb: http://git.kernel.org/tip/ce677831a4abd0f9f957c90ac6f6a0d0472bafb4
Author: Dan Carpenter <error27@gmail.com>
AuthorDate: Sun, 24 Oct 2010 21:50:42 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 16 Dec 2010 11:14:31 +0100
perf: Fix off by one in perf_swevent_init()
The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20101024195041.GT5985@bicker>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/perf_event.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index 7b87017..2870fee 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -4719,7 +4719,7 @@ static int perf_swevent_init(struct perf_event *event)
break;
}
- if (event_id > PERF_COUNT_SW_MAX)
+ if (event_id >= PERF_COUNT_SW_MAX)
return -ENOENT;
if (!event->parent) {
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-12-16 10:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-24 19:50 [patch] perf: off by one in perf_swevent_init() Dan Carpenter
2010-10-24 19:50 ` Dan Carpenter
2010-12-13 19:46 ` Dan Carpenter
2010-12-13 19:46 ` Dan Carpenter
2010-12-13 22:38 ` Peter Zijlstra
2010-12-13 22:38 ` Peter Zijlstra
2010-12-16 10:42 ` [tip:perf/urgent] perf: Fix " tip-bot for Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.