From: Dan Carpenter <error27@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Julia Lawall <julia@diku.dk>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
kernel-janitors@vger.kernel.org, Matthew Garrett <mjg@redhat.com>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete
Date: Wed, 27 Oct 2010 03:54:49 +0000 [thread overview]
Message-ID: <20101027035449.GB6062@bicker> (raw)
In-Reply-To: <20101027010908.GA29299@khazad-dum.debian.net>
On Tue, Oct 26, 2010 at 11:09:08PM -0200, Henrique de Moraes Holschuh wrote:
> On Tue, 26 Oct 2010, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > Delete successive assignments to the same location.
>
> There are often results of mismerges or other assorted screw ups, often
> done by the maintainer itself (e.g. me in thinkpad-acpi's case) during
> development.
>
> The patch is correct, and I thank you for the head's up. But let me
> track down what caused it first, hmm? I also highly recommend that this
> should be done in all cases you find, instead of just blindly fixing the
> assignment.
I've reviewed the entire patchset per your suggestion and Julia
obviously didn't do it blindly. It all looks good. The patcheset fixes
a number of bugs.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Julia Lawall <julia@diku.dk>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
kernel-janitors@vger.kernel.org, Matthew Garrett <mjg@redhat.com>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment
Date: Wed, 27 Oct 2010 05:54:49 +0200 [thread overview]
Message-ID: <20101027035449.GB6062@bicker> (raw)
In-Reply-To: <20101027010908.GA29299@khazad-dum.debian.net>
On Tue, Oct 26, 2010 at 11:09:08PM -0200, Henrique de Moraes Holschuh wrote:
> On Tue, 26 Oct 2010, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > Delete successive assignments to the same location.
>
> There are often results of mismerges or other assorted screw ups, often
> done by the maintainer itself (e.g. me in thinkpad-acpi's case) during
> development.
>
> The patch is correct, and I thank you for the head's up. But let me
> track down what caused it first, hmm? I also highly recommend that this
> should be done in all cases you find, instead of just blindly fixing the
> assignment.
I've reviewed the entire patchset per your suggestion and Julia
obviously didn't do it blindly. It all looks good. The patcheset fixes
a number of bugs.
regards,
dan carpenter
next prev parent reply other threads:[~2010-10-27 3:54 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 10:25 [PATCH 0/14] delete double assignment Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 1/14] drivers/staging: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 2/14] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 13:43 ` Thomas Dahlmann
2010-10-26 13:43 ` Thomas Dahlmann
2010-10-26 10:25 ` [PATCH 3/14] drivers/vhost/vhost.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:06 ` Michael S. Tsirkin
2010-10-26 11:06 ` Michael S. Tsirkin
2010-10-26 11:06 ` Michael S. Tsirkin
2010-10-26 10:25 ` [PATCH 4/14] drivers/staging/brcm80211/brcmfmac/dhd_linux.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 5/14] drivers/net/sb1000.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:58 ` walter harms
2010-10-26 11:58 ` walter harms
2010-10-26 12:25 ` Julia Lawall
2010-10-26 12:25 ` Julia Lawall
2010-10-27 19:23 ` David Miller
2010-10-27 19:23 ` David Miller
2010-10-26 10:25 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-11-09 0:48 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete Ralf Baechle
2010-11-09 0:48 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment Ralf Baechle
2010-11-09 7:10 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double Julia Lawall
2010-11-09 7:10 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment Julia Lawall
2010-10-26 10:25 ` [PATCH 7/14] drivers/net/typhoon.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:52 ` David Dillow
2010-10-26 11:52 ` David Dillow
2010-10-27 19:24 ` David Miller
2010-10-27 19:24 ` David Miller
2010-10-26 10:25 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-27 1:09 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Henrique de Moraes Holschuh
2010-10-27 1:09 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Henrique de Moraes Holschuh
2010-10-27 1:24 ` [ibm-acpi-devel] [PATCH 8/14] Henrique de Moraes Holschuh
2010-10-27 1:24 ` [ibm-acpi-devel] [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Henrique de Moraes Holschuh
2010-10-27 3:54 ` Dan Carpenter [this message]
2010-10-27 3:54 ` Dan Carpenter
2010-10-27 21:42 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Henrique de Moraes Holschuh
2010-10-27 21:42 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Henrique de Moraes Holschuh
2010-10-27 21:42 ` Henrique de Moraes Holschuh
2010-10-27 5:03 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double Julia Lawall
2010-10-27 5:03 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Julia Lawall
2010-10-27 7:18 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double walter harms
2010-10-27 7:18 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment walter harms
2010-10-27 8:11 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Dan Carpenter
2010-10-27 8:11 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Dan Carpenter
2010-11-24 16:51 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Matthew Garrett
2010-11-24 16:51 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Matthew Garrett
2010-11-24 16:51 ` Matthew Garrett
2010-10-26 10:25 ` [PATCH 9/14] sound/oss/sb_ess.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-27 7:13 ` Takashi Iwai
2010-10-27 7:13 ` Takashi Iwai
2010-10-27 7:13 ` Takashi Iwai
2010-10-26 10:25 ` [PATCH 10/14] drivers/isdn: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:55 ` walter harms
2010-10-26 11:55 ` walter harms
2010-10-26 12:01 ` Julia Lawall
2010-10-26 12:01 ` Julia Lawall
2010-10-26 12:20 ` Julia Lawall
2010-10-26 12:20 ` Julia Lawall
2010-10-27 19:24 ` David Miller
2010-10-27 19:24 ` David Miller
2010-10-26 10:25 ` [PATCH 11/14] drivers/serial/vr41xx_siu.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 12/14] drivers/video/omap/blizzard.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 12:36 ` [PATCH 12/14] drivers/video/omap/blizzard.c: delete double Nicolas Kaiser
2010-10-26 12:36 ` [PATCH 12/14] drivers/video/omap/blizzard.c: delete double assignment Nicolas Kaiser
2010-10-26 10:25 ` [PATCH 13/14] drivers/scsi/be2iscsi/be_main.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 14/14] drivers/ata/pata_octeon_cf.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027035449.GB6062@bicker \
--to=error27@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.