From: walter harms <wharms@bfs.de>
To: Julia Lawall <julia@diku.dk>
Cc: Karsten Keil <isdn@linux-pingi.de>,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/14] drivers/isdn: delete double assignment
Date: Tue, 26 Oct 2010 11:55:44 +0000 [thread overview]
Message-ID: <4CC6C1C0.8020005@bfs.de> (raw)
In-Reply-To: <1288088743-3725-11-git-send-email-julia@diku.dk>
Julia Lawall schrieb:
> From: Julia Lawall <julia@diku.dk>
>
> Delete successive assignments to the same location. In the first case, the
> hscx array has two elements, so change the assignment to initialize the
> second one. In the second case, the two assignments are simply identical.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression i;
> @@
>
> *i = ...;
> i = ...;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> In the first case, the patch changes the semantics and has not been tested.
>
> drivers/isdn/hardware/mISDN/mISDNinfineon.c | 2 +-
> drivers/isdn/hisax/l3_1tr6.c | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/mISDNinfineon.c b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> index af25e1f..e90db88 100644
> --- a/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> +++ b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> @@ -563,7 +563,7 @@ reset_inf(struct inf_hw *hw)
> mdelay(10);
> hw->ipac.isac.adf2 = 0x87;
> hw->ipac.hscx[0].slot = 0x1f;
> - hw->ipac.hscx[0].slot = 0x23;
> + hw->ipac.hscx[1].slot = 0x23;
> break;
> case INF_GAZEL_R753:
> val = inl((u32)hw->cfg.start + GAZEL_CNTRL);
> diff --git a/drivers/isdn/hisax/l3_1tr6.c b/drivers/isdn/hisax/l3_1tr6.c
> index b0554f8..a5c76fc 100644
> --- a/drivers/isdn/hisax/l3_1tr6.c
> +++ b/drivers/isdn/hisax/l3_1tr6.c
> @@ -164,8 +164,6 @@ l3_1tr6_setup(struct l3_process *pc, u_char pr, void *arg)
> char tmp[80];
> struct sk_buff *skb = arg;
>
> - p = skb->data;
> -
> /* Channel Identification */
> p = skb->data;
> if ((p = findie(p, skb->len, WE0_chanID, 0))) {
>
perhaps you can move the next assignment out of if also ?
p = findie(skb->data, skb->len, WE0_chanID, 0);
if (p) { ....
re,
wh
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Julia Lawall <julia@diku.dk>
Cc: Karsten Keil <isdn@linux-pingi.de>,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/14] drivers/isdn: delete double assignment
Date: Tue, 26 Oct 2010 13:55:44 +0200 [thread overview]
Message-ID: <4CC6C1C0.8020005@bfs.de> (raw)
In-Reply-To: <1288088743-3725-11-git-send-email-julia@diku.dk>
Julia Lawall schrieb:
> From: Julia Lawall <julia@diku.dk>
>
> Delete successive assignments to the same location. In the first case, the
> hscx array has two elements, so change the assignment to initialize the
> second one. In the second case, the two assignments are simply identical.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression i;
> @@
>
> *i = ...;
> i = ...;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> In the first case, the patch changes the semantics and has not been tested.
>
> drivers/isdn/hardware/mISDN/mISDNinfineon.c | 2 +-
> drivers/isdn/hisax/l3_1tr6.c | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/mISDNinfineon.c b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> index af25e1f..e90db88 100644
> --- a/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> +++ b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> @@ -563,7 +563,7 @@ reset_inf(struct inf_hw *hw)
> mdelay(10);
> hw->ipac.isac.adf2 = 0x87;
> hw->ipac.hscx[0].slot = 0x1f;
> - hw->ipac.hscx[0].slot = 0x23;
> + hw->ipac.hscx[1].slot = 0x23;
> break;
> case INF_GAZEL_R753:
> val = inl((u32)hw->cfg.start + GAZEL_CNTRL);
> diff --git a/drivers/isdn/hisax/l3_1tr6.c b/drivers/isdn/hisax/l3_1tr6.c
> index b0554f8..a5c76fc 100644
> --- a/drivers/isdn/hisax/l3_1tr6.c
> +++ b/drivers/isdn/hisax/l3_1tr6.c
> @@ -164,8 +164,6 @@ l3_1tr6_setup(struct l3_process *pc, u_char pr, void *arg)
> char tmp[80];
> struct sk_buff *skb = arg;
>
> - p = skb->data;
> -
> /* Channel Identification */
> p = skb->data;
> if ((p = findie(p, skb->len, WE0_chanID, 0))) {
>
perhaps you can move the next assignment out of if also ?
p = findie(skb->data, skb->len, WE0_chanID, 0);
if (p) { ....
re,
wh
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2010-10-26 11:55 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 10:25 [PATCH 0/14] delete double assignment Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 1/14] drivers/staging: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 2/14] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 13:43 ` Thomas Dahlmann
2010-10-26 13:43 ` Thomas Dahlmann
2010-10-26 10:25 ` [PATCH 3/14] drivers/vhost/vhost.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:06 ` Michael S. Tsirkin
2010-10-26 11:06 ` Michael S. Tsirkin
2010-10-26 11:06 ` Michael S. Tsirkin
2010-10-26 10:25 ` [PATCH 4/14] drivers/staging/brcm80211/brcmfmac/dhd_linux.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 5/14] drivers/net/sb1000.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:58 ` walter harms
2010-10-26 11:58 ` walter harms
2010-10-26 12:25 ` Julia Lawall
2010-10-26 12:25 ` Julia Lawall
2010-10-27 19:23 ` David Miller
2010-10-27 19:23 ` David Miller
2010-10-26 10:25 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-11-09 0:48 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete Ralf Baechle
2010-11-09 0:48 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment Ralf Baechle
2010-11-09 7:10 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double Julia Lawall
2010-11-09 7:10 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment Julia Lawall
2010-10-26 10:25 ` [PATCH 7/14] drivers/net/typhoon.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:52 ` David Dillow
2010-10-26 11:52 ` David Dillow
2010-10-27 19:24 ` David Miller
2010-10-27 19:24 ` David Miller
2010-10-26 10:25 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-27 1:09 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Henrique de Moraes Holschuh
2010-10-27 1:09 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Henrique de Moraes Holschuh
2010-10-27 1:24 ` [ibm-acpi-devel] [PATCH 8/14] Henrique de Moraes Holschuh
2010-10-27 1:24 ` [ibm-acpi-devel] [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Henrique de Moraes Holschuh
2010-10-27 3:54 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Dan Carpenter
2010-10-27 3:54 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Dan Carpenter
2010-10-27 21:42 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Henrique de Moraes Holschuh
2010-10-27 21:42 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Henrique de Moraes Holschuh
2010-10-27 21:42 ` Henrique de Moraes Holschuh
2010-10-27 5:03 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double Julia Lawall
2010-10-27 5:03 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Julia Lawall
2010-10-27 7:18 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double walter harms
2010-10-27 7:18 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment walter harms
2010-10-27 8:11 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Dan Carpenter
2010-10-27 8:11 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Dan Carpenter
2010-11-24 16:51 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete Matthew Garrett
2010-11-24 16:51 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double assignment Matthew Garrett
2010-11-24 16:51 ` Matthew Garrett
2010-10-26 10:25 ` [PATCH 9/14] sound/oss/sb_ess.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-27 7:13 ` Takashi Iwai
2010-10-27 7:13 ` Takashi Iwai
2010-10-27 7:13 ` Takashi Iwai
2010-10-26 10:25 ` [PATCH 10/14] drivers/isdn: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 11:55 ` walter harms [this message]
2010-10-26 11:55 ` walter harms
2010-10-26 12:01 ` Julia Lawall
2010-10-26 12:01 ` Julia Lawall
2010-10-26 12:20 ` Julia Lawall
2010-10-26 12:20 ` Julia Lawall
2010-10-27 19:24 ` David Miller
2010-10-27 19:24 ` David Miller
2010-10-26 10:25 ` [PATCH 11/14] drivers/serial/vr41xx_siu.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 12/14] drivers/video/omap/blizzard.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 12:36 ` [PATCH 12/14] drivers/video/omap/blizzard.c: delete double Nicolas Kaiser
2010-10-26 12:36 ` [PATCH 12/14] drivers/video/omap/blizzard.c: delete double assignment Nicolas Kaiser
2010-10-26 10:25 ` [PATCH 13/14] drivers/scsi/be2iscsi/be_main.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 14/14] drivers/ata/pata_octeon_cf.c: " Julia Lawall
2010-10-26 10:25 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC6C1C0.8020005@bfs.de \
--to=wharms@bfs.de \
--cc=isdn@linux-pingi.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.