From: Marcelo Tosatti <mtosatti@redhat.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: Jan Kiszka <jan.kiszka@web.de>,
kernel-janitors@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch v2] x86: kvm: x86: fix information leak to userland
Date: Mon, 01 Nov 2010 17:19:37 +0000 [thread overview]
Message-ID: <20101101171937.GA4484@amt.cnet> (raw)
In-Reply-To: <20101030185447.GA7629@albatros>
On Sat, Oct 30, 2010 at 10:54:47PM +0400, Vasiliy Kulikov wrote:
> Structures kvm_vcpu_events, kvm_debugregs, kvm_pit_state2 and
> kvm_clock_data are copied to userland with some padding and reserved
> fields unitialized. It leads to leaking of contents of kernel stack
> memory. We have to initialize them to zero.
>
> In patch v1 Jan Kiszka suggested to fill reserved fields with zeros
> instead of memset'ting the whole struct. It makes sense as these
> fields are explicitly marked as padding. No more fields need zeroing.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> Compile tesed only.
>
> arch/x86/kvm/x86.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: Jan Kiszka <jan.kiszka@web.de>,
kernel-janitors@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch v2] x86: kvm: x86: fix information leak to userland
Date: Mon, 1 Nov 2010 15:19:37 -0200 [thread overview]
Message-ID: <20101101171937.GA4484@amt.cnet> (raw)
In-Reply-To: <20101030185447.GA7629@albatros>
On Sat, Oct 30, 2010 at 10:54:47PM +0400, Vasiliy Kulikov wrote:
> Structures kvm_vcpu_events, kvm_debugregs, kvm_pit_state2 and
> kvm_clock_data are copied to userland with some padding and reserved
> fields unitialized. It leads to leaking of contents of kernel stack
> memory. We have to initialize them to zero.
>
> In patch v1 Jan Kiszka suggested to fill reserved fields with zeros
> instead of memset'ting the whole struct. It makes sense as these
> fields are explicitly marked as padding. No more fields need zeroing.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> Compile tesed only.
>
> arch/x86/kvm/x86.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
Applied, thanks.
next prev parent reply other threads:[~2010-11-01 17:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 14:11 [PATCH v2] x86: kvm: fix information leak to userland Vasiliy Kulikov
2010-10-30 14:11 ` Vasiliy Kulikov
2010-10-30 14:34 ` Jan Kiszka
2010-10-30 14:34 ` Jan Kiszka
2010-10-30 15:31 ` Vasiliy Kulikov
2010-10-30 15:31 ` Vasiliy Kulikov
2010-10-30 15:46 ` Jan Kiszka
2010-10-30 15:46 ` Jan Kiszka
2010-10-30 18:54 ` [patch v2] x86: kvm: x86: " Vasiliy Kulikov
2010-10-30 18:54 ` Vasiliy Kulikov
2010-11-01 17:19 ` Marcelo Tosatti [this message]
2010-11-01 17:19 ` Marcelo Tosatti
2011-07-26 17:05 ` Alexander Graf
2011-07-26 17:05 ` Alexander Graf
2011-07-26 17:24 ` Avi Kivity
2011-07-26 17:24 ` Avi Kivity
2011-07-26 17:38 ` Alexander Graf
2011-07-26 17:38 ` Alexander Graf
2011-07-26 17:28 ` Vasiliy Kulikov
2011-07-26 17:28 ` Vasiliy Kulikov
2011-07-26 17:39 ` Alexander Graf
2011-07-26 17:39 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101171937.GA4484@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=jan.kiszka@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=segooon@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.