From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Vasiliy Kulikov <segooon@gmail.com>,
Jan Kiszka <jan.kiszka@web.de>,
kernel-janitors@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch v2] x86: kvm: x86: fix information leak to userland
Date: Tue, 26 Jul 2011 17:24:33 +0000 [thread overview]
Message-ID: <4E2EF851.8060202@redhat.com> (raw)
In-Reply-To: <ABD7343A-6440-4CC0-B8B0-9D27EF0291B0@suse.de>
On 07/26/2011 08:05 PM, Alexander Graf wrote:
> struct kvm_pit_state2 {
> struct kvm_pit_channel_state channels[3];
> __u32 flags;
> __u32 reserved[9];
> };
>
> So memset(&ps->reserved) would give you the a __u32 **, no? Same goes for all the other array sets in here. Or am I understanding some C logic wrong? :)
>
An address of an array is the array itself.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Vasiliy Kulikov <segooon@gmail.com>,
Jan Kiszka <jan.kiszka@web.de>,
kernel-janitors@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch v2] x86: kvm: x86: fix information leak to userland
Date: Tue, 26 Jul 2011 20:24:33 +0300 [thread overview]
Message-ID: <4E2EF851.8060202@redhat.com> (raw)
In-Reply-To: <ABD7343A-6440-4CC0-B8B0-9D27EF0291B0@suse.de>
On 07/26/2011 08:05 PM, Alexander Graf wrote:
> struct kvm_pit_state2 {
> struct kvm_pit_channel_state channels[3];
> __u32 flags;
> __u32 reserved[9];
> };
>
> So memset(&ps->reserved) would give you the a __u32 **, no? Same goes for all the other array sets in here. Or am I understanding some C logic wrong? :)
>
An address of an array is the array itself.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-07-26 17:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 14:11 [PATCH v2] x86: kvm: fix information leak to userland Vasiliy Kulikov
2010-10-30 14:11 ` Vasiliy Kulikov
2010-10-30 14:34 ` Jan Kiszka
2010-10-30 14:34 ` Jan Kiszka
2010-10-30 15:31 ` Vasiliy Kulikov
2010-10-30 15:31 ` Vasiliy Kulikov
2010-10-30 15:46 ` Jan Kiszka
2010-10-30 15:46 ` Jan Kiszka
2010-10-30 18:54 ` [patch v2] x86: kvm: x86: " Vasiliy Kulikov
2010-10-30 18:54 ` Vasiliy Kulikov
2010-11-01 17:19 ` Marcelo Tosatti
2010-11-01 17:19 ` Marcelo Tosatti
2011-07-26 17:05 ` Alexander Graf
2011-07-26 17:05 ` Alexander Graf
2011-07-26 17:24 ` Avi Kivity [this message]
2011-07-26 17:24 ` Avi Kivity
2011-07-26 17:38 ` Alexander Graf
2011-07-26 17:38 ` Alexander Graf
2011-07-26 17:28 ` Vasiliy Kulikov
2011-07-26 17:28 ` Vasiliy Kulikov
2011-07-26 17:39 ` Alexander Graf
2011-07-26 17:39 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2EF851.8060202@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=hpa@zytor.com \
--cc=jan.kiszka@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=segooon@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.