From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
rostedt@goodmis.org, andi@firstfloor.org, lwoodman@redhat.com,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/2] tracing,mm - add kernel pagefault tracepoint for x86 & x86_64
Date: Wed, 10 Nov 2010 17:28:06 +0100 [thread overview]
Message-ID: <20101110162806.GD7205@basil.fritz.box> (raw)
In-Reply-To: <20101110152001.GA5707@infradead.org>
On Wed, Nov 10, 2010 at 10:20:02AM -0500, Christoph Hellwig wrote:
> On Wed, Nov 10, 2010 at 04:17:50PM +0100, Jiri Olsa wrote:
> > I guess I can take the regs out then.. would that patch be acceptable
> > afterwards..?
>
> I really can't make much sense out of this whole trace point. What
> use it the task_struct address for example?
>
> What would be much more interesting is telling us if we had a
> major/minor fault, if ->page_mkwrite was called, etc.
Also on x86 I would log the error code.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-11-10 16:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 11:56 [PATCH 0/2] tracing,mm - add kernel pagefault tracepoint for x86 & x86_64 Jiri Olsa
2010-11-10 11:56 ` [PATCH 1/2] " Jiri Olsa
2010-11-10 13:29 ` Christoph Hellwig
2010-11-10 13:44 ` Jiri Olsa
2010-11-10 13:52 ` Ingo Molnar
2010-11-10 15:00 ` Frederic Weisbecker
2010-11-10 15:17 ` Jiri Olsa
2010-11-10 15:20 ` Christoph Hellwig
2010-11-10 16:28 ` Andi Kleen [this message]
2010-11-10 16:44 ` Frederic Weisbecker
2010-11-11 9:09 ` [PATCHv2 0/2] " Jiri Olsa
2010-11-11 9:09 ` [PATCHv2 1/2] tracing - fix recursive user stack trace Jiri Olsa
2010-11-11 10:34 ` Andi Kleen
2010-11-11 9:09 ` [PATCHv2 2/2] tracing,mm - add kernel pagefault tracepoint for x86 & x86_64 Jiri Olsa
2010-11-11 12:51 ` Christoph Hellwig
2010-11-11 13:15 ` Jiri Olsa
2010-11-15 13:43 ` Frederic Weisbecker
2010-11-15 14:06 ` Andi Kleen
2010-11-15 14:54 ` Frederic Weisbecker
2010-11-15 15:04 ` Steven Rostedt
2010-11-15 14:19 ` Steven Rostedt
2010-11-16 9:23 ` Jiri Olsa
2010-11-16 13:13 ` Steven Rostedt
2010-11-10 11:56 ` [PATCH 2/2] tracing - fix recursive user stack trace Jiri Olsa
2010-11-11 0:13 ` Li Zefan
2010-11-11 21:57 ` Steven Rostedt
2010-11-18 14:05 ` [tip:perf/core] tracing: Fix " tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110162806.GD7205@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.