From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: mingo@elte.hu, rostedt@goodmis.org, andi@firstfloor.org,
lwoodman@redhat.com, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] tracing - fix recursive user stack trace
Date: Thu, 11 Nov 2010 11:34:15 +0100 [thread overview]
Message-ID: <20101111103415.GD18718@basil.fritz.box> (raw)
In-Reply-To: <1289466549-7602-2-git-send-email-jolsa@redhat.com>
On Thu, Nov 11, 2010 at 10:09:08AM +0100, Jiri Olsa wrote:
> The user stack trace can fault when examining the trace. Which
> would call the do_page_fault handler, which would trace again,
> which would do the user stack trace, which would fault and call
> do_page_fault again ...
>
> Thus this is causing a recursive bug. We need to have a recursion
> detector here.
I suspect this problem is in more trace points: any NMI or MCE
trace point or any other trace point that can be triggered
from a page. so it seems to be a general bug fix independent
of the other patch.
-Andi
next prev parent reply other threads:[~2010-11-11 10:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 11:56 [PATCH 0/2] tracing,mm - add kernel pagefault tracepoint for x86 & x86_64 Jiri Olsa
2010-11-10 11:56 ` [PATCH 1/2] " Jiri Olsa
2010-11-10 13:29 ` Christoph Hellwig
2010-11-10 13:44 ` Jiri Olsa
2010-11-10 13:52 ` Ingo Molnar
2010-11-10 15:00 ` Frederic Weisbecker
2010-11-10 15:17 ` Jiri Olsa
2010-11-10 15:20 ` Christoph Hellwig
2010-11-10 16:28 ` Andi Kleen
2010-11-10 16:44 ` Frederic Weisbecker
2010-11-11 9:09 ` [PATCHv2 0/2] " Jiri Olsa
2010-11-11 9:09 ` [PATCHv2 1/2] tracing - fix recursive user stack trace Jiri Olsa
2010-11-11 10:34 ` Andi Kleen [this message]
2010-11-11 9:09 ` [PATCHv2 2/2] tracing,mm - add kernel pagefault tracepoint for x86 & x86_64 Jiri Olsa
2010-11-11 12:51 ` Christoph Hellwig
2010-11-11 13:15 ` Jiri Olsa
2010-11-15 13:43 ` Frederic Weisbecker
2010-11-15 14:06 ` Andi Kleen
2010-11-15 14:54 ` Frederic Weisbecker
2010-11-15 15:04 ` Steven Rostedt
2010-11-15 14:19 ` Steven Rostedt
2010-11-16 9:23 ` Jiri Olsa
2010-11-16 13:13 ` Steven Rostedt
2010-11-10 11:56 ` [PATCH 2/2] tracing - fix recursive user stack trace Jiri Olsa
2010-11-11 0:13 ` Li Zefan
2010-11-11 21:57 ` Steven Rostedt
2010-11-18 14:05 ` [tip:perf/core] tracing: Fix " tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111103415.GD18718@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.