From: Jarkko Nikula <jhnikula@gmail.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@freescale.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: atmel: test wrong variable
Date: Mon, 22 Nov 2010 09:43:53 +0200 [thread overview]
Message-ID: <20101122094353.f76830b5.jhnikula@gmail.com> (raw)
In-Reply-To: <1290361216-15166-1-git-send-email-segoon@openwall.com>
On Sun, 21 Nov 2010 20:40:14 +0300
Vasiliy Kulikov <segoon@openwall.com> wrote:
> After clk_get() mclk is checked second time instead of pllb check.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile this driver, so it is not tested.
>
> sound/soc/atmel/sam9g20_wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index da9c303..68072a2 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -223,7 +223,7 @@ static int __init at91sam9g20ek_init(void)
> }
>
> pllb = clk_get(NULL, "pllb");
> - if (IS_ERR(mclk)) {
> + if (IS_ERR(pllb)) {
> printk(KERN_ERR "ASoC: Failed to get PLLB\n");
> ret = PTR_ERR(mclk);
Update also PTR_ERR as otherwise we don't return any error code
(mclk is ok at this point but pllb has an error).
--
Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jhnikula@gmail.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@freescale.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: atmel: test wrong variable
Date: Mon, 22 Nov 2010 07:43:53 +0000 [thread overview]
Message-ID: <20101122094353.f76830b5.jhnikula@gmail.com> (raw)
In-Reply-To: <1290361216-15166-1-git-send-email-segoon@openwall.com>
On Sun, 21 Nov 2010 20:40:14 +0300
Vasiliy Kulikov <segoon@openwall.com> wrote:
> After clk_get() mclk is checked second time instead of pllb check.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile this driver, so it is not tested.
>
> sound/soc/atmel/sam9g20_wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index da9c303..68072a2 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -223,7 +223,7 @@ static int __init at91sam9g20ek_init(void)
> }
>
> pllb = clk_get(NULL, "pllb");
> - if (IS_ERR(mclk)) {
> + if (IS_ERR(pllb)) {
> printk(KERN_ERR "ASoC: Failed to get PLLB\n");
> ret = PTR_ERR(mclk);
Update also PTR_ERR as otherwise we don't return any error code
(mclk is ok at this point but pllb has an error).
--
Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jhnikula@gmail.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Timur Tabi <timur@freescale.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: atmel: test wrong variable
Date: Mon, 22 Nov 2010 09:43:53 +0200 [thread overview]
Message-ID: <20101122094353.f76830b5.jhnikula@gmail.com> (raw)
In-Reply-To: <1290361216-15166-1-git-send-email-segoon@openwall.com>
On Sun, 21 Nov 2010 20:40:14 +0300
Vasiliy Kulikov <segoon@openwall.com> wrote:
> After clk_get() mclk is checked second time instead of pllb check.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile this driver, so it is not tested.
>
> sound/soc/atmel/sam9g20_wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index da9c303..68072a2 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -223,7 +223,7 @@ static int __init at91sam9g20ek_init(void)
> }
>
> pllb = clk_get(NULL, "pllb");
> - if (IS_ERR(mclk)) {
> + if (IS_ERR(pllb)) {
> printk(KERN_ERR "ASoC: Failed to get PLLB\n");
> ret = PTR_ERR(mclk);
Update also PTR_ERR as otherwise we don't return any error code
(mclk is ok at this point but pllb has an error).
--
Jarkko
next prev parent reply other threads:[~2010-11-22 7:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 17:40 [PATCH] ASoC: atmel: test wrong variable Vasiliy Kulikov
2010-11-21 17:40 ` Vasiliy Kulikov
2010-11-22 7:43 ` Jarkko Nikula [this message]
2010-11-22 7:43 ` Jarkko Nikula
2010-11-22 7:43 ` Jarkko Nikula
2010-11-22 15:59 ` [PATCH v2] " Vasiliy Kulikov
2010-11-22 15:59 ` Vasiliy Kulikov
2010-11-22 16:04 ` Timur Tabi
2010-11-22 16:04 ` Timur Tabi
2010-11-22 16:04 ` Timur Tabi
2010-11-22 16:05 ` Liam Girdwood
2010-11-22 16:05 ` Liam Girdwood
2010-11-22 20:27 ` Mark Brown
2010-11-22 20:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122094353.f76830b5.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=segoon@openwall.com \
--cc=timur@freescale.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.