From: Vasiliy Kulikov <segoon@openwall.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Timur Tabi <timur@freescale.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, Jarkko Nikula <jhnikula@gmail.com>
Subject: [PATCH v2] ASoC: atmel: test wrong variable
Date: Mon, 22 Nov 2010 18:59:13 +0300 [thread overview]
Message-ID: <20101122155913.GA9089@albatros> (raw)
In-Reply-To: <20101122094353.f76830b5.jhnikula@gmail.com>
After clk_get() mclk is checked second time instead of pllb check.
In patch v1 Jarkko Nikula noticed that PTR_ERR() is also has wrong argument.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
sound/soc/atmel/sam9g20_wm8731.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index da9c303..f16e00c 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -223,9 +223,9 @@ static int __init at91sam9g20ek_init(void)
}
pllb = clk_get(NULL, "pllb");
- if (IS_ERR(mclk)) {
+ if (IS_ERR(pllb)) {
printk(KERN_ERR "ASoC: Failed to get PLLB\n");
- ret = PTR_ERR(mclk);
+ ret = PTR_ERR(pllb);
goto err_mclk;
}
ret = clk_set_parent(mclk, pllb);
--
1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segoon@openwall.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Timur Tabi <timur@freescale.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, Jarkko Nikula <jhnikula@gmail.com>
Subject: [PATCH v2] ASoC: atmel: test wrong variable
Date: Mon, 22 Nov 2010 15:59:13 +0000 [thread overview]
Message-ID: <20101122155913.GA9089@albatros> (raw)
In-Reply-To: <20101122094353.f76830b5.jhnikula@gmail.com>
After clk_get() mclk is checked second time instead of pllb check.
In patch v1 Jarkko Nikula noticed that PTR_ERR() is also has wrong argument.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
sound/soc/atmel/sam9g20_wm8731.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index da9c303..f16e00c 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -223,9 +223,9 @@ static int __init at91sam9g20ek_init(void)
}
pllb = clk_get(NULL, "pllb");
- if (IS_ERR(mclk)) {
+ if (IS_ERR(pllb)) {
printk(KERN_ERR "ASoC: Failed to get PLLB\n");
- ret = PTR_ERR(mclk);
+ ret = PTR_ERR(pllb);
goto err_mclk;
}
ret = clk_set_parent(mclk, pllb);
--
1.7.0.4
next prev parent reply other threads:[~2010-11-22 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 17:40 [PATCH] ASoC: atmel: test wrong variable Vasiliy Kulikov
2010-11-21 17:40 ` Vasiliy Kulikov
2010-11-22 7:43 ` Jarkko Nikula
2010-11-22 7:43 ` Jarkko Nikula
2010-11-22 7:43 ` Jarkko Nikula
2010-11-22 15:59 ` Vasiliy Kulikov [this message]
2010-11-22 15:59 ` [PATCH v2] " Vasiliy Kulikov
2010-11-22 16:04 ` Timur Tabi
2010-11-22 16:04 ` Timur Tabi
2010-11-22 16:04 ` Timur Tabi
2010-11-22 16:05 ` Liam Girdwood
2010-11-22 16:05 ` Liam Girdwood
2010-11-22 20:27 ` Mark Brown
2010-11-22 20:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122155913.GA9089@albatros \
--to=segoon@openwall.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=perex@perex.cz \
--cc=timur@freescale.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.