From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration
Date: Wed, 24 Nov 2010 11:36:55 +0000 [thread overview]
Message-ID: <20101124113655.GC24970@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4CECCBAE.6080707@stericsson.com>
On Wed, Nov 24, 2010 at 09:24:14AM +0100, Bengt Jonsson wrote:
> The problem I see is that ab8500-core defines the number of
> regulators which I can see no reason for. If someone wants to add or
> remove a regulator they have to make a change in
> include/linux/mfd/ab8500.c as well as in the regulator files.
> I will add a better description in an updated patch.
Seems reasonable, though there's now an issue with the platform getting
the size of the array wrong - might be worth adding an array size for
the platform to initialise to catch that.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linus WALLEIJ <linus.walleij@stericsson.com>
Subject: Re: [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration
Date: Wed, 24 Nov 2010 11:36:55 +0000 [thread overview]
Message-ID: <20101124113655.GC24970@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4CECCBAE.6080707@stericsson.com>
On Wed, Nov 24, 2010 at 09:24:14AM +0100, Bengt Jonsson wrote:
> The problem I see is that ab8500-core defines the number of
> regulators which I can see no reason for. If someone wants to add or
> remove a regulator they have to make a change in
> include/linux/mfd/ab8500.c as well as in the regulator files.
> I will add a better description in an updated patch.
Seems reasonable, though there's now an issue with the platform getting
the size of the array wrong - might be worth adding an array size for
the platform to initialise to catch that.
next prev parent reply other threads:[~2010-11-24 11:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 18:25 [PATCH 0/3] regulators: Update of ab8500 driver Bengt Jonsson
2010-11-23 18:25 ` Bengt Jonsson
2010-11-23 18:25 ` [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration Bengt Jonsson
2010-11-23 18:25 ` Bengt Jonsson
2010-11-23 18:30 ` Mark Brown
2010-11-23 18:30 ` Mark Brown
2010-11-24 8:24 ` Bengt Jonsson
2010-11-24 8:24 ` Bengt Jonsson
2010-11-24 11:36 ` Mark Brown [this message]
2010-11-24 11:36 ` Mark Brown
2010-11-24 12:13 ` Bengt Jonsson
2010-11-24 12:13 ` Bengt Jonsson
2010-11-23 18:25 ` [PATCH 2/3] regulators: Update of ab8500 driver Bengt Jonsson
2010-11-23 18:25 ` Bengt Jonsson
2010-11-23 18:38 ` Mark Brown
2010-11-23 18:38 ` Mark Brown
2010-11-24 7:57 ` Bengt Jonsson
2010-11-24 7:57 ` Bengt Jonsson
2010-11-24 10:48 ` Mark Brown
2010-11-24 10:48 ` Mark Brown
2010-11-24 12:11 ` Bengt Jonsson
2010-11-24 12:11 ` Bengt Jonsson
2010-11-23 18:25 ` [PATCH 3/3] mach-ux500: Updated and added regulator board configuration in ab8500 Bengt Jonsson
2010-11-23 18:25 ` Bengt Jonsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124113655.GC24970@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.