All of lore.kernel.org
 help / color / mirror / Atom feed
From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: cns3xxx: Add architecture definition for EHCI/OHCI controller
Date: Thu, 25 Nov 2010 13:48:17 +0300	[thread overview]
Message-ID: <20101125104817.GA31779@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTimMEALmH08RKQet_MGiyEFYpD2kVtPtmKJpmhtZ@mail.gmail.com>

On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote:
[...]
> > ?#include <linux/module.h>
> > ?#include <linux/io.h>
> > ?#include <linux/delay.h>
> > +#include <asm/atomic.h>
> It's not necessary for mach/pm.h already included it, right?

Technically, it's not necessary. But in Linux we don't rely on
headers including other headers. Think that someday mach/pm.h
may not include asm/atomic.h, so the build will break.

Thanks,

> 
> > ?#include <mach/system.h>
> > ?#include <mach/cns3xxx.h>
> > ?#include <mach/pm.h>
> > @@ -117,3 +118,6 @@ int cns3xxx_cpu_clock(void)
> > ? ? ? ?return cpu;
> > ?}
> > ?EXPORT_SYMBOL(cns3xxx_cpu_clock);
> > +
> > +atomic_t usb_pwr_ref = ATOMIC_INIT(0);
> > +EXPORT_SYMBOL(usb_pwr_ref);

-- 
Anton Vorontsov
Email: cbouatmailru at gmail.com

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Lin Mac <mkl0301@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dbrownell@users.sourceforge.net, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: cns3xxx: Add architecture definition for EHCI/OHCI controller
Date: Thu, 25 Nov 2010 13:48:17 +0300	[thread overview]
Message-ID: <20101125104817.GA31779@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTimMEALmH08RKQet_MGiyEFYpD2kVtPtmKJpmhtZ@mail.gmail.com>

On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote:
[...]
> >  #include <linux/module.h>
> >  #include <linux/io.h>
> >  #include <linux/delay.h>
> > +#include <asm/atomic.h>
> It's not necessary for mach/pm.h already included it, right?

Technically, it's not necessary. But in Linux we don't rely on
headers including other headers. Think that someday mach/pm.h
may not include asm/atomic.h, so the build will break.

Thanks,

> 
> >  #include <mach/system.h>
> >  #include <mach/cns3xxx.h>
> >  #include <mach/pm.h>
> > @@ -117,3 +118,6 @@ int cns3xxx_cpu_clock(void)
> >        return cpu;
> >  }
> >  EXPORT_SYMBOL(cns3xxx_cpu_clock);
> > +
> > +atomic_t usb_pwr_ref = ATOMIC_INIT(0);
> > +EXPORT_SYMBOL(usb_pwr_ref);

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

  reply	other threads:[~2010-11-25 10:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 16:32 [PATCH v2 0/3] USB: add support for cns3xxx SOC's EHCI/OHCI controller mkl0301 at gmail.com
2010-11-22 16:32 ` mkl0301
2010-11-22 16:32 ` [PATCH v2 1/3] ARM: cns3xxx: Add new and export the old power management functions mkl0301 at gmail.com
2010-11-22 16:32   ` mkl0301
2010-11-24 16:11   ` Anton Vorontsov
2010-11-24 16:11     ` Anton Vorontsov
2010-11-22 16:32 ` [PATCH v2 2/3] ARM: cns3xxx: Add architecture definition for EHCI/OHCI controller mkl0301 at gmail.com
2010-11-22 16:32   ` mkl0301
2010-11-24 16:11   ` Anton Vorontsov
2010-11-24 16:11     ` Anton Vorontsov
2010-11-25  7:25     ` Lin Mac
2010-11-25  7:25       ` Lin Mac
2010-11-25 10:48       ` Anton Vorontsov [this message]
2010-11-25 10:48         ` Anton Vorontsov
2010-11-25 13:51         ` Lin Mac
2010-11-25 13:51           ` Lin Mac
2010-11-25 13:56           ` Anton Vorontsov
2010-11-25 13:56             ` Anton Vorontsov
2010-11-25 15:37             ` Alan Stern
2010-11-25 15:37               ` Alan Stern
2010-11-25 16:15               ` Anton Vorontsov
2010-11-25 16:15                 ` Anton Vorontsov
2010-11-22 16:32 ` [PATCH v2 3/3] USB: cns3xxx: Add EHCI and OHCI bus glue for cns3xxx SOCs mkl0301 at gmail.com
2010-11-22 16:32   ` mkl0301
2010-11-24 16:25   ` Anton Vorontsov
2010-11-24 16:25     ` Anton Vorontsov
2010-11-25 13:12     ` Anton Vorontsov
2010-11-25 13:12       ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101125104817.GA31779@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.