From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] MCDE: Add build files and bus
Date: Tue, 30 Nov 2010 10:48:34 -0800 [thread overview]
Message-ID: <20101130184834.GA16055@kroah.com> (raw)
In-Reply-To: <20101130184049.GC8521@n2100.arm.linux.org.uk>
On Tue, Nov 30, 2010 at 06:40:49PM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 30, 2010 at 04:21:47PM +0100, Arnd Bergmann wrote:
> > On Tuesday 30 November 2010, Linus Walleij wrote:
> > > 2010/11/26 Arnd Bergmann <arnd@arndb.de>:
> > >
> > > > * When you say that the devices are static, I hope you do not mean
> > > > static in the C language sense. We used to allow devices to be
> > > > declared as "static struct" and registered using
> > > > platform_device_register (or other bus specific functions). This
> > > > is no longer valid and we are removing the existing users, do not
> > > > add new ones. When creating a platform device, use
> > > > platform_device_register_simple or platform_device_register_resndata.
> > >
> > > Is this part of the generic ARM runtime multi-platform kernel
> > > and device trees shebang?
> > >
> > > The Ux500 still isn't in that sector, it needs extensive rewriting
> > > of arch/arm/mach-ux500 to be done first, so as to support e.g.
> > > U8500 and U5500 with a single kernel image.
> > >
> > > Trying to skin that cat that as part of this review is a bit too
> > > much to ask IMO, I'd rather have the author of this driver
> > > adapt to whatever platform data registration mechanism is
> > > in place for the merge window. Else it needs fixing as part
> > > of a bigger endavour to root out compile-time platform
> > > configuration.
> >
> > The 'no static devices' rule is something that Greg brought up
> > at the embedded developer session during PlumbersConf this year,
> > I wasn't aware of the problem before that either.
> >
> > It is not related to the multi-platform kernel work and it's
> > not ARM specific.
> >
> > Maybe Greg can give a short explanation of the impact of this.
> > AFAIR, static device definitions still work, but there are
> > plans to remove that capability in the future.
>
> There's lots of static devices, not only platform devices, in the ARM
> tree. It's going to be a hell of a lot of work to fix this all up
> properly.
I agree, it's been abused for many years this way :(
> I hope that the capability for static devices won't disappear until
> the huge pile of work on ARM has been completed.
Don't worry, it will not.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Jimmy RUBIN <jimmy.rubin@stericsson.com>,
Dan JOHANSSON <dan.johansson@stericsson.com>,
Marcus LORENTZON <marcus.xm.lorentzon@stericsson.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH 09/10] MCDE: Add build files and bus
Date: Tue, 30 Nov 2010 10:48:34 -0800 [thread overview]
Message-ID: <20101130184834.GA16055@kroah.com> (raw)
In-Reply-To: <20101130184049.GC8521@n2100.arm.linux.org.uk>
On Tue, Nov 30, 2010 at 06:40:49PM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 30, 2010 at 04:21:47PM +0100, Arnd Bergmann wrote:
> > On Tuesday 30 November 2010, Linus Walleij wrote:
> > > 2010/11/26 Arnd Bergmann <arnd@arndb.de>:
> > >
> > > > * When you say that the devices are static, I hope you do not mean
> > > > static in the C language sense. We used to allow devices to be
> > > > declared as "static struct" and registered using
> > > > platform_device_register (or other bus specific functions). This
> > > > is no longer valid and we are removing the existing users, do not
> > > > add new ones. When creating a platform device, use
> > > > platform_device_register_simple or platform_device_register_resndata.
> > >
> > > Is this part of the generic ARM runtime multi-platform kernel
> > > and device trees shebang?
> > >
> > > The Ux500 still isn't in that sector, it needs extensive rewriting
> > > of arch/arm/mach-ux500 to be done first, so as to support e.g.
> > > U8500 and U5500 with a single kernel image.
> > >
> > > Trying to skin that cat that as part of this review is a bit too
> > > much to ask IMO, I'd rather have the author of this driver
> > > adapt to whatever platform data registration mechanism is
> > > in place for the merge window. Else it needs fixing as part
> > > of a bigger endavour to root out compile-time platform
> > > configuration.
> >
> > The 'no static devices' rule is something that Greg brought up
> > at the embedded developer session during PlumbersConf this year,
> > I wasn't aware of the problem before that either.
> >
> > It is not related to the multi-platform kernel work and it's
> > not ARM specific.
> >
> > Maybe Greg can give a short explanation of the impact of this.
> > AFAIR, static device definitions still work, but there are
> > plans to remove that capability in the future.
>
> There's lots of static devices, not only platform devices, in the ARM
> tree. It's going to be a hell of a lot of work to fix this all up
> properly.
I agree, it's been abused for many years this way :(
> I hope that the capability for static devices won't disappear until
> the huge pile of work on ARM has been completed.
Don't worry, it will not.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-30 18:48 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F45880696056844FA6A73F415B568C6953604E802E@EXDCVYMBSTM006.EQ1STM.local>
2010-11-25 12:25 ` [PATCH 09/10] MCDE: Add build files and bus Marcus LORENTZON
2010-11-25 16:47 ` Arnd Bergmann
2010-11-25 18:00 ` Marcus LORENTZON
2010-11-26 11:24 ` Arnd Bergmann
2010-11-26 11:24 ` Arnd Bergmann
2010-11-26 11:24 ` Arnd Bergmann
2010-11-30 14:18 ` Linus Walleij
2010-11-30 14:18 ` Linus Walleij
2010-11-30 15:21 ` Arnd Bergmann
2010-11-30 15:21 ` Arnd Bergmann
2010-11-30 16:24 ` Greg KH
2010-11-30 16:24 ` Greg KH
2010-11-30 18:40 ` Russell King - ARM Linux
2010-11-30 18:40 ` Russell King - ARM Linux
2010-11-30 18:48 ` Greg KH [this message]
2010-11-30 18:48 ` Greg KH
2010-11-30 22:05 ` Russell King - ARM Linux
2010-11-30 22:05 ` Russell King - ARM Linux
2010-11-30 23:05 ` Greg KH
2010-11-30 23:05 ` Greg KH
2010-11-30 23:42 ` Russell King - ARM Linux
2010-11-30 23:42 ` Russell King - ARM Linux
2010-11-30 23:49 ` Greg KH
2010-11-30 23:49 ` Greg KH
2010-11-30 23:49 ` Greg KH
2010-12-01 12:53 ` Peter Stuge
2010-12-01 12:53 ` Peter Stuge
2010-12-01 13:02 ` Russell King - ARM Linux
2010-12-01 13:02 ` Russell King - ARM Linux
2010-12-01 15:39 ` Arnd Bergmann
2010-12-01 15:39 ` Arnd Bergmann
2010-12-01 15:39 ` Arnd Bergmann
2010-12-04 6:52 ` Dave Airlie
2010-12-04 6:52 ` Dave Airlie
2010-12-04 6:52 ` Dave Airlie
2010-12-04 21:34 ` Alex Deucher
2010-12-04 21:34 ` Alex Deucher
2010-12-05 11:28 ` Daniel Vetter
2010-12-05 11:28 ` Daniel Vetter
2010-12-05 11:28 ` Daniel Vetter
2011-03-12 15:59 ` Rob Clark
2011-03-12 15:59 ` Rob Clark
2011-03-12 15:59 ` Rob Clark
2011-03-14 14:03 ` Marcus Lorentzon
2011-03-14 14:03 ` Marcus Lorentzon
2011-03-14 20:35 ` Rob Clark
2011-03-14 20:35 ` Rob Clark
2011-03-14 20:35 ` Rob Clark
2010-12-16 18:26 ` Marcus Lorentzon
2010-12-16 18:26 ` Marcus Lorentzon
2010-12-16 18:26 ` Marcus Lorentzon
2010-12-17 11:22 ` Arnd Bergmann
2010-12-17 11:22 ` Arnd Bergmann
2010-12-17 12:02 ` Marcus Lorentzon
2010-12-17 12:02 ` Marcus Lorentzon
2010-11-10 12:04 [PATCH 00/10] MCDE: Add frame buffer device driver Jimmy Rubin
2010-11-10 12:04 ` [PATCH 01/10] MCDE: Add hardware abstraction layer Jimmy Rubin
2010-11-10 12:04 ` [PATCH 02/10] MCDE: Add configuration registers Jimmy Rubin
2010-11-10 12:04 ` [PATCH 03/10] MCDE: Add pixel processing registers Jimmy Rubin
2010-11-10 12:04 ` [PATCH 04/10] MCDE: Add formatter registers Jimmy Rubin
2010-11-10 12:04 ` [PATCH 05/10] MCDE: Add dsi link registers Jimmy Rubin
2010-11-10 12:04 ` [PATCH 06/10] MCDE: Add generic display Jimmy Rubin
2010-11-10 12:04 ` [PATCH 07/10] MCDE: Add display subsystem framework Jimmy Rubin
2010-11-10 12:04 ` [PATCH 08/10] MCDE: Add frame buffer device Jimmy Rubin
2010-11-10 12:04 ` [PATCH 09/10] MCDE: Add build files and bus Jimmy Rubin
2010-11-10 12:04 ` Jimmy Rubin
2010-11-10 12:04 ` Jimmy Rubin
2010-11-12 16:23 ` Arnd Bergmann
2010-11-12 16:23 ` Arnd Bergmann
2010-11-12 16:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130184834.GA16055@kroah.com \
--to=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.