From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/libdm/ioctl libdm-iface.c
Date: 30 Nov 2010 22:32:45 -0000 [thread overview]
Message-ID: <20101130223245.11604.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2010-11-30 22:32:45
Modified files:
libdm/ioctl : libdm-iface.c
Log message:
Add error path stack traces
Check for errors from dm_task_set_name() and dm_task_run().
Add stack traces for error paths.
Return 0 if some error is found.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.83&r2=1.84
--- LVM2/libdm/ioctl/libdm-iface.c 2010/10/25 11:44:20 1.83
+++ LVM2/libdm/ioctl/libdm-iface.c 2010/11/30 22:32:44 1.84
@@ -1594,8 +1594,15 @@
!strcmp(dirent->d_name, "..") ||
!strcmp(dirent->d_name, "control"))
continue;
- dm_task_set_name(dmt, dirent->d_name);
- dm_task_run(dmt);
+ if (!dm_task_set_name(dmt, dirent->d_name)) {
+ r = 0;
+ stack;
+ continue; /* try next name */
+ }
+ if (!dm_task_run(dmt)) {
+ r = 0;
+ stack; /* keep going */
+ }
}
if (closedir(d))
next reply other threads:[~2010-11-30 22:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 22:32 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-05 14:45 LVM2/libdm/ioctl libdm-iface.c prajnoha
2012-03-01 10:46 zkabelac
2011-11-08 19:02 snitzer
2011-10-17 14:36 zkabelac
2011-09-23 17:16 agk
2011-09-22 18:00 prajnoha
2011-08-19 16:49 agk
2011-06-29 16:08 agk
2011-06-29 11:36 agk
2011-06-29 8:54 agk
2011-06-13 3:53 agk
2011-03-20 2:00 agk
2011-03-20 13:09 ` Zdenek Kabelac
2011-03-20 21:41 ` Alasdair G Kergon
2011-03-20 23:51 ` Zdenek Kabelac
2011-03-21 1:47 ` Alasdair G Kergon
2011-03-05 21:17 mbroz
2011-03-06 1:18 ` Alasdair G Kergon
2011-03-06 1:36 ` Milan Broz
2011-03-06 1:51 ` Alasdair G Kergon
2011-03-02 8:41 zkabelac
2011-02-04 21:26 agk
2011-01-31 11:54 prajnoha
2010-08-16 11:13 prajnoha
2010-07-28 10:30 prajnoha
2010-05-03 22:08 prajnoha
2009-08-06 15:02 prajnoha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130223245.11604.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.