From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: LVM2/libdm/ioctl libdm-iface.c
Date: Sun, 06 Mar 2011 02:36:58 +0100 [thread overview]
Message-ID: <4D72E53A.6070104@redhat.com> (raw)
In-Reply-To: <20110306011808.GW10767@agk-dp.fab.redhat.com>
On 03/06/2011 02:18 AM, Alasdair G Kergon wrote:
> On Sat, Mar 05, 2011 at 09:17:19PM -0000, mbroz at sourceware.org wrote:
>> This feature is not yet upstream and becuase cryptsetup in next version
>> uses this flag, it will cause a lot of noise on old kernels.
>
> Let's take this as a temporary change then, and once the new code becomes
> reasonably widely used, revert this patch, OK?
IMHO that message should not be there at all. If application relies on
it, then it must fail completely, warning is not enough.
For other uses it is optional.
Anyway, we can revert it even now, I added version check into cryptsetup
to detect kernel DM version and do not use that call if it is old.
And the same change will be needed in RHEL or people will complain...
Milan
next prev parent reply other threads:[~2011-03-06 1:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 21:17 LVM2/libdm/ioctl libdm-iface.c mbroz
2011-03-06 1:18 ` Alasdair G Kergon
2011-03-06 1:36 ` Milan Broz [this message]
2011-03-06 1:51 ` Alasdair G Kergon
-- strict thread matches above, loose matches on Subject: below --
2012-03-05 14:45 prajnoha
2012-03-01 10:46 zkabelac
2011-11-08 19:02 snitzer
2011-10-17 14:36 zkabelac
2011-09-23 17:16 agk
2011-09-22 18:00 prajnoha
2011-08-19 16:49 agk
2011-06-29 16:08 agk
2011-06-29 11:36 agk
2011-06-29 8:54 agk
2011-06-13 3:53 agk
2011-03-20 2:00 agk
2011-03-20 13:09 ` Zdenek Kabelac
2011-03-20 21:41 ` Alasdair G Kergon
2011-03-20 23:51 ` Zdenek Kabelac
2011-03-21 1:47 ` Alasdair G Kergon
2011-03-02 8:41 zkabelac
2011-02-04 21:26 agk
2011-01-31 11:54 prajnoha
2010-11-30 22:32 zkabelac
2010-08-16 11:13 prajnoha
2010-07-28 10:30 prajnoha
2010-05-03 22:08 prajnoha
2009-08-06 15:02 prajnoha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D72E53A.6070104@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.