From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Lars-Peter Clausen' <lars@metafoo.de>,
'Ben Dooks' <ben-linux@fluff.org>,
'Russell King' <linux@arm.linux.org.uk>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
'Abdoulaye Walsimou GAYE' <awg@embtoolkit.org>
Subject: Re: [PATCH v5] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks
Date: Wed, 1 Dec 2010 14:16:00 +0200 [thread overview]
Message-ID: <201012011416.01065.anarsoul@gmail.com> (raw)
In-Reply-To: <003c01cb914f$fc6d3350$f54799f0$%kim@samsung.com>
On Wednesday 01 December 2010 14:05:00 Kukjin Kim wrote:
> Yeah, right...it depends on each SoCs. But, if there is no setup it in
> map_io(), there is no functions of set_pull() and get_pull(). As you know,
> used s3c_gpio_{set,get}pull_1up as default before your patch...
>
> Hmm...however, I will think about its necessity again.
In this case it will fail if SoC does not support pull up, so does it matter
how it will fail?
> Ok..I will do it and will apply.
> Then, will be sent to Linus during 37-rc.
Thanks
Regards
Vasily
WARNING: multiple messages have this Message-ID (diff)
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] ARM: s3c244x: Fix mess with gpio {set, get}_pull callbacks
Date: Wed, 1 Dec 2010 14:16:00 +0200 [thread overview]
Message-ID: <201012011416.01065.anarsoul@gmail.com> (raw)
In-Reply-To: <003c01cb914f$fc6d3350$f54799f0$%kim@samsung.com>
On Wednesday 01 December 2010 14:05:00 Kukjin Kim wrote:
> Yeah, right...it depends on each SoCs. But, if there is no setup it in
> map_io(), there is no functions of set_pull() and get_pull(). As you know,
> used s3c_gpio_{set,get}pull_1up as default before your patch...
>
> Hmm...however, I will think about its necessity again.
In this case it will fail if SoC does not support pull up, so does it matter
how it will fail?
> Ok..I will do it and will apply.
> Then, will be sent to Linus during 37-rc.
Thanks
Regards
Vasily
next prev parent reply other threads:[~2010-12-01 12:16 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 22:00 [PATCH] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Lars-Peter Clausen
2010-09-20 22:00 ` Lars-Peter Clausen
2010-09-20 22:00 ` [PATCH] ARM: s3c24xx: Set ARCH_NR_GPIOS according to the selected SoC types Lars-Peter Clausen
2010-09-20 22:00 ` Lars-Peter Clausen
2010-09-20 23:41 ` [PATCH] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Ben Dooks
2010-09-20 23:41 ` Ben Dooks
2010-09-21 5:28 ` Abdoulaye Walsimou GAYE
2010-09-21 5:28 ` Abdoulaye Walsimou GAYE
2010-11-06 7:54 ` [PATCH v2] " Vasily Khoruzhick
2010-11-06 7:54 ` Vasily Khoruzhick
2010-11-06 16:09 ` Abdoulaye Walsimou GAYE
2010-11-08 9:08 ` Vasily Khoruzhick
2010-11-08 9:08 ` Vasily Khoruzhick
2010-11-08 20:26 ` [PATCH v3] " Vasily Khoruzhick
2010-11-08 20:26 ` Vasily Khoruzhick
2010-11-08 21:41 ` Abdoulaye Walsimou GAYE
2010-11-08 21:41 ` Abdoulaye Walsimou GAYE
2010-11-29 9:56 ` Vasily Khoruzhick
2010-11-29 9:56 ` Vasily Khoruzhick
2010-11-29 10:15 ` Kukjin Kim
2010-11-29 10:15 ` Kukjin Kim
2010-11-29 10:26 ` [PATCH RESEND " Vasily Khoruzhick
2010-11-29 10:26 ` Vasily Khoruzhick
2010-11-30 6:18 ` Kukjin Kim
2010-11-30 6:18 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks Kukjin Kim
2010-11-30 11:53 ` Lars-Peter Clausen
2010-11-30 11:53 ` Lars-Peter Clausen
2010-11-30 12:01 ` Vasily Khoruzhick
2010-11-30 12:01 ` Vasily Khoruzhick
2010-11-30 13:12 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Lars-Peter Clausen
2010-11-30 13:12 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks Lars-Peter Clausen
2010-11-30 14:33 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Vasily Khoruzhick
2010-11-30 14:33 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks Vasily Khoruzhick
2010-11-30 14:53 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Lars-Peter Clausen
2010-11-30 14:53 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks Lars-Peter Clausen
2010-11-30 15:01 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Vasily Khoruzhick
2010-11-30 15:01 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks Vasily Khoruzhick
2010-11-30 19:46 ` [PATCH v4] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks Vasily Khoruzhick
2010-11-30 19:59 ` Lars-Peter Clausen
2010-11-30 19:59 ` [PATCH v4] ARM: s3c244x: Fix mess with gpio {set, get}_pull callbacks Lars-Peter Clausen
2010-11-30 20:05 ` [PATCH v4] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks Vasily Khoruzhick
2010-11-30 20:05 ` [PATCH v4] ARM: s3c244x: Fix mess with gpio {set, get}_pull callbacks Vasily Khoruzhick
2010-11-30 20:12 ` [PATCH v5] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks Vasily Khoruzhick
2010-11-30 20:12 ` Vasily Khoruzhick
2010-12-01 0:22 ` [PATCH v5] ARM: s3c244x: Fix mess with gpio {set, get}_pull callbacks Ben Dooks
2010-12-03 9:40 ` Kukjin Kim
2010-12-01 7:26 ` [PATCH v5] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks Kukjin Kim
2010-12-01 7:26 ` Kukjin Kim
2010-12-01 10:17 ` Vasily Khoruzhick
2010-12-01 10:17 ` [PATCH v5] ARM: s3c244x: Fix mess with gpio {set, get}_pull callbacks Vasily Khoruzhick
2010-12-01 12:05 ` [PATCH v5] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks Kukjin Kim
2010-12-01 12:05 ` Kukjin Kim
2010-12-01 12:16 ` Vasily Khoruzhick [this message]
2010-12-01 12:16 ` [PATCH v5] ARM: s3c244x: Fix mess with gpio {set, get}_pull callbacks Vasily Khoruzhick
2010-12-01 5:28 ` [PATCH v4] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks Kukjin Kim
2010-12-01 5:28 ` Kukjin Kim
2010-12-01 6:19 ` Vasily Khoruzhick
2010-12-01 6:19 ` [PATCH v4] ARM: s3c244x: Fix mess with gpio {set, get}_pull callbacks Vasily Khoruzhick
2010-12-01 6:29 ` [PATCH v6] ARM: s3c244x: Fix mess with gpio {set,get}_pull callbacks Vasily Khoruzhick
2010-12-01 6:29 ` Vasily Khoruzhick
2010-11-30 19:46 ` [PATCH v4] " Vasily Khoruzhick
2010-12-01 5:19 ` [PATCH RESEND v3] ARM: s3c2442: Setup " Kukjin Kim
2010-12-01 5:19 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks Kukjin Kim
2010-11-29 10:28 ` [PATCH v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Vasily Khoruzhick
2010-11-29 10:28 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012011416.01065.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=awg@embtoolkit.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.