* OMAP4 build error - omapfb
@ 2010-12-02 21:25 ` Russell King - ARM Linux
0 siblings, 0 replies; 8+ messages in thread
From: Russell King - ARM Linux @ 2010-12-02 21:25 UTC (permalink / raw)
To: linux-arm-kernel, linux-omap
drivers/built-in.o: In function `omapfb_do_probe':
drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
such that it's only available for OMAP1, OMAP2 and OMAP3 ?
diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
index 455c605..083c8fe 100644
--- a/drivers/video/omap/Kconfig
+++ b/drivers/video/omap/Kconfig
@@ -1,7 +1,7 @@
config FB_OMAP
tristate "OMAP frame buffer support (EXPERIMENTAL)"
- depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
-
+ depends on FB && (OMAP2_DSS = "n")
+ depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
^ permalink raw reply related [flat|nested] 8+ messages in thread
* OMAP4 build error - omapfb
@ 2010-12-02 21:25 ` Russell King - ARM Linux
0 siblings, 0 replies; 8+ messages in thread
From: Russell King - ARM Linux @ 2010-12-02 21:25 UTC (permalink / raw)
To: linux-arm-kernel
drivers/built-in.o: In function `omapfb_do_probe':
drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
such that it's only available for OMAP1, OMAP2 and OMAP3 ?
diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
index 455c605..083c8fe 100644
--- a/drivers/video/omap/Kconfig
+++ b/drivers/video/omap/Kconfig
@@ -1,7 +1,7 @@
config FB_OMAP
tristate "OMAP frame buffer support (EXPERIMENTAL)"
- depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
-
+ depends on FB && (OMAP2_DSS = "n")
+ depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: OMAP4 build error - omapfb
2010-12-02 21:25 ` Russell King - ARM Linux
(?)
@ 2010-12-02 22:00 ` Tony Lindgren
-1 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2010-12-02 22:00 UTC (permalink / raw)
To: linux-arm-kernel
* Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> drivers/built-in.o: In function `omapfb_do_probe':
> drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
>
> Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> such that it's only available for OMAP1, OMAP2 and OMAP3 ?
This is something for Tomi, adding fbdev and Tomi to Cc.
Tony
> diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> index 455c605..083c8fe 100644
> --- a/drivers/video/omap/Kconfig
> +++ b/drivers/video/omap/Kconfig
> @@ -1,7 +1,7 @@
> config FB_OMAP
> tristate "OMAP frame buffer support (EXPERIMENTAL)"
> - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> -
> + depends on FB && (OMAP2_DSS = "n")
> + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* OMAP4 build error - omapfb
@ 2010-12-02 22:00 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2010-12-02 22:00 UTC (permalink / raw)
To: linux-arm-kernel
* Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> drivers/built-in.o: In function `omapfb_do_probe':
> drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
>
> Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> such that it's only available for OMAP1, OMAP2 and OMAP3 ?
This is something for Tomi, adding fbdev and Tomi to Cc.
Tony
> diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> index 455c605..083c8fe 100644
> --- a/drivers/video/omap/Kconfig
> +++ b/drivers/video/omap/Kconfig
> @@ -1,7 +1,7 @@
> config FB_OMAP
> tristate "OMAP frame buffer support (EXPERIMENTAL)"
> - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> -
> + depends on FB && (OMAP2_DSS = "n")
> + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: OMAP4 build error - omapfb
@ 2010-12-02 22:00 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2010-12-02 22:00 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: linux-arm-kernel, linux-omap, linux-fbdev, Tomi Valkeinen
* Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> drivers/built-in.o: In function `omapfb_do_probe':
> drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
>
> Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> such that it's only available for OMAP1, OMAP2 and OMAP3 ?
This is something for Tomi, adding fbdev and Tomi to Cc.
Tony
> diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> index 455c605..083c8fe 100644
> --- a/drivers/video/omap/Kconfig
> +++ b/drivers/video/omap/Kconfig
> @@ -1,7 +1,7 @@
> config FB_OMAP
> tristate "OMAP frame buffer support (EXPERIMENTAL)"
> - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> -
> + depends on FB && (OMAP2_DSS = "n")
> + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: OMAP4 build error - omapfb
2010-12-02 22:00 ` Tony Lindgren
(?)
@ 2010-12-14 12:44 ` Tomi Valkeinen
-1 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2010-12-14 12:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2010-12-02 at 14:00 -0800, ext Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> > drivers/built-in.o: In function `omapfb_do_probe':
> > drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
> >
> > Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> > only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> > and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> > such that it's only available for OMAP1, OMAP2 and OMAP3 ?
>
> This is something for Tomi, adding fbdev and Tomi to Cc.
Looks correct. The old omapfb will never work with OMAP4, so a
dependency to OMAP1/2/3 fixes the build problem. I'll add this fix to my
tree.
Tomi
>
> Tony
>
> > diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> > index 455c605..083c8fe 100644
> > --- a/drivers/video/omap/Kconfig
> > +++ b/drivers/video/omap/Kconfig
> > @@ -1,7 +1,7 @@
> > config FB_OMAP
> > tristate "OMAP frame buffer support (EXPERIMENTAL)"
> > - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> > -
> > + depends on FB && (OMAP2_DSS = "n")
> > + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* OMAP4 build error - omapfb
@ 2010-12-14 12:44 ` Tomi Valkeinen
0 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2010-12-14 12:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2010-12-02 at 14:00 -0800, ext Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> > drivers/built-in.o: In function `omapfb_do_probe':
> > drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
> >
> > Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> > only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> > and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> > such that it's only available for OMAP1, OMAP2 and OMAP3 ?
>
> This is something for Tomi, adding fbdev and Tomi to Cc.
Looks correct. The old omapfb will never work with OMAP4, so a
dependency to OMAP1/2/3 fixes the build problem. I'll add this fix to my
tree.
Tomi
>
> Tony
>
> > diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> > index 455c605..083c8fe 100644
> > --- a/drivers/video/omap/Kconfig
> > +++ b/drivers/video/omap/Kconfig
> > @@ -1,7 +1,7 @@
> > config FB_OMAP
> > tristate "OMAP frame buffer support (EXPERIMENTAL)"
> > - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> > -
> > + depends on FB && (OMAP2_DSS = "n")
> > + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: OMAP4 build error - omapfb
@ 2010-12-14 12:44 ` Tomi Valkeinen
0 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2010-12-14 12:44 UTC (permalink / raw)
To: ext Tony Lindgren
Cc: Russell King - ARM Linux, linux-arm-kernel, linux-omap,
linux-fbdev
On Thu, 2010-12-02 at 14:00 -0800, ext Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> > drivers/built-in.o: In function `omapfb_do_probe':
> > drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
> >
> > Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> > only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> > and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> > such that it's only available for OMAP1, OMAP2 and OMAP3 ?
>
> This is something for Tomi, adding fbdev and Tomi to Cc.
Looks correct. The old omapfb will never work with OMAP4, so a
dependency to OMAP1/2/3 fixes the build problem. I'll add this fix to my
tree.
Tomi
>
> Tony
>
> > diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> > index 455c605..083c8fe 100644
> > --- a/drivers/video/omap/Kconfig
> > +++ b/drivers/video/omap/Kconfig
> > @@ -1,7 +1,7 @@
> > config FB_OMAP
> > tristate "OMAP frame buffer support (EXPERIMENTAL)"
> > - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> > -
> > + depends on FB && (OMAP2_DSS = "n")
> > + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-12-14 12:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-02 21:25 OMAP4 build error - omapfb Russell King - ARM Linux
2010-12-02 21:25 ` Russell King - ARM Linux
2010-12-02 22:00 ` Tony Lindgren
2010-12-02 22:00 ` Tony Lindgren
2010-12-02 22:00 ` Tony Lindgren
2010-12-14 12:44 ` Tomi Valkeinen
2010-12-14 12:44 ` Tomi Valkeinen
2010-12-14 12:44 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.