From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
Date: Fri, 3 Dec 2010 12:25:54 +0000 [thread overview]
Message-ID: <20101203122554.GT859@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291368357.20452.6.camel@mola>
On Fri, Dec 03, 2010 at 05:25:57PM +0800, Axel Lin wrote:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
Date: Fri, 3 Dec 2010 12:25:54 +0000 [thread overview]
Message-ID: <20101203122554.GT859@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291368357.20452.6.camel@mola>
On Fri, Dec 03, 2010 at 05:25:57PM +0800, Axel Lin wrote:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
Applied, thanks.
next prev parent reply other threads:[~2010-12-03 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 9:25 [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id Axel Lin
2010-12-03 12:01 ` Liam Girdwood
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:25 ` Mark Brown [this message]
2010-12-03 12:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203122554.GT859@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.