From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
Date: Fri, 03 Dec 2010 13:21:22 +0100 [thread overview]
Message-ID: <874oavqc71.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <1291368357.20452.6.camel@mola> (Axel Lin's message of "Fri, 03 Dec 2010 17:25:57 +0800")
Axel Lin <axel.lin@gmail.com> writes:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
>
> Since we have checked codec id in alc5623_i2c_probe() by comparing
> vid2 with id->driver_data, it is not possible to run into the default case now.
>
> In case we may add more supported devices to alc5623_i2c_table in the future,
> this patch changes the default case return -EINVAL to let people know that
> they should not run into this case. They should also add a new case accordingly
> for the new id.
oh, yeah. makes sense. Thanks for noticing.
Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
WARNING: multiple messages have this Message-ID (diff)
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
Date: Fri, 03 Dec 2010 13:21:22 +0100 [thread overview]
Message-ID: <874oavqc71.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <1291368357.20452.6.camel@mola> (Axel Lin's message of "Fri, 03 Dec 2010 17:25:57 +0800")
Axel Lin <axel.lin@gmail.com> writes:
> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
>
> Since we have checked codec id in alc5623_i2c_probe() by comparing
> vid2 with id->driver_data, it is not possible to run into the default case now.
>
> In case we may add more supported devices to alc5623_i2c_table in the future,
> this patch changes the default case return -EINVAL to let people know that
> they should not run into this case. They should also add a new case accordingly
> for the new id.
oh, yeah. makes sense. Thanks for noticing.
Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
next prev parent reply other threads:[~2010-12-03 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 9:25 [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id Axel Lin
2010-12-03 12:01 ` Liam Girdwood
2010-12-03 12:21 ` Arnaud Patard [this message]
2010-12-03 12:21 ` Arnaud Patard
2010-12-03 12:25 ` Mark Brown
2010-12-03 12:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874oavqc71.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.