All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
	u.kleine-koenig@pengutronix.de, wim@iguana.be,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: imx: use clk_get to acquire the watchdog clock
Date: Tue, 7 Dec 2010 18:00:20 +0100	[thread overview]
Message-ID: <20101207170020.GC4134@pengutronix.de> (raw)
In-Reply-To: <20101207164905.GD6017@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

On Tue, Dec 07, 2010 at 05:49:05PM +0100, Sascha Hauer wrote:

> I should have seen this happen. This breaks i.MX1 reset which uses
> imx-wdt.0.
> 
> The root cause of this problem is that we have two different watchdog
> drivers with two different names but only one reset code for all i.MX.
> We could register an additional watchdog clock for all i.MXs and use it
> for the reset code.

Actually, there is no wdt-driver for mx1 yet. They _could_ be merged,
but the result will not be pretty.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] watchdog: imx: use clk_get to acquire the watchdog clock
Date: Tue, 7 Dec 2010 18:00:20 +0100	[thread overview]
Message-ID: <20101207170020.GC4134@pengutronix.de> (raw)
In-Reply-To: <20101207164905.GD6017@pengutronix.de>

On Tue, Dec 07, 2010 at 05:49:05PM +0100, Sascha Hauer wrote:

> I should have seen this happen. This breaks i.MX1 reset which uses
> imx-wdt.0.
> 
> The root cause of this problem is that we have two different watchdog
> drivers with two different names but only one reset code for all i.MX.
> We could register an additional watchdog clock for all i.MXs and use it
> for the reset code.

Actually, there is no wdt-driver for mx1 yet. They _could_ be merged,
but the result will not be pretty.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101207/d1c4df50/attachment.sig>

  reply	other threads:[~2010-12-07 17:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 16:16 [PATCH v2] watchdog: imx: use clk_get to acquire the watchdog clock Fabio Estevam
2010-12-07 16:16 ` Fabio Estevam
2010-12-07 16:49 ` Sascha Hauer
2010-12-07 16:49   ` Sascha Hauer
2010-12-07 17:00   ` Wolfram Sang [this message]
2010-12-07 17:00     ` Wolfram Sang
2010-12-07 17:16   ` [PATCH v2] watchdog: imx: use clk_get to acquire the watchdogclock Fabio Estevam
2010-12-07 17:16     ` Fabio Estevam
2010-12-07 18:50     ` Sascha Hauer
2010-12-07 18:50       ` Sascha Hauer
2010-12-10 13:18 ` [PATCH v2] watchdog: imx: use clk_get to acquire the watchdog clock Wim Van Sebroeck
2010-12-10 13:18   ` Wim Van Sebroeck
2010-12-13 11:46   ` Sascha Hauer
2010-12-13 11:46     ` Sascha Hauer
2010-12-10 13:52 ` Uwe Kleine-König
2010-12-10 13:52   ` Uwe Kleine-König
2010-12-14  8:57 ` Sascha Hauer
2010-12-14  8:57   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101207170020.GC4134@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=fabio.estevam@freescale.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.