From: Fabio Estevam <fabio.estevam@freescale.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Estevam Fabio-R49496 <r49496@freescale.com>,
<linux-arm-kernel@lists.infradead.org>, <kernel@pengutronix.de>,
<u.kleine-koenig@pengutronix.de>, <wim@iguana.be>,
<linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v2] watchdog: imx: use clk_get to acquire the watchdogclock
Date: Tue, 7 Dec 2010 15:16:15 -0200 [thread overview]
Message-ID: <4CFE6BDF.9030706@freescale.com> (raw)
In-Reply-To: <20101207164905.GD6017@pengutronix.de>
Hi Sascha,
On 12/7/2010 2:49 PM, Sascha Hauer wrote:
...
> I should have seen this happen. This breaks i.MX1 reset which uses
> imx-wdt.0.
I think it doesn´t break current mx1 reset mechanism. Please see the
code below (arcm/arm/plat-mxc/system.c):
if (cpu_is_mx1()) {
wcr_enable = (1 << 0);
} else {
struct clk *clk;
clk = clk_get_sys("imx2-wdt.0", NULL);
if (!IS_ERR(clk))
clk_enable(clk);
wcr_enable = (1 << 2);
}
For mx1 the clk_get_sys function is not called.
Regards,
Fabio Estevam
WARNING: multiple messages have this Message-ID (diff)
From: fabio.estevam@freescale.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] watchdog: imx: use clk_get to acquire the watchdogclock
Date: Tue, 7 Dec 2010 15:16:15 -0200 [thread overview]
Message-ID: <4CFE6BDF.9030706@freescale.com> (raw)
In-Reply-To: <20101207164905.GD6017@pengutronix.de>
Hi Sascha,
On 12/7/2010 2:49 PM, Sascha Hauer wrote:
...
> I should have seen this happen. This breaks i.MX1 reset which uses
> imx-wdt.0.
I think it doesn?t break current mx1 reset mechanism. Please see the
code below (arcm/arm/plat-mxc/system.c):
if (cpu_is_mx1()) {
wcr_enable = (1 << 0);
} else {
struct clk *clk;
clk = clk_get_sys("imx2-wdt.0", NULL);
if (!IS_ERR(clk))
clk_enable(clk);
wcr_enable = (1 << 2);
}
For mx1 the clk_get_sys function is not called.
Regards,
Fabio Estevam
next prev parent reply other threads:[~2010-12-07 17:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 16:16 [PATCH v2] watchdog: imx: use clk_get to acquire the watchdog clock Fabio Estevam
2010-12-07 16:16 ` Fabio Estevam
2010-12-07 16:49 ` Sascha Hauer
2010-12-07 16:49 ` Sascha Hauer
2010-12-07 17:00 ` Wolfram Sang
2010-12-07 17:00 ` Wolfram Sang
2010-12-07 17:16 ` Fabio Estevam [this message]
2010-12-07 17:16 ` [PATCH v2] watchdog: imx: use clk_get to acquire the watchdogclock Fabio Estevam
2010-12-07 18:50 ` Sascha Hauer
2010-12-07 18:50 ` Sascha Hauer
2010-12-10 13:18 ` [PATCH v2] watchdog: imx: use clk_get to acquire the watchdog clock Wim Van Sebroeck
2010-12-10 13:18 ` Wim Van Sebroeck
2010-12-13 11:46 ` Sascha Hauer
2010-12-13 11:46 ` Sascha Hauer
2010-12-10 13:52 ` Uwe Kleine-König
2010-12-10 13:52 ` Uwe Kleine-König
2010-12-14 8:57 ` Sascha Hauer
2010-12-14 8:57 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE6BDF.9030706@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=r49496@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.