All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Kaiser <nikai@nikai.net>
To: Dan Carpenter <error27@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Karsten Keil <isdn@linux-pingi.de>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn: return -EFAULT if copy_from_user() fails
Date: Sat, 11 Dec 2010 00:41:54 +0000	[thread overview]
Message-ID: <20101211014154.3157588b@absol.kitzblitz> (raw)
In-Reply-To: <20101210124009.GC10623@bicker>

Ahem, we're printing this return value:

* Dan Carpenter <error27@gmail.com>:
> -	if ((ret = copy_from_user(&size, p, sizeof(int)))) {
             ^^^
> +	if (copy_from_user(&size, p, sizeof(int))) {
>  		printk(KERN_ERR"isar_load_firmware copy_from_user ret %d\n", ret);
                                                                             ^^^
> -		return ret;
> +		return -EFAULT;

Cheers,
Nicolas Kaiser

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Kaiser <nikai@nikai.net>
To: Dan Carpenter <error27@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Karsten Keil <isdn@linux-pingi.de>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn: return -EFAULT if copy_from_user() fails
Date: Sat, 11 Dec 2010 01:41:54 +0100	[thread overview]
Message-ID: <20101211014154.3157588b@absol.kitzblitz> (raw)
In-Reply-To: <20101210124009.GC10623@bicker>

Ahem, we're printing this return value:

* Dan Carpenter <error27@gmail.com>:
> -	if ((ret = copy_from_user(&size, p, sizeof(int)))) {
             ^^^
> +	if (copy_from_user(&size, p, sizeof(int))) {
>  		printk(KERN_ERR"isar_load_firmware copy_from_user ret %d\n", ret);
                                                                             ^^^
> -		return ret;
> +		return -EFAULT;

Cheers,
Nicolas Kaiser

  parent reply	other threads:[~2010-12-11  0:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 12:40 [patch] isdn: return -EFAULT if copy_from_user() fails Dan Carpenter
2010-12-10 12:40 ` Dan Carpenter
2010-12-11  0:16 ` David Miller
2010-12-11  0:16   ` David Miller
2010-12-11  0:41 ` Nicolas Kaiser [this message]
2010-12-11  0:41   ` Nicolas Kaiser
2010-12-11  0:47   ` David Miller
2010-12-11  0:47     ` David Miller
2010-12-11  0:50     ` David Miller
2010-12-11  0:50       ` David Miller
2010-12-11  0:52       ` David Miller
2010-12-11  0:52         ` David Miller
2010-12-11  5:07         ` Dan Carpenter
2010-12-11  5:07           ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101211014154.3157588b@absol.kitzblitz \
    --to=nikai@nikai.net \
    --cc=davem@davemloft.net \
    --cc=error27@gmail.com \
    --cc=isdn@linux-pingi.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.