All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sukumar Ghorai <s-ghorai@ti.com>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] omap3: nand: configurable transfer type per board
Date: Fri, 17 Dec 2010 16:08:46 -0800	[thread overview]
Message-ID: <20101218000845.GW5941@atomide.com> (raw)
In-Reply-To: <1290785677-16005-3-git-send-email-s-ghorai@ti.com>

* Sukumar Ghorai <s-ghorai@ti.com> [101126 07:25]:
> nand transfer type (sDMA, Polled, prefetch) can be select from board file,
> enabling all transfer type in driver, by default.
> 
> this helps in multi-omap build and to select different transfer type for
> different board.
> 
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> ---
>  arch/arm/plat-omap/include/plat/nand.h |    7 +++
>  drivers/mtd/nand/Kconfig               |   17 ------
>  drivers/mtd/nand/omap2.c               |   92 +++++++++++--------------------
>  3 files changed, 40 insertions(+), 76 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/include/plat/nand.h b/arch/arm/plat-omap/include/plat/nand.h
> index 6562cd0..78c0bdb 100644
> --- a/arch/arm/plat-omap/include/plat/nand.h
> +++ b/arch/arm/plat-omap/include/plat/nand.h
> @@ -10,6 +10,12 @@
>  
>  #include <linux/mtd/partitions.h>
>  
> +enum nand_io {
> +	NAND_OMAP_PREFETCH_POLLED = 0,	/* prefetch polled mode, default */
> +	NAND_OMAP_POLLED,		/* polled mode, without prefetch */
> +	NAND_OMAP_PREFETCH_DMA		/* prefetch enabled sDMA mode */
> +};
> +
>  struct omap_nand_platform_data {
>  	unsigned int		options;
>  	int			cs;
> @@ -20,6 +26,7 @@ struct omap_nand_platform_data {
>  	int			(*nand_setup)(void);
>  	int			(*dev_ready)(struct omap_nand_platform_data *);
>  	int			dma_channel;
> +	enum nand_io		xfer_type;
>  	unsigned long		phys_base;
>  	int			devsize;
>  };

So maybe the devsize in patch 1/7 should be handled with this too?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] omap3: nand: configurable transfer type per board
Date: Fri, 17 Dec 2010 16:08:46 -0800	[thread overview]
Message-ID: <20101218000845.GW5941@atomide.com> (raw)
In-Reply-To: <1290785677-16005-3-git-send-email-s-ghorai@ti.com>

* Sukumar Ghorai <s-ghorai@ti.com> [101126 07:25]:
> nand transfer type (sDMA, Polled, prefetch) can be select from board file,
> enabling all transfer type in driver, by default.
> 
> this helps in multi-omap build and to select different transfer type for
> different board.
> 
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> ---
>  arch/arm/plat-omap/include/plat/nand.h |    7 +++
>  drivers/mtd/nand/Kconfig               |   17 ------
>  drivers/mtd/nand/omap2.c               |   92 +++++++++++--------------------
>  3 files changed, 40 insertions(+), 76 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/include/plat/nand.h b/arch/arm/plat-omap/include/plat/nand.h
> index 6562cd0..78c0bdb 100644
> --- a/arch/arm/plat-omap/include/plat/nand.h
> +++ b/arch/arm/plat-omap/include/plat/nand.h
> @@ -10,6 +10,12 @@
>  
>  #include <linux/mtd/partitions.h>
>  
> +enum nand_io {
> +	NAND_OMAP_PREFETCH_POLLED = 0,	/* prefetch polled mode, default */
> +	NAND_OMAP_POLLED,		/* polled mode, without prefetch */
> +	NAND_OMAP_PREFETCH_DMA		/* prefetch enabled sDMA mode */
> +};
> +
>  struct omap_nand_platform_data {
>  	unsigned int		options;
>  	int			cs;
> @@ -20,6 +26,7 @@ struct omap_nand_platform_data {
>  	int			(*nand_setup)(void);
>  	int			(*dev_ready)(struct omap_nand_platform_data *);
>  	int			dma_channel;
> +	enum nand_io		xfer_type;
>  	unsigned long		phys_base;
>  	int			devsize;
>  };

So maybe the devsize in patch 1/7 should be handled with this too?

Regards,

Tony

  reply	other threads:[~2010-12-18  0:08 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-26 15:34 [PATCH v6 0/7] nand prefetch-irq support and ecc layout chanage Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH 1/7] omap3630: nand: fix device size to work in polled mode Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-12-18  0:03   ` Tony Lindgren
2010-12-18  0:03     ` Tony Lindgren
2010-12-22  9:24     ` Ghorai, Sukumar
2010-12-22  9:24       ` Ghorai, Sukumar
2010-11-26 15:34 ` [PATCH 2/7] omap3: nand: configurable transfer type per board Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-12-18  0:08   ` Tony Lindgren [this message]
2010-12-18  0:08     ` Tony Lindgren
2010-12-22  7:52     ` Ghorai, Sukumar
2010-12-22  7:52       ` Ghorai, Sukumar
2010-11-26 15:34 ` [PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-12-18  0:09   ` Tony Lindgren
2010-12-18  0:09     ` Tony Lindgren
2010-12-22  8:00     ` Ghorai, Sukumar
2010-12-22  8:00       ` Ghorai, Sukumar
2010-11-26 15:34 ` [PATCH v6 4/7] omap3: nand: prefetch in irq mode support Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH v6 5/7] omap3: nand: configurable fifo threshold to gain the throughput Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH v6 6/7] omap: nand: ecc layout select from board file Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH v6 7/7] omap: nand: making ecc layout as compatible with romcode ecc Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 15:34   ` Sukumar Ghorai
2010-11-26 17:57 ` [PATCH v6 0/7] nand prefetch-irq support and ecc layout chanage Ghorai, Sukumar
2010-12-02  4:09   ` Charles Manning
2010-12-19 21:45 ` Charles Manning
2010-12-19 21:45   ` Charles Manning
2010-12-19 21:45   ` Charles Manning
2010-12-22  7:43   ` Ghorai, Sukumar
2010-12-22  7:43     ` Ghorai, Sukumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101218000845.GW5941@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=s-ghorai@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.