From: Tony Lindgren <tony@atomide.com>
To: Sukumar Ghorai <s-ghorai@ti.com>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc
Date: Fri, 17 Dec 2010 16:09:54 -0800 [thread overview]
Message-ID: <20101218000954.GX5941@atomide.com> (raw)
In-Reply-To: <1290785677-16005-4-git-send-email-s-ghorai@ti.com>
* Sukumar Ghorai <s-ghorai@ti.com> [101126 07:25]:
> add support the irq mode in GPMC.
> gpmc_init() function move after omap_init_irq() as it has dependecy on irq.
>
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> ---
> arch/arm/mach-omap2/board-2430sdp.c | 1 +
> arch/arm/mach-omap2/board-3430sdp.c | 1 +
> arch/arm/mach-omap2/board-3630sdp.c | 1 +
> arch/arm/mach-omap2/board-4430sdp.c | 2 +
> arch/arm/mach-omap2/board-am3517evm.c | 2 +
> arch/arm/mach-omap2/board-apollon.c | 1 +
> arch/arm/mach-omap2/board-cm-t35.c | 1 +
> arch/arm/mach-omap2/board-devkit8000.c | 1 +
> arch/arm/mach-omap2/board-generic.c | 2 +
> arch/arm/mach-omap2/board-h4.c | 1 +
> arch/arm/mach-omap2/board-igep0020.c | 1 +
> arch/arm/mach-omap2/board-ldp.c | 1 +
> arch/arm/mach-omap2/board-n8x0.c | 2 +
> arch/arm/mach-omap2/board-omap3beagle.c | 1 +
> arch/arm/mach-omap2/board-omap3evm.c | 2 +
> arch/arm/mach-omap2/board-omap3pandora.c | 2 +
> arch/arm/mach-omap2/board-omap3stalker.c | 1 +
> arch/arm/mach-omap2/board-omap3touchbook.c | 1 +
> arch/arm/mach-omap2/board-omap4panda.c | 2 +
> arch/arm/mach-omap2/board-overo.c | 1 +
> arch/arm/mach-omap2/board-rx51.c | 1 +
> arch/arm/mach-omap2/board-zoom2.c | 2 +
> arch/arm/mach-omap2/board-zoom3.c | 2 +
> arch/arm/mach-omap2/gpmc.c | 39 ++++++++++++++++++++++++++-
> arch/arm/mach-omap2/io.c | 2 -
> arch/arm/plat-omap/include/plat/gpmc.h | 4 +++
> arch/arm/plat-omap/include/plat/irqs.h | 9 +++++-
> 27 files changed, 81 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
> index b527f8d..11c89dc 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -145,6 +145,7 @@ static void __init omap_2430sdp_init_irq(void)
> omap_board_config_size = ARRAY_SIZE(sdp2430_config);
> omap2_init_common_hw(NULL, NULL);
> omap_init_irq();
> + gpmc_init();
> omap_gpio_init();
> }
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 4e3742c..a040165 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -328,6 +328,7 @@ static void __init omap_3430sdp_init_irq(void)
> omap3_pm_init_cpuidle(omap3_cpuidle_params_table);
> omap2_init_common_hw(hyb18m512160af6_sdrc_params, NULL);
> omap_init_irq();
> + gpmc_init();
> omap_gpio_init();
> }
...
The gpmc init should be done with subsys_initcall instead.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc
Date: Fri, 17 Dec 2010 16:09:54 -0800 [thread overview]
Message-ID: <20101218000954.GX5941@atomide.com> (raw)
In-Reply-To: <1290785677-16005-4-git-send-email-s-ghorai@ti.com>
* Sukumar Ghorai <s-ghorai@ti.com> [101126 07:25]:
> add support the irq mode in GPMC.
> gpmc_init() function move after omap_init_irq() as it has dependecy on irq.
>
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> ---
> arch/arm/mach-omap2/board-2430sdp.c | 1 +
> arch/arm/mach-omap2/board-3430sdp.c | 1 +
> arch/arm/mach-omap2/board-3630sdp.c | 1 +
> arch/arm/mach-omap2/board-4430sdp.c | 2 +
> arch/arm/mach-omap2/board-am3517evm.c | 2 +
> arch/arm/mach-omap2/board-apollon.c | 1 +
> arch/arm/mach-omap2/board-cm-t35.c | 1 +
> arch/arm/mach-omap2/board-devkit8000.c | 1 +
> arch/arm/mach-omap2/board-generic.c | 2 +
> arch/arm/mach-omap2/board-h4.c | 1 +
> arch/arm/mach-omap2/board-igep0020.c | 1 +
> arch/arm/mach-omap2/board-ldp.c | 1 +
> arch/arm/mach-omap2/board-n8x0.c | 2 +
> arch/arm/mach-omap2/board-omap3beagle.c | 1 +
> arch/arm/mach-omap2/board-omap3evm.c | 2 +
> arch/arm/mach-omap2/board-omap3pandora.c | 2 +
> arch/arm/mach-omap2/board-omap3stalker.c | 1 +
> arch/arm/mach-omap2/board-omap3touchbook.c | 1 +
> arch/arm/mach-omap2/board-omap4panda.c | 2 +
> arch/arm/mach-omap2/board-overo.c | 1 +
> arch/arm/mach-omap2/board-rx51.c | 1 +
> arch/arm/mach-omap2/board-zoom2.c | 2 +
> arch/arm/mach-omap2/board-zoom3.c | 2 +
> arch/arm/mach-omap2/gpmc.c | 39 ++++++++++++++++++++++++++-
> arch/arm/mach-omap2/io.c | 2 -
> arch/arm/plat-omap/include/plat/gpmc.h | 4 +++
> arch/arm/plat-omap/include/plat/irqs.h | 9 +++++-
> 27 files changed, 81 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
> index b527f8d..11c89dc 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -145,6 +145,7 @@ static void __init omap_2430sdp_init_irq(void)
> omap_board_config_size = ARRAY_SIZE(sdp2430_config);
> omap2_init_common_hw(NULL, NULL);
> omap_init_irq();
> + gpmc_init();
> omap_gpio_init();
> }
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 4e3742c..a040165 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -328,6 +328,7 @@ static void __init omap_3430sdp_init_irq(void)
> omap3_pm_init_cpuidle(omap3_cpuidle_params_table);
> omap2_init_common_hw(hyb18m512160af6_sdrc_params, NULL);
> omap_init_irq();
> + gpmc_init();
> omap_gpio_init();
> }
...
The gpmc init should be done with subsys_initcall instead.
Tony
next prev parent reply other threads:[~2010-12-18 0:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 15:34 [PATCH v6 0/7] nand prefetch-irq support and ecc layout chanage Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH 1/7] omap3630: nand: fix device size to work in polled mode Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-12-18 0:03 ` Tony Lindgren
2010-12-18 0:03 ` Tony Lindgren
2010-12-22 9:24 ` Ghorai, Sukumar
2010-12-22 9:24 ` Ghorai, Sukumar
2010-11-26 15:34 ` [PATCH 2/7] omap3: nand: configurable transfer type per board Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-12-18 0:08 ` Tony Lindgren
2010-12-18 0:08 ` Tony Lindgren
2010-12-22 7:52 ` Ghorai, Sukumar
2010-12-22 7:52 ` Ghorai, Sukumar
2010-11-26 15:34 ` [PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-12-18 0:09 ` Tony Lindgren [this message]
2010-12-18 0:09 ` Tony Lindgren
2010-12-22 8:00 ` Ghorai, Sukumar
2010-12-22 8:00 ` Ghorai, Sukumar
2010-11-26 15:34 ` [PATCH v6 4/7] omap3: nand: prefetch in irq mode support Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH v6 5/7] omap3: nand: configurable fifo threshold to gain the throughput Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH v6 6/7] omap: nand: ecc layout select from board file Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` [PATCH v6 7/7] omap: nand: making ecc layout as compatible with romcode ecc Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 15:34 ` Sukumar Ghorai
2010-11-26 17:57 ` [PATCH v6 0/7] nand prefetch-irq support and ecc layout chanage Ghorai, Sukumar
2010-12-02 4:09 ` Charles Manning
2010-12-19 21:45 ` Charles Manning
2010-12-19 21:45 ` Charles Manning
2010-12-19 21:45 ` Charles Manning
2010-12-22 7:43 ` Ghorai, Sukumar
2010-12-22 7:43 ` Ghorai, Sukumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218000954.GX5941@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-ghorai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.