All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Greg KH <greg@kroah.com>,
	akpm@linux-foundation.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Benoit Cousson <b-cousson@ti.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Hari Kanigeri <h-kanigeri2@ti.com>, Suman Anna <s-anna@ti.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 0/4] Introduce hardware spinlock framework
Date: Fri, 17 Dec 2010 16:53:11 -0800	[thread overview]
Message-ID: <20101218005311.GE5941@atomide.com> (raw)
In-Reply-To: <AANLkTi=s_Urcin4SAp1mXrKmoyzR2=6YuS3aU+OYYgqK@mail.gmail.com>

* Ohad Ben-Cohen <ohad@wizery.com> [101216 13:34]:
> On Thu, Dec 16, 2010 at 11:08 PM, Greg KH <greg@kroah.com> wrote:
> >> > I've seen a lot of discussion about this, are all of the review comments
> >> > now addressed?
> >>
> >> Yes, all comments were addressed in this v3 iteration, and this thread
> >> has been idle for about 10 days.
> >
> > That's because we are all busy with other things :(
> 
> Oh sure, my intention was only positive (to demonstrate that there are
> no outstanding comments), sorry if it sounded differently than
> intended.
> 
> > Sorry, I really don't have the time at the moment to review this code,
> > nor does it seem to affect areas that I maintain, so I don't understand
> > what you are looking for from me.
> 
> Sorry for the noise - I contacted you because you maintain the driver
> core, in the hope you could suggest where this can go through.
> 
> Tony, Andrew, can you please have a look ?
> 
> Any comment or suggestion is appreciated.

Looks sane to me from omap point of view and it seems the locks
are now all timeout based:

Acked-by: Tony Lindgren <tony@atomide.com>

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/4] Introduce hardware spinlock framework
Date: Fri, 17 Dec 2010 16:53:11 -0800	[thread overview]
Message-ID: <20101218005311.GE5941@atomide.com> (raw)
In-Reply-To: <AANLkTi=s_Urcin4SAp1mXrKmoyzR2=6YuS3aU+OYYgqK@mail.gmail.com>

* Ohad Ben-Cohen <ohad@wizery.com> [101216 13:34]:
> On Thu, Dec 16, 2010 at 11:08 PM, Greg KH <greg@kroah.com> wrote:
> >> > I've seen a lot of discussion about this, are all of the review comments
> >> > now addressed?
> >>
> >> Yes, all comments were addressed in this v3 iteration, and this thread
> >> has been idle for about 10 days.
> >
> > That's because we are all busy with other things :(
> 
> Oh sure, my intention was only positive (to demonstrate that there are
> no outstanding comments), sorry if it sounded differently than
> intended.
> 
> > Sorry, I really don't have the time at the moment to review this code,
> > nor does it seem to affect areas that I maintain, so I don't understand
> > what you are looking for from me.
> 
> Sorry for the noise - I contacted you because you maintain the driver
> core, in the hope you could suggest where this can go through.
> 
> Tony, Andrew, can you please have a look ?
> 
> Any comment or suggestion is appreciated.

Looks sane to me from omap point of view and it seems the locks
are now all timeout based:

Acked-by: Tony Lindgren <tony@atomide.com>

Regards,

Tony

  reply	other threads:[~2010-12-18  0:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 23:50 [PATCH v3 0/4] Introduce hardware spinlock framework Ohad Ben-Cohen
2010-12-03 23:50 ` Ohad Ben-Cohen
2010-12-03 23:50 ` Ohad Ben-Cohen
2010-12-03 23:50 ` [PATCH v3 1/4] drivers: hwspinlock: add framework Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-03 23:50 ` [PATCH v3 2/4] drivers: hwspinlock: add OMAP implementation Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-03 23:50 ` [PATCH v3 3/4] OMAP4: hwmod data: Add hwspinlock Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-03 23:50 ` [PATCH v3 4/4] omap: add hwspinlock device Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-03 23:50   ` Ohad Ben-Cohen
2010-12-04  0:29 ` [PATCH v3 0/4] Introduce hardware spinlock framework David Daney
2010-12-04  1:28   ` Ohad Ben-Cohen
2010-12-04  1:28     ` Ohad Ben-Cohen
2010-12-04  1:28     ` Ohad Ben-Cohen
2010-12-14 14:31 ` Ohad Ben-Cohen
2010-12-14 14:31   ` Ohad Ben-Cohen
2010-12-14 17:06   ` Greg KH
2010-12-14 17:06     ` Greg KH
2010-12-14 18:40     ` Ohad Ben-Cohen
2010-12-14 18:40       ` Ohad Ben-Cohen
2010-12-16 20:42       ` Ohad Ben-Cohen
2010-12-16 20:42         ` Ohad Ben-Cohen
2010-12-16 20:42         ` Ohad Ben-Cohen
2010-12-16 21:08       ` Greg KH
2010-12-16 21:08         ` Greg KH
2010-12-16 21:34         ` Ohad Ben-Cohen
2010-12-16 21:34           ` Ohad Ben-Cohen
2010-12-18  0:53           ` Tony Lindgren [this message]
2010-12-18  0:53             ` Tony Lindgren
2011-01-04 12:23             ` Ohad Ben-Cohen
2011-01-04 12:23               ` Ohad Ben-Cohen
2011-01-04 20:19               ` Andrew Morton
2011-01-04 20:19                 ` Andrew Morton
2011-01-04 20:42                 ` Ohad Ben-Cohen
2011-01-04 20:42                   ` Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101218005311.GE5941@atomide.com \
    --to=tony@atomide.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=b-cousson@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=greg@kroah.com \
    --cc=h-kanigeri2@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.