Patch for drivers/platform/x86/compal-laptop.c

Patch for drivers/platform/x86/compal-laptop.c

[Albert Astals Cid]

[-- Attachment #1: Type: Text/Plain, Size: 443 bytes --]

*****
  Please CC me on answers i'm not subscribed to the list.
*****

Hi, this patch adds support for my compal laptop model.

I've checked the values the driver uses against 
http://ftp.compal.com/Download/NB/KHLBX/Service Manual/KHLB2_SM_PDF.pdf and 
they match and i've been using the driver for a while and it helps me with my 
fan speed problem (as i can change the fan to be controled by the OS instead 
of by the motherboard).

Albert

[-- Attachment #2: khlb2.patch --]
[-- Type: text/x-patch, Size: 518 bytes --]

diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c
index 097083c..034572b 100644
--- a/drivers/platform/x86/compal-laptop.c
+++ b/drivers/platform/x86/compal-laptop.c
@@ -872,6 +872,14 @@ static struct dmi_system_id __initdata compal_dmi_table[] = {
 		},
 		.callback = dmi_check_cb_extra
 	},
+	{
+		.ident = "KHLB2",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "KHLB2"),
+			DMI_MATCH(DMI_BOARD_VERSION, "REFERENCE"),
+		},
+		.callback = dmi_check_cb_extra
+	},
 	{ }
 };
 

Re: Patch for drivers/platform/x86/compal-laptop.c

[Matthew Garrett]

Patch looks fine, but could you submit it following the instructions in 
Documentation/SubmittingPatches? I'll need a signed-off-by: line at 
least.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Patch for drivers/platform/x86/compal-laptop.c

[Albert Astals Cid]

A Dilluns, 20 de desembre de 2010, Matthew Garrett va escriure:
> Patch looks fine, but could you submit it following the instructions in
> Documentation/SubmittingPatches? I'll need a signed-off-by: line at
> least.

To be fair i don't know which subsystem this belongs to.

I guess my summary phrase would be:
Support KHLB2 in the compal laptop driver

The explanation would be:
Add the KHLB2 model identifier to the list of supported models

Signed-off-by: Albert Astals Cid <aacid@kde.org>

And you already have the patch.

Not sure if this is really good enough. If it is not do not hesitat to tell me 
again.

Thanks,
  Albert

Re: Patch for drivers/platform/x86/compal-laptop.c

[Matthew Garrett]

On Mon, Dec 20, 2010 at 10:49:35PM +0000, Albert Astals Cid wrote:
> A Dilluns, 20 de desembre de 2010, Matthew Garrett va escriure:
> > Patch looks fine, but could you submit it following the instructions in
> > Documentation/SubmittingPatches? I'll need a signed-off-by: line at
> > least.
> 
> To be fair i don't know which subsystem this belongs to.

It's the x86 platform drivers. There's not really a terribly good way to 
express that in a subject line :) 

> I guess my summary phrase would be:
> Support KHLB2 in the compal laptop driver
> 
> The explanation would be:
> Add the KHLB2 model identifier to the list of supported models
> 
> Signed-off-by: Albert Astals Cid <aacid@kde.org>

That ought to be ok. In future it's easier if you include the patch as 
part of the mail - git send-email is really the most straightforward way 
to generate correct patches.

Thanks,
-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Patch for drivers/platform/x86/compal-laptop.c

[Matthew Garrett]

Applied, thanks.

-- 
Matthew Garrett | mjg59@srcf.ucam.org