From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Haicheng Li <haicheng.li@linux.intel.com>,
lethal@linux-sh.org, Andi Kleen <ak@linux.intel.com>,
Shaohui Zheng <shaohui.zheng@linux.intel.com>,
dave@linux.vnet.ibm.com, Greg KH <gregkh@suse.de>
Subject: Re: [3/7, v9] NUMA Hotplug Emulator: Add node hotplug emulation
Date: Wed, 22 Dec 2010 18:20:22 -0800 [thread overview]
Message-ID: <20101222182022.a5d5da8d.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1012221736110.13932@chino.kir.corp.google.com>
On Wed, 22 Dec 2010 17:38:44 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> On Wed, 22 Dec 2010, Andrew Morton wrote:
>
> > > Index: linux-hpe4/mm/memory_hotplug.c
> > > ===================================================================
> > > --- linux-hpe4.orig/mm/memory_hotplug.c 2010-11-30 12:40:43.757622001 +0800
> > > +++ linux-hpe4/mm/memory_hotplug.c 2010-11-30 14:02:33.877622002 +0800
> > > @@ -924,3 +924,63 @@
> > > }
> > > #endif /* CONFIG_MEMORY_HOTREMOVE */
> > > EXPORT_SYMBOL_GPL(remove_memory);
> > > +
> > > +#ifdef CONFIG_DEBUG_FS
> > > +#include <linux/debugfs.h>
> > > +
> > > +static struct dentry *memhp_debug_root;
> > > +
> > > +static ssize_t add_node_store(struct file *file, const char __user *buf,
> > > + size_t count, loff_t *ppos)
> > > +{
> > > + nodemask_t mask;
> >
> > NODEMASK_ALLOC()?
> >
>
> We traditionally haven't been using NODEMASK_ALLOC() in sysfs (or, in this
> case, debugfs) functions because they're never deep in a call chain. Even
> for 4K node support, which isn't a supported config on any arch that
> allows CONFIG_MEMORY_HOTPLUG, this would only be 512 bytes on the short
> stack.
I bet linux-2.6.227 supports a meganode.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Haicheng Li <haicheng.li@linux.intel.com>,
lethal@linux-sh.org, Andi Kleen <ak@linux.intel.com>,
Shaohui Zheng <shaohui.zheng@linux.intel.com>,
dave@linux.vnet.ibm.com, Greg KH <gregkh@suse.de>
Subject: Re: [3/7, v9] NUMA Hotplug Emulator: Add node hotplug emulation
Date: Wed, 22 Dec 2010 18:20:22 -0800 [thread overview]
Message-ID: <20101222182022.a5d5da8d.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1012221736110.13932@chino.kir.corp.google.com>
On Wed, 22 Dec 2010 17:38:44 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> On Wed, 22 Dec 2010, Andrew Morton wrote:
>
> > > Index: linux-hpe4/mm/memory_hotplug.c
> > > ===================================================================
> > > --- linux-hpe4.orig/mm/memory_hotplug.c 2010-11-30 12:40:43.757622001 +0800
> > > +++ linux-hpe4/mm/memory_hotplug.c 2010-11-30 14:02:33.877622002 +0800
> > > @@ -924,3 +924,63 @@
> > > }
> > > #endif /* CONFIG_MEMORY_HOTREMOVE */
> > > EXPORT_SYMBOL_GPL(remove_memory);
> > > +
> > > +#ifdef CONFIG_DEBUG_FS
> > > +#include <linux/debugfs.h>
> > > +
> > > +static struct dentry *memhp_debug_root;
> > > +
> > > +static ssize_t add_node_store(struct file *file, const char __user *buf,
> > > + size_t count, loff_t *ppos)
> > > +{
> > > + nodemask_t mask;
> >
> > NODEMASK_ALLOC()?
> >
>
> We traditionally haven't been using NODEMASK_ALLOC() in sysfs (or, in this
> case, debugfs) functions because they're never deep in a call chain. Even
> for 4K node support, which isn't a supported config on any arch that
> allows CONFIG_MEMORY_HOTPLUG, this would only be 512 bytes on the short
> stack.
I bet linux-2.6.227 supports a meganode.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-23 2:26 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 7:31 [0/7, v9] NUMA Hotplug Emulator (v9) shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-10 7:31 ` [1/7, v9] NUMA Hotplug Emulator: Documentation shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-10 7:31 ` [2/7, v9] NUMA Hotplug Emulator: Add numa=possible option shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 0:27 ` Andrew Morton
2010-12-23 1:14 ` David Rientjes
2010-12-23 1:14 ` David Rientjes
2010-12-10 7:31 ` [3/7, v9] NUMA Hotplug Emulator: Add node hotplug emulation shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 0:27 ` Andrew Morton
2010-12-23 1:38 ` David Rientjes
2010-12-23 1:38 ` David Rientjes
2010-12-23 2:20 ` Andrew Morton [this message]
2010-12-23 2:20 ` Andrew Morton
2010-12-28 7:34 ` David Rientjes
2010-12-28 7:34 ` David Rientjes
2010-12-28 7:34 ` [patch] mm: add " David Rientjes
2010-12-28 7:34 ` David Rientjes
2010-12-29 2:31 ` [3/7, v9] NUMA Hotplug Emulator: Add " Zheng, Shaohui
2010-12-29 2:31 ` Zheng, Shaohui
2010-12-10 7:31 ` [4/7, v9] NUMA Hotplug Emulator: Abstract cpu register functions shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-10 7:31 ` [5/7, v9] NUMA Hotplug Emulator: Support cpu probe/release in x86_64 shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-16 16:25 ` Eric B Munson
2010-12-16 23:34 ` Shaohui Zheng
2010-12-16 23:34 ` Shaohui Zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 0:27 ` Andrew Morton
2010-12-23 1:34 ` Shaohui Zheng
2010-12-23 1:34 ` Shaohui Zheng
2010-12-23 3:21 ` Andrew Morton
2010-12-23 3:21 ` Andrew Morton
2010-12-23 2:24 ` Shaohui Zheng
2010-12-23 2:24 ` Shaohui Zheng
2010-12-23 5:28 ` Andrew Morton
2010-12-23 5:28 ` Andrew Morton
2010-12-23 4:30 ` Shaohui Zheng
2010-12-23 4:30 ` Shaohui Zheng
2010-12-10 7:31 ` [6/7, v9] NUMA Hotplug Emulator: Fake CPU socket with logical CPU on x86 shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 0:27 ` Andrew Morton
2010-12-23 5:10 ` Shaohui Zheng
2010-12-23 5:10 ` Shaohui Zheng
2010-12-10 7:31 ` [7/7, v9] NUMA Hotplug Emulator: Implement per-node add_memory debugfs interface shaohui.zheng
2010-12-10 7:31 ` shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 0:27 ` Andrew Morton
2010-12-23 2:00 ` Shaohui Zheng
2010-12-23 2:00 ` Shaohui Zheng
2011-02-22 22:31 ` [0/7, v9] NUMA Hotplug Emulator (v9) David Rientjes
2011-02-22 22:31 ` David Rientjes
2011-02-23 3:29 ` Haicheng Li
2011-02-23 3:29 ` Haicheng Li
2011-02-23 5:29 ` Zhang, Yang Z
2011-02-23 5:29 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222182022.a5d5da8d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=dave@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=haicheng.li@linux.intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=shaohui.zheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.