From: Matthew Garrett <mjg@redhat.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>,
Youquan Song <youquan.song@intel.com>,
davej@redhat.com, cpufreq@vger.kernel.org, venki@google.com,
arjan@linux.intel.com, lenb@kernel.
Subject: Re: [PATCH 6/6] cpufreq: Evaluate P1 before enter turbo mode
Date: Thu, 23 Dec 2010 14:38:59 +0000 [thread overview]
Message-ID: <20101223143859.GA1402@srcf.ucam.org> (raw)
In-Reply-To: <20101223105730.GB18363@comet.dominikbrodowski.net>
On Thu, Dec 23, 2010 at 11:57:30AM +0100, Dominik Brodowski wrote:
> NACK. First of all, why is it only a "turbo mode" if it's 1000 kHz
> difference?
I believe that that's how it's supposed to be defined for Intel systems,
but you're right that this doesn't belong in generic code. AMD have
support for enabling/disabling their equivalent functionality through
sysfs - I'd say that copying that interface and using it to limit the
set of p-states provided to the core makes more sense.
--
Matthew Garrett | mjg59@srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg@redhat.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>,
Youquan Song <youquan.song@intel.com>,
davej@redhat.com, cpufreq@vger.kernel.org, venki@google.com,
arjan@linux.intel.com, lenb@kernel.org,
suresh.b.siddha@intel.com, kent.liu@intel.com,
chaohong.guo@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH 6/6] cpufreq: Evaluate P1 before enter turbo mode
Date: Thu, 23 Dec 2010 14:38:59 +0000 [thread overview]
Message-ID: <20101223143859.GA1402@srcf.ucam.org> (raw)
In-Reply-To: <20101223105730.GB18363@comet.dominikbrodowski.net>
On Thu, Dec 23, 2010 at 11:57:30AM +0100, Dominik Brodowski wrote:
> NACK. First of all, why is it only a "turbo mode" if it's 1000 kHz
> difference?
I believe that that's how it's supposed to be defined for Intel systems,
but you're right that this doesn't belong in generic code. AMD have
support for enabling/disabling their equivalent functionality through
sysfs - I'd say that copying that interface and using it to limit the
set of p-states provided to the core makes more sense.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-23 14:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 6:23 [PATCH 0/6] cpufreq: Add sampling window to enhance ondemand governor power efficiency Youquan Song
2010-12-23 6:23 ` [PATCH 1/6] cpufreq: Add sampling window for ondemand governor Youquan Song
2010-12-23 6:23 ` [PATCH 2/6] cpufreq: Add sampling_window tunable Youquan Song
2010-12-23 6:23 ` [PATCH 3/6] cpufreq: Add roll back non-sampling_window Youquan Song
2010-12-23 6:23 ` [PATCH 4/6] cpufreq: Add dynamic sampling window tunable Youquan Song
2010-12-23 6:23 ` [PATCH 5/6] cpufreq: Add down_differential tunable Youquan Song
2010-12-23 6:23 ` [PATCH 6/6] cpufreq: Evaluate P1 before enter turbo mode Youquan Song
2010-12-23 10:57 ` Dominik Brodowski
2010-12-23 14:38 ` Matthew Garrett [this message]
2010-12-23 14:38 ` Matthew Garrett
2010-12-23 18:13 ` Venkatesh Pallipadi
2010-12-23 20:48 ` Dominik Brodowski
2010-12-23 6:50 ` [PATCH 0/6] cpufreq: Add sampling window to enhance ondemand governor power efficiency Niemi, David
2010-12-23 23:26 ` Youquan Song
2010-12-23 11:00 ` Dominik Brodowski
2010-12-23 17:34 ` Dave Jones
2010-12-23 17:34 ` Dave Jones
2010-12-23 17:34 ` Dave Jones
2010-12-23 20:51 ` Dominik Brodowski
2010-12-23 20:51 ` Dominik Brodowski
2010-12-25 4:24 ` James Cloos
2010-12-23 20:51 ` Dominik Brodowski
2010-12-24 3:06 ` Youquan Song
2010-12-24 3:06 ` Youquan Song
2010-12-24 3:06 ` Youquan Song
2010-12-23 14:42 ` Matthew Garrett
2010-12-24 4:28 ` Youquan Song
-- strict thread matches above, loose matches on Subject: below --
2010-12-23 6:17 Youquan Song
2010-12-23 6:17 ` [PATCH 1/6] cpufreq: Add sampling window for ondemand governor Youquan Song
2010-12-23 6:17 ` [PATCH 2/6] cpufreq: Add sampling_window tunable Youquan Song
2010-12-23 6:17 ` [PATCH 3/6] cpufreq: Add roll back non-sampling_window Youquan Song
2010-12-23 6:17 ` [PATCH 4/6] cpufreq: Add dynamic sampling window tunable Youquan Song
2010-12-23 6:17 ` [PATCH 5/6] cpufreq: Add down_differential tunable Youquan Song
2010-12-23 6:17 ` [PATCH 6/6] cpufreq: Evaluate P1 before enter turbo mode Youquan Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223143859.GA1402@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=arjan@linux.intel.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=lenb@kernel. \
--cc=linux@dominikbrodowski.net \
--cc=venki@google.com \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.