* [PATCH 1/2] arm/pxa: fix build of it8152
@ 2010-12-29 20:33 Sebastian Andrzej Siewior
2010-12-29 20:33 ` [PATCH 2/2] arm/pxa: buildfix for pam27x without fb Sebastian Andrzej Siewior
2010-12-30 7:56 ` [PATCH 1/2] arm/pxa: fix build of it8152 Mike Rapoport
0 siblings, 2 replies; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2010-12-29 20:33 UTC (permalink / raw)
To: linux-arm-kernel
Probably since 6ac6b817 aka ("ARM: pxa: encode IRQ number into
.nr_irqs") the build fails with:
| CC arch/arm/common/it8152.o
| arch/arm/common/it8152.c: In function ?it8152_init_irq?:
| arch/arm/common/it8152.c:86: error: ?IT8152_LAST_IRQ? undeclared (first use in this function)
| arch/arm/common/it8152.c:86: error: (Each undeclared identifier is reported only once
| arch/arm/common/it8152.c:86: error: for each function it appears in.)
Before that commit IT8152_LAST_IRQ was (IRQ_BOARD_END + 40) with the
first IRQ beeing IRQ_BOARD_START. This change als adds +40 so I hope
this works (I have no HW to verify).
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
arch/arm/include/asm/hardware/it8152.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/hardware/it8152.h b/arch/arm/include/asm/hardware/it8152.h
index 21fa272..e3931a9 100644
--- a/arch/arm/include/asm/hardware/it8152.h
+++ b/arch/arm/include/asm/hardware/it8152.h
@@ -81,6 +81,8 @@ extern unsigned long it8152_base_address;
#define IT8152_LD_IRQ_COUNT 9
#define IT8152_LP_IRQ_COUNT 16
#define IT8152_PD_IRQ_COUNT 15
+#define IT8152_LAST_IRQ (IT8152_IRQ(0) + IT8152_LD_IRQ_COUNT + \
+ IT8152_LP_IRQ_COUNT + IT8152_PD_IRQ_COUNT)
/* Priorities: */
#define IT8152_PD_IRQ(i) IT8152_IRQ(i)
--
1.7.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] arm/pxa: buildfix for pam27x without fb
2010-12-29 20:33 [PATCH 1/2] arm/pxa: fix build of it8152 Sebastian Andrzej Siewior
@ 2010-12-29 20:33 ` Sebastian Andrzej Siewior
2011-01-03 15:57 ` Eric Miao
2010-12-30 7:56 ` [PATCH 1/2] arm/pxa: fix build of it8152 Mike Rapoport
1 sibling, 1 reply; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2010-12-29 20:33 UTC (permalink / raw)
To: linux-arm-kernel
|arch/arm/mach-pxa/palmld.c: In function ?palmld_init?:
|arch/arm/mach-pxa/palmld.c:330: error: ?palm_320x480_lcd_mode? undeclared (first use in this function)
|arch/arm/mach-pxa/palmld.c:330: error: (Each undeclared identifier is reported only once
|arch/arm/mach-pxa/palmld.c:330: error: for each function it appears in.)
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
arch/arm/mach-pxa/include/mach/palm27x.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h b/arch/arm/mach-pxa/include/mach/palm27x.h
index 0a5e5ea..7b7927c 100644
--- a/arch/arm/mach-pxa/include/mach/palm27x.h
+++ b/arch/arm/mach-pxa/include/mach/palm27x.h
@@ -34,7 +34,7 @@ extern struct pxafb_mode_info palm_320x320_new_lcd_mode;
extern void __init palm27x_lcd_init(int power,
struct pxafb_mode_info *mode);
#else
-static inline void palm27x_lcd_init(int power, struct pxafb_mode_info *mode) {}
+#define palm27x_lcd_init(power, mode) do { } while (0)
#endif
#if defined(CONFIG_USB_GADGET_PXA27X) || \
--
1.7.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] arm/pxa: buildfix for pam27x without fb
2010-12-29 20:33 ` [PATCH 2/2] arm/pxa: buildfix for pam27x without fb Sebastian Andrzej Siewior
@ 2011-01-03 15:57 ` Eric Miao
2011-01-03 22:07 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Eric Miao @ 2011-01-03 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 30, 2010 at 4:33 AM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> |arch/arm/mach-pxa/palmld.c: In function ?palmld_init?:
> |arch/arm/mach-pxa/palmld.c:330: error: ?palm_320x480_lcd_mode? undeclared (first use in this function)
> |arch/arm/mach-pxa/palmld.c:330: error: (Each undeclared identifier is reported only once
> |arch/arm/mach-pxa/palmld.c:330: error: for each function it appears in.)
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Marek,
I need your ack please.
> ---
> ?arch/arm/mach-pxa/include/mach/palm27x.h | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h b/arch/arm/mach-pxa/include/mach/palm27x.h
> index 0a5e5ea..7b7927c 100644
> --- a/arch/arm/mach-pxa/include/mach/palm27x.h
> +++ b/arch/arm/mach-pxa/include/mach/palm27x.h
> @@ -34,7 +34,7 @@ extern struct pxafb_mode_info palm_320x320_new_lcd_mode;
> ?extern void __init palm27x_lcd_init(int power,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct pxafb_mode_info *mode);
> ?#else
> -static inline void palm27x_lcd_init(int power, struct pxafb_mode_info *mode) {}
> +#define palm27x_lcd_init(power, mode) ?do { } while (0)
> ?#endif
>
> ?#if ? ?defined(CONFIG_USB_GADGET_PXA27X) || \
> --
> 1.7.3.2
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/2] arm/pxa: buildfix for pam27x without fb
2011-01-03 15:57 ` Eric Miao
@ 2011-01-03 22:07 ` Marek Vasut
2011-01-04 4:00 ` Eric Miao
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2011-01-03 22:07 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 03 January 2011 16:57:27 Eric Miao wrote:
> On Thu, Dec 30, 2010 at 4:33 AM, Sebastian Andrzej Siewior
>
> <bigeasy@linutronix.de> wrote:
> > |arch/arm/mach-pxa/palmld.c: In function ?palmld_init?:
> > |arch/arm/mach-pxa/palmld.c:330: error: ?palm_320x480_lcd_mode?
> > |undeclared (first use in this function) arch/arm/mach-pxa/palmld.c:330:
> > |error: (Each undeclared identifier is reported only once
> > |arch/arm/mach-pxa/palmld.c:330: error: for each function it appears
> > |in.)
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Marek,
>
> I need your ack please.
I don't like it being done with preprocessor macro. Maybe we should rather pull
palm_320x320_new_lcd_mode and others outside the #if defined() ?
>
> > ---
> > arch/arm/mach-pxa/include/mach/palm27x.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h
> > b/arch/arm/mach-pxa/include/mach/palm27x.h index 0a5e5ea..7b7927c 100644
> > --- a/arch/arm/mach-pxa/include/mach/palm27x.h
> > +++ b/arch/arm/mach-pxa/include/mach/palm27x.h
> > @@ -34,7 +34,7 @@ extern struct pxafb_mode_info
> > palm_320x320_new_lcd_mode; extern void __init palm27x_lcd_init(int
> > power,
> > struct pxafb_mode_info *mode);
> > #else
> > -static inline void palm27x_lcd_init(int power, struct pxafb_mode_info
> > *mode) {} +#define palm27x_lcd_init(power, mode) do { } while (0)
> > #endif
> >
> > #if defined(CONFIG_USB_GADGET_PXA27X) || \
> > --
> > 1.7.3.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/2] arm/pxa: buildfix for pam27x without fb
2011-01-03 22:07 ` Marek Vasut
@ 2011-01-04 4:00 ` Eric Miao
0 siblings, 0 replies; 6+ messages in thread
From: Eric Miao @ 2011-01-04 4:00 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 4, 2011 at 6:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Monday 03 January 2011 16:57:27 Eric Miao wrote:
>> On Thu, Dec 30, 2010 at 4:33 AM, Sebastian Andrzej Siewior
>>
>> <bigeasy@linutronix.de> wrote:
>> > |arch/arm/mach-pxa/palmld.c: In function ?palmld_init?:
>> > |arch/arm/mach-pxa/palmld.c:330: error: ?palm_320x480_lcd_mode?
>> > |undeclared (first use in this function) arch/arm/mach-pxa/palmld.c:330:
>> > |error: (Each undeclared identifier is reported only once
>> > |arch/arm/mach-pxa/palmld.c:330: error: for each function it appears
>> > |in.)
>> >
>> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>
>> Marek,
>>
>> I need your ack please.
>
> I don't like it being done with preprocessor macro. Maybe we should rather pull
> palm_320x320_new_lcd_mode and others outside the #if defined() ?
>
Yeah, that will be at least a bit more consistent.
>>
>> > ---
>> > ?arch/arm/mach-pxa/include/mach/palm27x.h | ? ?2 +-
>> > ?1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h
>> > b/arch/arm/mach-pxa/include/mach/palm27x.h index 0a5e5ea..7b7927c 100644
>> > --- a/arch/arm/mach-pxa/include/mach/palm27x.h
>> > +++ b/arch/arm/mach-pxa/include/mach/palm27x.h
>> > @@ -34,7 +34,7 @@ extern struct pxafb_mode_info
>> > palm_320x320_new_lcd_mode; extern void __init palm27x_lcd_init(int
>> > power,
>> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct pxafb_mode_info *mode);
>> > ?#else
>> > -static inline void palm27x_lcd_init(int power, struct pxafb_mode_info
>> > *mode) {} +#define palm27x_lcd_init(power, mode) ?do { } while (0)
>> > ?#endif
>> >
>> > ?#if ? ?defined(CONFIG_USB_GADGET_PXA27X) || \
>> > --
>> > 1.7.3.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm/pxa: fix build of it8152
2010-12-29 20:33 [PATCH 1/2] arm/pxa: fix build of it8152 Sebastian Andrzej Siewior
2010-12-29 20:33 ` [PATCH 2/2] arm/pxa: buildfix for pam27x without fb Sebastian Andrzej Siewior
@ 2010-12-30 7:56 ` Mike Rapoport
1 sibling, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2010-12-30 7:56 UTC (permalink / raw)
To: linux-arm-kernel
On 12/29/10 22:33, Sebastian Andrzej Siewior wrote:
> Probably since 6ac6b817 aka ("ARM: pxa: encode IRQ number into
> .nr_irqs") the build fails with:
> | CC arch/arm/common/it8152.o
> | arch/arm/common/it8152.c: In function ?it8152_init_irq?:
> | arch/arm/common/it8152.c:86: error: ?IT8152_LAST_IRQ? undeclared (first use in this function)
> | arch/arm/common/it8152.c:86: error: (Each undeclared identifier is reported only once
> | arch/arm/common/it8152.c:86: error: for each function it appears in.)
>
> Before that commit IT8152_LAST_IRQ was (IRQ_BOARD_END + 40) with the
> first IRQ beeing IRQ_BOARD_START. This change als adds +40 so I hope
> this works (I have no HW to verify).
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
I've already sent a patch for this (1), hopefully Eric or Russell will pick it up.
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December/036570.html
> ---
> arch/arm/include/asm/hardware/it8152.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/hardware/it8152.h b/arch/arm/include/asm/hardware/it8152.h
> index 21fa272..e3931a9 100644
> --- a/arch/arm/include/asm/hardware/it8152.h
> +++ b/arch/arm/include/asm/hardware/it8152.h
> @@ -81,6 +81,8 @@ extern unsigned long it8152_base_address;
> #define IT8152_LD_IRQ_COUNT 9
> #define IT8152_LP_IRQ_COUNT 16
> #define IT8152_PD_IRQ_COUNT 15
> +#define IT8152_LAST_IRQ (IT8152_IRQ(0) + IT8152_LD_IRQ_COUNT + \
> + IT8152_LP_IRQ_COUNT + IT8152_PD_IRQ_COUNT)
>
> /* Priorities: */
> #define IT8152_PD_IRQ(i) IT8152_IRQ(i)
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-04 4:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-29 20:33 [PATCH 1/2] arm/pxa: fix build of it8152 Sebastian Andrzej Siewior
2010-12-29 20:33 ` [PATCH 2/2] arm/pxa: buildfix for pam27x without fb Sebastian Andrzej Siewior
2011-01-03 15:57 ` Eric Miao
2011-01-03 22:07 ` Marek Vasut
2011-01-04 4:00 ` Eric Miao
2010-12-30 7:56 ` [PATCH 1/2] arm/pxa: fix build of it8152 Mike Rapoport
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.