From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Keerthy <j-keerthy@ti.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"mikko.k.ylinen@nokia.com" <mikko.k.ylinen@nokia.com>,
"amit.kucheria@canonical.com" <amit.kucheria@canonical.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"balajitk@ti.com" <balajitk@ti.com>
Subject: Re: [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module
Date: Wed, 5 Jan 2011 21:33:28 -0800 [thread overview]
Message-ID: <20110106053328.GA7489@ericsson.com> (raw)
In-Reply-To: <1294287457-2438-1-git-send-email-j-keerthy@ti.com>
On Wed, Jan 05, 2011 at 11:17:37PM -0500, Keerthy wrote:
> Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring
> ADC. This driver monitors the real time conversion of analog signals like
> battery temperature, battery type, battery level etc. User can also ask for
> the conversion on a particular channel using the sysfs nodes. Tested the
> conversion through sysfs nodes. Tested with DEBUG_LOCKDEP enabled.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>
NACK for:
[...]
> +EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
[...]
> +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion);
No symbol export from hwmon drivers. Other parts of the kernel
should not depend on HWMON configuration.
I would suggest to check if drivers/staging/iio would be a better fit.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Keerthy <j-keerthy@ti.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"mikko.k.ylinen@nokia.com" <mikko.k.ylinen@nokia.com>,
"amit.kucheria@canonical.com" <amit.kucheria@canonical.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"balajitk@ti.com" <balajitk@ti.com>
Subject: Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc
Date: Thu, 06 Jan 2011 05:33:28 +0000 [thread overview]
Message-ID: <20110106053328.GA7489@ericsson.com> (raw)
In-Reply-To: <1294287457-2438-1-git-send-email-j-keerthy@ti.com>
On Wed, Jan 05, 2011 at 11:17:37PM -0500, Keerthy wrote:
> Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring
> ADC. This driver monitors the real time conversion of analog signals like
> battery temperature, battery type, battery level etc. User can also ask for
> the conversion on a particular channel using the sysfs nodes. Tested the
> conversion through sysfs nodes. Tested with DEBUG_LOCKDEP enabled.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>
NACK for:
[...]
> +EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
[...]
> +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion);
No symbol export from hwmon drivers. Other parts of the kernel
should not depend on HWMON configuration.
I would suggest to check if drivers/staging/iio would be a better fit.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-01-06 5:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 4:17 [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Keerthy
2011-01-06 4:29 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Keerthy
2011-01-06 5:33 ` Guenter Roeck [this message]
2011-01-06 5:33 ` Guenter Roeck
2011-01-06 12:07 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Mark Brown
2011-01-06 12:07 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Mark Brown
2011-01-06 15:04 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Guenter Roeck
2011-01-06 15:04 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Guenter Roeck
2011-01-06 20:21 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Mark Brown
2011-01-06 20:21 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Mark Brown
2011-01-06 21:55 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Guenter Roeck
2011-01-06 21:55 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Guenter Roeck
2011-01-07 12:12 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module J, KEERTHY
2011-01-07 12:24 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc J, KEERTHY
2011-01-07 14:45 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Guenter Roeck
2011-01-07 14:45 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Guenter Roeck
2011-01-22 16:49 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module J, KEERTHY
2011-01-22 16:52 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc J, KEERTHY
2011-01-31 10:43 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Samuel Ortiz
2011-01-31 10:43 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Samuel Ortiz
2011-01-06 5:58 ` [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Kalliguddi, Hema
2011-01-06 6:10 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Kalliguddi, Hema
2011-01-07 8:40 ` [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module J, KEERTHY
2011-01-07 8:52 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc J, KEERTHY
-- strict thread matches above, loose matches on Subject: below --
2011-01-06 3:56 [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Keerthy
2011-01-06 3:59 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Keerthy
2011-01-06 4:04 ` [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module J, KEERTHY
2011-01-06 4:16 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc J, KEERTHY
2011-01-06 12:04 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Mark Brown
2011-01-06 12:04 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Mark Brown
2011-01-07 9:25 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module J, KEERTHY
2011-01-07 9:37 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc J, KEERTHY
2011-01-07 10:44 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Mark Brown
2011-01-07 10:44 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc Mark Brown
2011-01-07 11:20 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module J, KEERTHY
2011-01-07 11:32 ` [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106053328.GA7489@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=amit.kucheria@canonical.com \
--cc=balajitk@ti.com \
--cc=j-keerthy@ti.com \
--cc=khali@linux-fr.org \
--cc=linux-omap@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mikko.k.ylinen@nokia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.