Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Keerthy <j-keerthy@ti.com>,
	"amit.kucheria@canonical.com" <amit.kucheria@canonical.com>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	"mikko.k.ylinen@nokia.com" <mikko.k.ylinen@nokia.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"balajitk@ti.com" <balajitk@ti.com>
Subject: Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module
Date: Thu, 6 Jan 2011 07:04:30 -0800	[thread overview]
Message-ID: <20110106150430.GA9053@ericsson.com> (raw)
In-Reply-To: <20110106120713.GD17184@sirena.org.uk>

On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote:
> On Wed, Jan 05, 2011 at 09:33:28PM -0800, Guenter Roeck wrote:
> 
> > [...]
> > > +EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
> > [...]
> > > +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion);
> 
> > No symbol export from hwmon drivers. Other parts of the kernel
> > should not depend on HWMON configuration.
> 
> Why?  It's not like hwmon has an unreasonably large core or similar.
> 
Because it creates an unnecessary dependency, and because it is not hwmon's 
responsibility to provide infrastructure for other subsystems or drivers.

> > I would suggest to check if drivers/staging/iio would be a better fit.
> 
> That does have the problem that it's in staging and constantly churning,
> though.  When I've looked at it it seemed like awfully hard work to use
> for devices like this.
> 
> What I've done in some of my drivers is put the ADC core in the MFD core
> (it's used by both hwmon and power supply function drivers, plus any
> board specific stuff people do).

Fine as well. I think I had suggested that earlier already.

Guenter