From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 2/3] ath9k: Re-start xmit logic in xmit watchdog timer.
Date: Fri, 7 Jan 2011 20:50:26 +0530 [thread overview]
Message-ID: <20110107152026.GA5656@vasanth-laptop> (raw)
In-Reply-To: <20110107151148.7315.qmail@stuge.se>
On Fri, Jan 07, 2011 at 08:41:48PM +0530, Peter Stuge wrote:
> Vasanthakumar Thiagarajan wrote:
> > > +++ b/drivers/net/wireless/ath/ath9k/xmit.c
> > > @@ -2110,6 +2110,27 @@ static void ath_tx_complete_poll_work(struct work_struct *work)
> > > } else {
> > > txq->axq_tx_inprogress = true;
> > > }
> > > + } else {
> ..
> > > + if (!list_empty(&txq->axq_acq)) {
> ..
> > > + ath_txq_schedule(sc, txq);
> >
> > NAK. This complete work monitors the hw q periodically and does a
> > reset if a hang is detected.
>
> Could you please point to that hang check?
It not exactly a hang check. It is monitoring tx intr when hw q is
non-empty.
Vasanth
WARNING: multiple messages have this Message-ID (diff)
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Peter Stuge <peter@stuge.se>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"greearb@candelatech.com" <greearb@candelatech.com>,
"ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [PATCH 2/3] ath9k: Re-start xmit logic in xmit watchdog timer.
Date: Fri, 7 Jan 2011 20:50:26 +0530 [thread overview]
Message-ID: <20110107152026.GA5656@vasanth-laptop> (raw)
In-Reply-To: <20110107151148.7315.qmail@stuge.se>
On Fri, Jan 07, 2011 at 08:41:48PM +0530, Peter Stuge wrote:
> Vasanthakumar Thiagarajan wrote:
> > > +++ b/drivers/net/wireless/ath/ath9k/xmit.c
> > > @@ -2110,6 +2110,27 @@ static void ath_tx_complete_poll_work(struct work_struct *work)
> > > } else {
> > > txq->axq_tx_inprogress = true;
> > > }
> > > + } else {
> ..
> > > + if (!list_empty(&txq->axq_acq)) {
> ..
> > > + ath_txq_schedule(sc, txq);
> >
> > NAK. This complete work monitors the hw q periodically and does a
> > reset if a hang is detected.
>
> Could you please point to that hang check?
It not exactly a hang check. It is monitoring tx intr when hw q is
non-empty.
Vasanth
next prev parent reply other threads:[~2011-01-07 15:20 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 0:46 [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page greearb at candelatech.com
2011-01-07 0:46 ` greearb
2011-01-07 0:46 ` [ath9k-devel] [PATCH 2/3] ath9k: Re-start xmit logic in xmit watchdog timer greearb at candelatech.com
2011-01-07 0:46 ` greearb
2011-01-07 6:51 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2011-01-07 6:51 ` Vasanthakumar Thiagarajan
2011-01-07 7:16 ` [ath9k-devel] " Ben Greear
2011-01-07 7:16 ` Ben Greear
2011-01-07 15:11 ` [ath9k-devel] " Peter Stuge
2011-01-07 15:11 ` Peter Stuge
2011-01-07 15:19 ` Ben Greear
2011-01-07 15:19 ` Ben Greear
2011-01-07 15:20 ` Vasanthakumar Thiagarajan [this message]
2011-01-07 15:20 ` Vasanthakumar Thiagarajan
2011-01-07 0:46 ` [ath9k-devel] [PATCH 3/3] ath9k: Keep track of stations for debugfs greearb at candelatech.com
2011-01-07 0:46 ` greearb
2011-01-07 2:30 ` [ath9k-devel] " Luis R. Rodriguez
2011-01-07 2:30 ` Luis R. Rodriguez
2011-01-07 2:45 ` Ben Greear
2011-01-07 2:45 ` Ben Greear
2011-01-07 2:49 ` Luis R. Rodriguez
2011-01-07 2:49 ` Luis R. Rodriguez
2011-01-07 3:17 ` Ben Greear
2011-01-07 3:17 ` Ben Greear
2011-01-07 15:36 ` Peter Stuge
2011-01-07 15:36 ` Peter Stuge
2011-01-07 15:52 ` Ben Greear
2011-01-07 15:52 ` Ben Greear
2011-01-07 20:01 ` Luis R. Rodriguez
2011-01-07 20:01 ` Luis R. Rodriguez
2011-01-07 20:25 ` Luis R. Rodriguez
2011-01-07 20:25 ` Luis R. Rodriguez
2011-01-07 20:30 ` Luis R. Rodriguez
2011-01-07 20:30 ` Luis R. Rodriguez
2011-01-07 20:59 ` [ath9k-devel] ath9k debugging Peter Stuge
2011-01-07 19:46 ` [ath9k-devel] [PATCH 3/3] ath9k: Keep track of stations for debugfs Luis R. Rodriguez
2011-01-07 19:46 ` Luis R. Rodriguez
2011-01-07 2:45 ` Felix Fietkau
2011-01-07 2:45 ` Felix Fietkau
2011-01-07 2:48 ` Ben Greear
2011-01-07 2:48 ` Ben Greear
2011-01-07 0:57 ` [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page Luis R. Rodriguez
2011-01-07 0:57 ` Luis R. Rodriguez
2011-01-07 1:03 ` Ben Greear
2011-01-07 1:03 ` Ben Greear
2011-01-07 1:04 ` Christian Lamparter
2011-01-07 1:04 ` Christian Lamparter
2011-01-07 1:23 ` [ath9k-devel] " Eric Dumazet
2011-01-07 1:23 ` Eric Dumazet
2011-01-07 1:57 ` [ath9k-devel] " Luis R. Rodriguez
2011-01-07 1:57 ` Luis R. Rodriguez
2011-01-07 2:07 ` [ath9k-devel] " Eric Dumazet
2011-01-07 2:07 ` Eric Dumazet
2011-01-07 2:13 ` Luis R. Rodriguez
2011-01-07 2:24 ` [ath9k-devel] " Eric Dumazet
2011-01-07 2:24 ` Eric Dumazet
2011-01-07 2:33 ` [ath9k-devel] " Eric Dumazet
2011-01-07 2:33 ` Eric Dumazet
2011-01-07 10:58 ` [ath9k-devel] " Johannes Berg
2011-01-07 10:58 ` Johannes Berg
2011-01-07 18:34 ` [ath9k-devel] " Ben Greear
2011-01-07 18:34 ` Ben Greear
2011-01-07 20:09 ` [ath9k-devel] " Luis R. Rodriguez
2011-01-07 20:09 ` Luis R. Rodriguez
2011-01-07 20:26 ` Eric Dumazet
2011-01-07 20:26 ` Eric Dumazet
2011-01-07 22:20 ` Ben Greear
2011-01-07 22:20 ` Ben Greear
2011-01-07 22:26 ` Eric Dumazet
2011-01-07 22:26 ` Eric Dumazet
2011-01-07 22:46 ` Ben Greear
2011-01-07 22:46 ` Ben Greear
2011-01-09 9:34 ` Johannes Berg
2011-01-09 9:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107152026.GA5656@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.