From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 3/3] ath9k: Keep track of stations for debugfs.
Date: Thu, 06 Jan 2011 18:48:45 -0800 [thread overview]
Message-ID: <4D267F0D.6030508@candelatech.com> (raw)
In-Reply-To: <4D267E47.6050408@openwrt.org>
On 01/06/2011 06:45 PM, Felix Fietkau wrote:
> On 2011-01-06 5:46 PM, greearb at candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> The stations hold the ath_node, which holds the tid
>> and other xmit logic structures. In order to debug
>> stuck xmit logic, we need a way to print out the tid
>> state for the stations.
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
> I really don't like the array with the hardcoded size. How about just adding a struct list_head to the ath_node struct and tracking that?
I can do that..would probably want a pointer back from the ath_node to it's STA struct
as well.
I'll re-work the patch to use a list.
Thanks,
Ben
>
> - Felix
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [ath9k-devel] [PATCH 3/3] ath9k: Keep track of stations for debugfs.
Date: Thu, 06 Jan 2011 18:48:45 -0800 [thread overview]
Message-ID: <4D267F0D.6030508@candelatech.com> (raw)
In-Reply-To: <4D267E47.6050408@openwrt.org>
On 01/06/2011 06:45 PM, Felix Fietkau wrote:
> On 2011-01-06 5:46 PM, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> The stations hold the ath_node, which holds the tid
>> and other xmit logic structures. In order to debug
>> stuck xmit logic, we need a way to print out the tid
>> state for the stations.
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
> I really don't like the array with the hardcoded size. How about just adding a struct list_head to the ath_node struct and tracking that?
I can do that..would probably want a pointer back from the ath_node to it's STA struct
as well.
I'll re-work the patch to use a list.
Thanks,
Ben
>
> - Felix
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-01-07 2:48 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 0:46 [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page greearb at candelatech.com
2011-01-07 0:46 ` greearb
2011-01-07 0:46 ` [ath9k-devel] [PATCH 2/3] ath9k: Re-start xmit logic in xmit watchdog timer greearb at candelatech.com
2011-01-07 0:46 ` greearb
2011-01-07 6:51 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2011-01-07 6:51 ` Vasanthakumar Thiagarajan
2011-01-07 7:16 ` [ath9k-devel] " Ben Greear
2011-01-07 7:16 ` Ben Greear
2011-01-07 15:11 ` [ath9k-devel] " Peter Stuge
2011-01-07 15:11 ` Peter Stuge
2011-01-07 15:19 ` Ben Greear
2011-01-07 15:19 ` Ben Greear
2011-01-07 15:20 ` Vasanthakumar Thiagarajan
2011-01-07 15:20 ` Vasanthakumar Thiagarajan
2011-01-07 0:46 ` [ath9k-devel] [PATCH 3/3] ath9k: Keep track of stations for debugfs greearb at candelatech.com
2011-01-07 0:46 ` greearb
2011-01-07 2:30 ` [ath9k-devel] " Luis R. Rodriguez
2011-01-07 2:30 ` Luis R. Rodriguez
2011-01-07 2:45 ` Ben Greear
2011-01-07 2:45 ` Ben Greear
2011-01-07 2:49 ` Luis R. Rodriguez
2011-01-07 2:49 ` Luis R. Rodriguez
2011-01-07 3:17 ` Ben Greear
2011-01-07 3:17 ` Ben Greear
2011-01-07 15:36 ` Peter Stuge
2011-01-07 15:36 ` Peter Stuge
2011-01-07 15:52 ` Ben Greear
2011-01-07 15:52 ` Ben Greear
2011-01-07 20:01 ` Luis R. Rodriguez
2011-01-07 20:01 ` Luis R. Rodriguez
2011-01-07 20:25 ` Luis R. Rodriguez
2011-01-07 20:25 ` Luis R. Rodriguez
2011-01-07 20:30 ` Luis R. Rodriguez
2011-01-07 20:30 ` Luis R. Rodriguez
2011-01-07 20:59 ` [ath9k-devel] ath9k debugging Peter Stuge
2011-01-07 19:46 ` [ath9k-devel] [PATCH 3/3] ath9k: Keep track of stations for debugfs Luis R. Rodriguez
2011-01-07 19:46 ` Luis R. Rodriguez
2011-01-07 2:45 ` Felix Fietkau
2011-01-07 2:45 ` Felix Fietkau
2011-01-07 2:48 ` Ben Greear [this message]
2011-01-07 2:48 ` Ben Greear
2011-01-07 0:57 ` [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page Luis R. Rodriguez
2011-01-07 0:57 ` Luis R. Rodriguez
2011-01-07 1:03 ` Ben Greear
2011-01-07 1:03 ` Ben Greear
2011-01-07 1:04 ` Christian Lamparter
2011-01-07 1:04 ` Christian Lamparter
2011-01-07 1:23 ` [ath9k-devel] " Eric Dumazet
2011-01-07 1:23 ` Eric Dumazet
2011-01-07 1:57 ` [ath9k-devel] " Luis R. Rodriguez
2011-01-07 1:57 ` Luis R. Rodriguez
2011-01-07 2:07 ` [ath9k-devel] " Eric Dumazet
2011-01-07 2:07 ` Eric Dumazet
2011-01-07 2:13 ` Luis R. Rodriguez
2011-01-07 2:24 ` [ath9k-devel] " Eric Dumazet
2011-01-07 2:24 ` Eric Dumazet
2011-01-07 2:33 ` [ath9k-devel] " Eric Dumazet
2011-01-07 2:33 ` Eric Dumazet
2011-01-07 10:58 ` [ath9k-devel] " Johannes Berg
2011-01-07 10:58 ` Johannes Berg
2011-01-07 18:34 ` [ath9k-devel] " Ben Greear
2011-01-07 18:34 ` Ben Greear
2011-01-07 20:09 ` [ath9k-devel] " Luis R. Rodriguez
2011-01-07 20:09 ` Luis R. Rodriguez
2011-01-07 20:26 ` Eric Dumazet
2011-01-07 20:26 ` Eric Dumazet
2011-01-07 22:20 ` Ben Greear
2011-01-07 22:20 ` Ben Greear
2011-01-07 22:26 ` Eric Dumazet
2011-01-07 22:26 ` Eric Dumazet
2011-01-07 22:46 ` Ben Greear
2011-01-07 22:46 ` Ben Greear
2011-01-09 9:34 ` Johannes Berg
2011-01-09 9:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D267F0D.6030508@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.