From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] [v2] ASoC: cs4270: use the built-in register cache support
Date: Mon, 10 Jan 2011 19:13:59 +0000 [thread overview]
Message-ID: <20110110191359.GB11265@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D2B57FE.4090401@freescale.com>
On Mon, Jan 10, 2011 at 01:03:26PM -0600, Timur Tabi wrote:
> Well, I'm not sure I agree. For one thing, the current code doesn't just fail
> to report I/O errors to the callers, it re-interprets an error code as valid
> date and plows right on ahead.
> In addition, there are places where getting a return code would be useful. I
> call snd_soc_update_bits() in my probe function, so that's a great opportunity
> to tell ASoC that this device is broken and it shouldn't instantiate a sound card.
If you've got the time and enthusiasm to refactor the code to handle
this better feel free to do so; practically speaking it's not a big deal
- I/O rarely fails in production, and when it does fail there's
generally something terribly wrong with the hardware anyway.
prev parent reply other threads:[~2011-01-10 19:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 16:01 [PATCH] [v2] ASoC: cs4270: use the built-in register cache support Timur Tabi
2011-01-10 16:24 ` Dimitris Papastamos
2011-01-10 16:29 ` Dimitris Papastamos
2011-01-10 16:33 ` Timur Tabi
2011-01-10 16:35 ` Mark Brown
2011-01-10 16:36 ` Dimitris Papastamos
2011-01-10 16:54 ` Timur Tabi
2011-01-10 17:35 ` Timur Tabi
2011-01-10 18:23 ` Mark Brown
2011-01-10 18:33 ` Timur Tabi
2011-01-10 18:36 ` Mark Brown
2011-01-10 18:41 ` Timur Tabi
2011-01-10 18:54 ` Mark Brown
2011-01-10 19:03 ` Timur Tabi
2011-01-10 19:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110191359.GB11265@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.