From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] [v2] ASoC: cs4270: use the built-in register cache support
Date: Mon, 10 Jan 2011 12:41:30 -0600 [thread overview]
Message-ID: <4D2B52DA.1090102@freescale.com> (raw)
In-Reply-To: <20110110183615.GC26137@opensource.wolfsonmicro.com>
Mark Brown wrote:
> Note that the return value of the read functions is an unsigned int
> rather than an int.
Oh yeah, I didn't see that. So returning any negative number is broken.
So I don't understand the philosophy here. Are we going to propagate errors
during read operations, or not? It seems that sometimes ASoC does, and
sometimes it doesn't, and sometimes it doesn't even know what it wants (e.g. the
snd_soc_X_X_read functions).
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-01-10 18:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 16:01 [PATCH] [v2] ASoC: cs4270: use the built-in register cache support Timur Tabi
2011-01-10 16:24 ` Dimitris Papastamos
2011-01-10 16:29 ` Dimitris Papastamos
2011-01-10 16:33 ` Timur Tabi
2011-01-10 16:35 ` Mark Brown
2011-01-10 16:36 ` Dimitris Papastamos
2011-01-10 16:54 ` Timur Tabi
2011-01-10 17:35 ` Timur Tabi
2011-01-10 18:23 ` Mark Brown
2011-01-10 18:33 ` Timur Tabi
2011-01-10 18:36 ` Mark Brown
2011-01-10 18:41 ` Timur Tabi [this message]
2011-01-10 18:54 ` Mark Brown
2011-01-10 19:03 ` Timur Tabi
2011-01-10 19:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B52DA.1090102@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.