All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] [v2] ASoC: cs4270: use the built-in register cache support
Date: Mon, 10 Jan 2011 18:23:02 +0000	[thread overview]
Message-ID: <20110110182302.GB26137@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D2B4376.101@freescale.com>

On Mon, Jan 10, 2011 at 11:35:50AM -0600, Timur Tabi wrote:

> This doesn't seem right to me.  Here, the .put function returns 0 or 1,
> depending on whether or not the bits were actually updated.  Is that what's
> intended?  I can't find any documentation that tells me what the return values
> of snd_kcontrol_put_t are supposed to be.

It's supposed to be 1 for change, 0 for no change or an error - if you
look at the core functions you'll see that they generally all follow
this idiom of using the return value from snd_soc_update_bits() directly.

  reply	other threads:[~2011-01-10 18:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 16:01 [PATCH] [v2] ASoC: cs4270: use the built-in register cache support Timur Tabi
2011-01-10 16:24 ` Dimitris Papastamos
2011-01-10 16:29 ` Dimitris Papastamos
2011-01-10 16:33   ` Timur Tabi
2011-01-10 16:35     ` Mark Brown
2011-01-10 16:36     ` Dimitris Papastamos
2011-01-10 16:54       ` Timur Tabi
2011-01-10 17:35       ` Timur Tabi
2011-01-10 18:23         ` Mark Brown [this message]
2011-01-10 18:33           ` Timur Tabi
2011-01-10 18:36             ` Mark Brown
2011-01-10 18:41               ` Timur Tabi
2011-01-10 18:54                 ` Mark Brown
2011-01-10 19:03                   ` Timur Tabi
2011-01-10 19:13                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110110182302.GB26137@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.