All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Vincent Sanders <vince-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>,
	Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>,
	linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support
Date: Tue, 25 Jan 2011 07:51:04 +0000	[thread overview]
Message-ID: <20110125075104.GJ11673@linux-sh.org> (raw)
In-Reply-To: <1295863047-11131-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>

On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote:
> @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev)
>  
>  	if (info->pdata = NULL) {
>  		dev_info(dev, "using default configuration data\n");
> -		info->pdata = &sm501fb_def_pdata;
>  	}
>  
>  	/* probe for the presence of each panel */

I assume this is accidental? I don't see how you're compensating for this
in any of the other patches at least, as it's orthogonal from the default
mode settings.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Heiko Schocher <hs@denx.de>
Cc: linux-fbdev@vger.kernel.org, devicetree-discuss@ozlabs.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Vincent Sanders <vince@simtec.co.uk>,
	linux-kernel@vger.kernel.org, Ben Dooks <ben@simtec.co.uk>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support
Date: Tue, 25 Jan 2011 16:51:04 +0900	[thread overview]
Message-ID: <20110125075104.GJ11673@linux-sh.org> (raw)
In-Reply-To: <1295863047-11131-1-git-send-email-hs@denx.de>

On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote:
> @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev)
>  
>  	if (info->pdata == NULL) {
>  		dev_info(dev, "using default configuration data\n");
> -		info->pdata = &sm501fb_def_pdata;
>  	}
>  
>  	/* probe for the presence of each panel */

I assume this is accidental? I don't see how you're compensating for this
in any of the other patches at least, as it's orthogonal from the default
mode settings.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Heiko Schocher <hs@denx.de>
Cc: linuxppc-dev@lists.ozlabs.org, linux-fbdev@vger.kernel.org,
	devicetree-discuss@ozlabs.org, Ben Dooks <ben@simtec.co.uk>,
	Vincent Sanders <vince@simtec.co.uk>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support
Date: Tue, 25 Jan 2011 16:51:04 +0900	[thread overview]
Message-ID: <20110125075104.GJ11673@linux-sh.org> (raw)
In-Reply-To: <1295863047-11131-1-git-send-email-hs@denx.de>

On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote:
> @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev)
>  
>  	if (info->pdata == NULL) {
>  		dev_info(dev, "using default configuration data\n");
> -		info->pdata = &sm501fb_def_pdata;
>  	}
>  
>  	/* probe for the presence of each panel */

I assume this is accidental? I don't see how you're compensating for this
in any of the other patches at least, as it's orthogonal from the default
mode settings.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
To: Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Vincent Sanders <vince-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>,
	Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>,
	linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support
Date: Tue, 25 Jan 2011 16:51:04 +0900	[thread overview]
Message-ID: <20110125075104.GJ11673@linux-sh.org> (raw)
In-Reply-To: <1295863047-11131-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>

On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote:
> @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev)
>  
>  	if (info->pdata == NULL) {
>  		dev_info(dev, "using default configuration data\n");
> -		info->pdata = &sm501fb_def_pdata;
>  	}
>  
>  	/* probe for the presence of each panel */

I assume this is accidental? I don't see how you're compensating for this
in any of the other patches at least, as it's orthogonal from the default
mode settings.

  parent reply	other threads:[~2011-01-25  7:51 UTC|newest]

Thread overview: 177+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-04  8:23 [PATCH 1/2] video, sm501: add OF binding to support SM501 Heiko Schocher
2010-12-04  8:23 ` Heiko Schocher
2010-12-04  8:23 ` Heiko Schocher
2010-12-04  8:23 ` [PATCH 2/2] powerpc, video: add SM501 support for charon board Heiko Schocher
2010-12-04  8:23   ` Heiko Schocher
     [not found]   ` <1291451028-22532-2-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2010-12-07  6:59     ` [PATCH 2/2 v2] " Heiko Schocher
2010-12-07  6:59       ` Heiko Schocher
2010-12-07  6:59       ` Heiko Schocher
2010-12-11  6:31   ` [PATCH v3 2/2] " Heiko Schocher
2010-12-11  6:31     ` Heiko Schocher
2010-12-11  6:31     ` Heiko Schocher
2011-01-24  9:57   ` [PATCH 4/4 v4] " Heiko Schocher
2011-01-24  9:57     ` Heiko Schocher
2011-01-24  9:57     ` Heiko Schocher
2011-01-25  6:45   ` [PATCH 4/4 v5] " Heiko Schocher
2011-01-25  6:45     ` Heiko Schocher
2011-01-25  6:45     ` Heiko Schocher
     [not found]     ` <1295937946-26934-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-01-25  6:49       ` Paul Mundt
2011-01-25  6:49         ` Paul Mundt
2011-01-25  6:49         ` Paul Mundt
2011-01-25  6:49         ` Paul Mundt
     [not found]         ` <20110125064949.GF11673-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2011-01-25  7:07           ` Heiko Schocher
2011-01-25  7:07             ` Heiko Schocher
2011-01-25  7:07             ` Heiko Schocher
2011-01-25  7:07             ` Heiko Schocher
2010-12-08  5:36 ` [PATCH 1/2] video, sm501: add OF binding to support SM501 Paul Mundt
2010-12-08  5:36   ` Paul Mundt
2010-12-09  6:49   ` Heiko Schocher
2010-12-09  6:49     ` Heiko Schocher
2010-12-09 15:03     ` Samuel Ortiz
2010-12-09 15:03       ` Samuel Ortiz
2010-12-11  6:31 ` [PATCH v2 " Heiko Schocher
2010-12-11  6:31   ` Heiko Schocher
2010-12-11  6:31   ` Heiko Schocher
2010-12-11 18:28   ` Randy Dunlap
2010-12-11 22:34   ` Randy Dunlap
2010-12-11 22:34     ` Randy Dunlap
2010-12-11 22:34     ` Randy Dunlap
2010-12-13  7:01     ` Heiko Schocher
2010-12-13  7:01       ` Heiko Schocher
2010-12-13  7:01       ` Heiko Schocher
2011-01-06  4:47   ` Paul Mundt
2011-01-06  4:47     ` Paul Mundt
2011-01-06  4:47     ` Paul Mundt
2011-01-24  9:57 ` [PATCH 2/4 v4] video, sm501: add edid and commandline support Heiko Schocher
2011-01-24  9:57   ` Heiko Schocher
2011-01-24  9:57   ` Heiko Schocher
     [not found]   ` <1295863047-11131-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-01-25  7:51     ` Paul Mundt [this message]
2011-01-25  7:51       ` Paul Mundt
2011-01-25  7:51       ` Paul Mundt
2011-01-25  7:51       ` Paul Mundt
     [not found]       ` <20110125075104.GJ11673-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2011-01-25  8:04         ` Heiko Schocher
2011-01-25  8:04           ` Heiko Schocher
2011-01-25  8:04           ` Heiko Schocher
2011-01-25  8:04           ` Heiko Schocher
2011-01-24  9:57 ` [PATCH 3/4 v4] video, sm501: add OF binding to support SM501 Heiko Schocher
2011-01-24  9:57   ` Heiko Schocher
2011-01-24  9:57   ` Heiko Schocher
2011-01-25  6:38   ` Paul Mundt
2011-01-25  6:38     ` Paul Mundt
2011-01-25  6:38     ` Paul Mundt
2011-01-31 10:52   ` Samuel Ortiz
2011-01-31 10:52     ` Samuel Ortiz
2011-01-31 10:52     ` Samuel Ortiz
2011-01-25  7:20 ` Heiko Schocher
2011-01-25  7:20   ` Heiko Schocher
2011-01-25  7:20   ` Heiko Schocher
2011-01-25  7:48   ` Paul Mundt
2011-01-25  7:48     ` Paul Mundt
2011-01-25  7:48     ` Paul Mundt
     [not found]     ` <20110125074820.GI11673-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2011-01-25  8:02       ` Heiko Schocher
2011-01-25  8:02         ` Heiko Schocher
2011-01-25  8:02         ` Heiko Schocher
2011-01-25  8:02         ` Heiko Schocher
2011-01-26  7:21 ` [PATCH 2/4 v5] video, sm501: add edid and commandline support Heiko Schocher
2011-01-26  7:21   ` Heiko Schocher
2011-01-26  7:21   ` Heiko Schocher
2011-01-26  7:21 ` [PATCH 3/4 v5] video, sm501: add OF binding to support SM501 Heiko Schocher
2011-01-26  7:21   ` Heiko Schocher
2011-01-26  7:21   ` Heiko Schocher
2011-03-15  7:26   ` Heiko Schocher
2011-03-15  7:26     ` Heiko Schocher
2011-03-15  7:26     ` Heiko Schocher
2011-03-16 15:36     ` Paul Mundt
2011-03-16 15:36       ` Paul Mundt
2011-03-16 15:36       ` Paul Mundt
     [not found]       ` <20110316153601.GA13315-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2011-03-17  6:12         ` Heiko Schocher
2011-03-17  6:12           ` Heiko Schocher
2011-03-17  6:12           ` Heiko Schocher
2011-03-17  6:12           ` Heiko Schocher
2011-03-22  8:20           ` Paul Mundt
2011-03-22  8:20             ` Paul Mundt
2011-03-22  8:20             ` Paul Mundt
     [not found]             ` <20110322082047.GG25925-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2011-03-22  8:25               ` Heiko Schocher
2011-03-22  8:25                 ` Heiko Schocher
2011-03-22  8:25                 ` Heiko Schocher
2011-03-22  8:25                 ` Heiko Schocher
2011-02-06 23:45 ` [PATCH 1/2] " Benjamin Herrenschmidt
2011-02-06 23:45   ` Benjamin Herrenschmidt
     [not found] ` <1291451028-22532-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-01-24  9:57   ` [PATCH 1/4 v4] video, sm501: add I/O functions for use on powerpc Heiko Schocher
2011-01-24  9:57     ` Heiko Schocher
2011-01-24  9:57     ` Heiko Schocher
2011-01-24  9:57     ` Heiko Schocher
2011-01-31 10:50     ` [PATCH 1/4 v4] video, sm501: add I/O functions for use on Samuel Ortiz
2011-01-31 10:50       ` [PATCH 1/4 v4] video, sm501: add I/O functions for use on powerpc Samuel Ortiz
2011-01-31 10:50       ` Samuel Ortiz
2011-03-22  8:27   ` [PATCH v6 0/6] powerpc, 52xx: add charon board support Heiko Schocher
2011-03-22  8:27     ` Heiko Schocher
2011-03-22  8:27     ` Heiko Schocher
2011-03-22  8:27     ` Heiko Schocher
2011-03-22  8:27     ` [PATCH v1 1/6] powerpc, 5200: add support for charon board Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
2011-03-22  9:06       ` Wolfram Sang
2011-03-22  9:06         ` Wolfram Sang
2011-03-22  9:06         ` Wolfram Sang
2011-03-22  8:27     ` [PATCH v6 2/6] video, sm501: add I/O functions for use on powerpc Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
     [not found]       ` <1300782452-528-3-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-05-02 22:24         ` Grant Likely
2011-05-02 22:24           ` Grant Likely
2011-05-02 22:24           ` Grant Likely
2011-05-02 22:24           ` Grant Likely
     [not found]     ` <1300782452-528-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-03-22  8:27       ` [PATCH v6 3/6] video, sm501: add edid and commandline support Heiko Schocher
2011-03-22  8:27         ` Heiko Schocher
2011-03-22  8:27         ` Heiko Schocher
2011-03-22  8:27         ` Heiko Schocher
     [not found]         ` <1300782452-528-4-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-05-02 22:27           ` Grant Likely
2011-05-02 22:27             ` Grant Likely
2011-05-02 22:27             ` Grant Likely
2011-05-02 22:27             ` Grant Likely
2011-05-02 22:37             ` Grant Likely
2011-05-02 22:37               ` Grant Likely
2011-05-02 22:37               ` Grant Likely
2011-05-03  5:27               ` Heiko Schocher
2011-05-03  5:27                 ` Heiko Schocher
2011-05-03  5:27                 ` Heiko Schocher
2011-05-03  5:43                 ` Grant Likely
2011-05-03  5:43                   ` Grant Likely
2011-05-03  5:43                   ` Grant Likely
2011-03-22  8:27       ` [PATCH v6 6/6] powerpc, tqm5200: update tqm5200_defconfig to fit for charon board Heiko Schocher
2011-03-22  8:27         ` Heiko Schocher
2011-03-22  8:27         ` Heiko Schocher
2011-03-22  8:27         ` Heiko Schocher
2011-03-22  9:10         ` [PATCH v6 6/6] powerpc, tqm5200: update tqm5200_defconfig to Wolfram Sang
2011-03-22  9:10           ` [PATCH v6 6/6] powerpc, tqm5200: update tqm5200_defconfig to fit for charon board Wolfram Sang
2011-03-22  9:10           ` Wolfram Sang
2011-05-02 22:31           ` [PATCH v6 6/6] powerpc, tqm5200: update tqm5200_defconfig to fit Grant Likely
2011-05-02 22:31             ` [PATCH v6 6/6] powerpc, tqm5200: update tqm5200_defconfig to fit for charon board Grant Likely
2011-05-02 22:31             ` Grant Likely
2011-03-22  8:27     ` [PATCH v6 4/6] video, sm501: add OF binding to support SM501 Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
2011-05-02 22:28       ` Grant Likely
2011-05-02 22:28         ` Grant Likely
2011-05-02 22:28         ` Grant Likely
2011-03-22  8:27     ` [PATCH v6 5/6] powerpc, video: add SM501 support for charon board Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
2011-03-22  8:27       ` Heiko Schocher
2011-03-22 20:58     ` [PATCH v6 0/6] powerpc, 52xx: add charon board support Grant Likely
2011-03-22 20:58       ` Grant Likely
2011-03-22 20:58       ` Grant Likely
2011-05-02 22:14     ` Grant Likely
2011-05-02 22:14       ` Grant Likely
2011-05-02 22:14       ` Grant Likely
2011-05-03  5:17       ` Heiko Schocher
2011-05-03  5:17         ` Heiko Schocher
2011-05-03  5:17         ` Heiko Schocher
2011-05-03  5:42         ` Grant Likely
2011-05-03  5:42           ` Grant Likely
2011-05-03  5:42           ` Grant Likely
2011-05-03  7:24           ` Heiko Schocher
2011-05-03  7:24             ` Heiko Schocher
2011-05-03  7:24             ` Heiko Schocher
2011-05-03 13:22             ` Grant Likely
2011-05-03 13:22               ` Grant Likely
2011-05-03 13:22               ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110125075104.GJ11673@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org \
    --cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=hs-ynQEQJNshbs@public.gmane.org \
    --cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=vince-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.