From: Dan Carpenter <error27@gmail.com>
To: Luciano Coelho <coelho@ti.com>, shahar_levi@ti.com
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] wl12xx: change type from u8 to int
Date: Mon, 07 Feb 2011 16:47:42 +0000 [thread overview]
Message-ID: <20110207164742.GE4384@bicker> (raw)
ret is used to store int types. Using an u8 will break the error
handling.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/wl12xx/init.c b/drivers/net/wireless/wl12xx/init.c
index 70b3dc8..e430b2a 100644
--- a/drivers/net/wireless/wl12xx/init.c
+++ b/drivers/net/wireless/wl12xx/init.c
@@ -470,7 +470,7 @@ static void wl1271_check_ba_support(struct wl1271 *wl)
static int wl1271_set_ba_policies(struct wl1271 *wl)
{
u8 tid_index;
- u8 ret = 0;
+ int ret = 0;
/* Reset the BA RX indicators */
wl->ba_rx_bitmap = 0;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Luciano Coelho <coelho@ti.com>, shahar_levi@ti.com
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] wl12xx: change type from u8 to int
Date: Mon, 7 Feb 2011 19:47:42 +0300 [thread overview]
Message-ID: <20110207164742.GE4384@bicker> (raw)
ret is used to store int types. Using an u8 will break the error
handling.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/wl12xx/init.c b/drivers/net/wireless/wl12xx/init.c
index 70b3dc8..e430b2a 100644
--- a/drivers/net/wireless/wl12xx/init.c
+++ b/drivers/net/wireless/wl12xx/init.c
@@ -470,7 +470,7 @@ static void wl1271_check_ba_support(struct wl1271 *wl)
static int wl1271_set_ba_policies(struct wl1271 *wl)
{
u8 tid_index;
- u8 ret = 0;
+ int ret = 0;
/* Reset the BA RX indicators */
wl->ba_rx_bitmap = 0;
next reply other threads:[~2011-02-07 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 16:47 Dan Carpenter [this message]
2011-02-07 16:47 ` [patch] wl12xx: change type from u8 to int Dan Carpenter
2011-02-23 13:52 ` Luciano Coelho
2011-02-23 13:52 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207164742.GE4384@bicker \
--to=error27@gmail.com \
--cc=coelho@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=shahar_levi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.