* [patch] wl12xx: change type from u8 to int
@ 2011-02-07 16:47 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-02-07 16:47 UTC (permalink / raw)
To: Luciano Coelho, shahar_levi
Cc: John W. Linville, linux-wireless, kernel-janitors
ret is used to store int types. Using an u8 will break the error
handling.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/wl12xx/init.c b/drivers/net/wireless/wl12xx/init.c
index 70b3dc8..e430b2a 100644
--- a/drivers/net/wireless/wl12xx/init.c
+++ b/drivers/net/wireless/wl12xx/init.c
@@ -470,7 +470,7 @@ static void wl1271_check_ba_support(struct wl1271 *wl)
static int wl1271_set_ba_policies(struct wl1271 *wl)
{
u8 tid_index;
- u8 ret = 0;
+ int ret = 0;
/* Reset the BA RX indicators */
wl->ba_rx_bitmap = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] wl12xx: change type from u8 to int
@ 2011-02-07 16:47 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-02-07 16:47 UTC (permalink / raw)
To: Luciano Coelho, shahar_levi
Cc: John W. Linville, linux-wireless, kernel-janitors
ret is used to store int types. Using an u8 will break the error
handling.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/wl12xx/init.c b/drivers/net/wireless/wl12xx/init.c
index 70b3dc8..e430b2a 100644
--- a/drivers/net/wireless/wl12xx/init.c
+++ b/drivers/net/wireless/wl12xx/init.c
@@ -470,7 +470,7 @@ static void wl1271_check_ba_support(struct wl1271 *wl)
static int wl1271_set_ba_policies(struct wl1271 *wl)
{
u8 tid_index;
- u8 ret = 0;
+ int ret = 0;
/* Reset the BA RX indicators */
wl->ba_rx_bitmap = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] wl12xx: change type from u8 to int
2011-02-07 16:47 ` Dan Carpenter
@ 2011-02-23 13:52 ` Luciano Coelho
-1 siblings, 0 replies; 4+ messages in thread
From: Luciano Coelho @ 2011-02-23 13:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: shahar_levi, John W. Linville, linux-wireless, kernel-janitors
On Mon, 2011-02-07 at 19:47 +0300, Dan Carpenter wrote:
> ret is used to store int types. Using an u8 will break the error
> handling.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks Dan!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-23 13:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-07 16:47 [patch] wl12xx: change type from u8 to int Dan Carpenter
2011-02-07 16:47 ` Dan Carpenter
2011-02-23 13:52 ` Luciano Coelho
2011-02-23 13:52 ` Luciano Coelho
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.