* [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo
@ 2011-02-04 14:55 Koerber, Philip (GE Intelligent Platforms)
2011-02-04 17:11 ` Jesse Barnes
0 siblings, 1 reply; 4+ messages in thread
From: Koerber, Philip (GE Intelligent Platforms) @ 2011-02-04 14:55 UTC (permalink / raw)
To: platform-driver-x86; +Cc: Jesse Barnes
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
Dear Kernel Maintainers,
I have observed, that on our SBC's the GPU turbo mode doesn't work. This happens only to those with embedded Arrandale (1288 FCBGA package) standard voltage (35W) CPU's. These CPU's do not have there an letter whereas the Mobile CPU has an M. So there seems to be a need to update the intel_ips.c in order to recognize the CPU's with brand strings 'Intel(R) Core(TM) i7 CPU 610 @ 2.53GHz' and 'Intel(R) Core(TM) i5 CPU 520 @ 2.40GHz'. I have prepared therefor following patch:
diff -urN linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c linux/drivers/platform/x86/intel_ips.c
--- linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c 2011-02-01 04:05:49.000000000 +0100
+++ linux/drivers/platform/x86/intel_ips.c 2011-02-04 15:25:40.205627688 +0100
@@ -1399,6 +1399,10 @@
limits = &ips_lv_limits;
else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
limits = &ips_ulv_limits;
+ else if (strstr(boot_cpu_data.x86_model_id, "CPU 610"))
+ limits = &ips_sv_limits;
+ else if (strstr(boot_cpu_data.x86_model_id, "CPU 520"))
+ limits = &ips_sv_limits;
else {
dev_info(&ips->dev->dev, "No CPUID match found.\n");
goto out;
With best Regards,
Philip
Philip Koerber
Technical Support
+49 821 5034 178
Memminger Straße 14
86159 Augsburg
Germany
[-- Attachment #2: embedded_arrandale_ips_patch --]
[-- Type: application/octet-stream, Size: 676 bytes --]
diff -urN linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c linux/drivers/platform/x86/intel_ips.c
--- linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c 2011-02-01 04:05:49.000000000 +0100
+++ linux/drivers/platform/x86/intel_ips.c 2011-02-04 15:25:40.205627688 +0100
@@ -1399,6 +1399,10 @@
limits = &ips_lv_limits;
else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
limits = &ips_ulv_limits;
+ else if (strstr(boot_cpu_data.x86_model_id, "CPU 610"))
+ limits = &ips_sv_limits;
+ else if (strstr(boot_cpu_data.x86_model_id, "CPU 520"))
+ limits = &ips_sv_limits;
else {
dev_info(&ips->dev->dev, "No CPUID match found.\n");
goto out;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo
2011-02-04 14:55 [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo Koerber, Philip (GE Intelligent Platforms)
@ 2011-02-04 17:11 ` Jesse Barnes
2011-02-07 19:13 ` Matthew Garrett
0 siblings, 1 reply; 4+ messages in thread
From: Jesse Barnes @ 2011-02-04 17:11 UTC (permalink / raw)
To: Koerber, Philip (GE Intelligent Platforms); +Cc: platform-driver-x86
On Fri, 4 Feb 2011 15:55:30 +0100
"Koerber, Philip (GE Intelligent Platforms)" <Philip.Koerber@ge.com>
wrote:
> Dear Kernel Maintainers,
>
> I have observed, that on our SBC's the GPU turbo mode doesn't work. This happens only to those with embedded Arrandale (1288 FCBGA package) standard voltage (35W) CPU's. These CPU's do not have there an letter whereas the Mobile CPU has an M. So there seems to be a need to update the intel_ips.c in order to recognize the CPU's with brand strings 'Intel(R) Core(TM) i7 CPU 610 @ 2.53GHz' and 'Intel(R) Core(TM) i5 CPU 520 @ 2.40GHz'. I have prepared therefor following patch:
>
>
> diff -urN linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c linux/drivers/platform/x86/intel_ips.c
> --- linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c 2011-02-01 04:05:49.000000000 +0100
> +++ linux/drivers/platform/x86/intel_ips.c 2011-02-04 15:25:40.205627688 +0100
> @@ -1399,6 +1399,10 @@
> limits = &ips_lv_limits;
> else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
> limits = &ips_ulv_limits;
> + else if (strstr(boot_cpu_data.x86_model_id, "CPU 610"))
> + limits = &ips_sv_limits;
> + else if (strstr(boot_cpu_data.x86_model_id, "CPU 520"))
> + limits = &ips_sv_limits;
> else {
> dev_info(&ips->dev->dev, "No CPUID match found.\n");
> goto out;
Yep, that's fine with me, thanks for the patch!
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo
2011-02-04 17:11 ` Jesse Barnes
@ 2011-02-07 19:13 ` Matthew Garrett
2011-02-07 19:16 ` Jesse Barnes
0 siblings, 1 reply; 4+ messages in thread
From: Matthew Garrett @ 2011-02-07 19:13 UTC (permalink / raw)
To: Jesse Barnes
Cc: Koerber, Philip (GE Intelligent Platforms), platform-driver-x86
On Fri, Feb 04, 2011 at 09:11:56AM -0800, Jesse Barnes wrote:
> > +++ linux/drivers/platform/x86/intel_ips.c 2011-02-04 15:25:40.205627688 +0100
> > @@ -1399,6 +1399,10 @@
> > limits = &ips_lv_limits;
> > else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
> > limits = &ips_ulv_limits;
> > + else if (strstr(boot_cpu_data.x86_model_id, "CPU 610"))
> > + limits = &ips_sv_limits;
> > + else if (strstr(boot_cpu_data.x86_model_id, "CPU 520"))
> > + limits = &ips_sv_limits;
> > else {
> > dev_info(&ips->dev->dev, "No CPUID match found.\n");
> > goto out;
>
> Yep, that's fine with me, thanks for the patch!
Are these the only two embedded Arrandales? Is there really no MSR that
gives you the voltage range?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo
2011-02-07 19:13 ` Matthew Garrett
@ 2011-02-07 19:16 ` Jesse Barnes
0 siblings, 0 replies; 4+ messages in thread
From: Jesse Barnes @ 2011-02-07 19:16 UTC (permalink / raw)
To: Matthew Garrett
Cc: Koerber, Philip (GE Intelligent Platforms), platform-driver-x86
On Mon, 7 Feb 2011 19:13:21 +0000
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Fri, Feb 04, 2011 at 09:11:56AM -0800, Jesse Barnes wrote:
> > > +++ linux/drivers/platform/x86/intel_ips.c 2011-02-04 15:25:40.205627688 +0100
> > > @@ -1399,6 +1399,10 @@
> > > limits = &ips_lv_limits;
> > > else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
> > > limits = &ips_ulv_limits;
> > > + else if (strstr(boot_cpu_data.x86_model_id, "CPU 610"))
> > > + limits = &ips_sv_limits;
> > > + else if (strstr(boot_cpu_data.x86_model_id, "CPU 520"))
> > > + limits = &ips_sv_limits;
> > > else {
> > > dev_info(&ips->dev->dev, "No CPUID match found.\n");
> > > goto out;
> >
> > Yep, that's fine with me, thanks for the patch!
>
> Are these the only two embedded Arrandales? Is there really no MSR that
> gives you the voltage range?
AFAIK this is the same method the Windows driver uses, so I don't think
so.
Fortunately the on-die integration in Sandy Bridge makes all this
unnecessary, so I don't expect you'll have to continually add entries
to this list over time.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-07 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-04 14:55 [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo Koerber, Philip (GE Intelligent Platforms)
2011-02-04 17:11 ` Jesse Barnes
2011-02-07 19:13 ` Matthew Garrett
2011-02-07 19:16 ` Jesse Barnes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.