From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-mmc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
"Eric Bénard" <eric@eukrea.com>,
"Zhu Richard-R65037" <r65037@freescale.com>,
"Anton Vorontsov" <cbouatmailru@gmail.com>
Subject: Re: [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk
Date: Thu, 10 Feb 2011 20:18:21 +0100 [thread overview]
Message-ID: <20110210191821.GD2206@pengutronix.de> (raw)
In-Reply-To: <1297365291-1038-3-git-send-email-w.sang@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2297 bytes --]
Adding Anton to Cc...
On Thu, Feb 10, 2011 at 08:14:48PM +0100, Wolfram Sang wrote:
> It can be worked around using a GPIO which will be done for i.MX later.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++-
> drivers/mmc/host/sdhci-esdhc.h | 1 -
> drivers/mmc/host/sdhci-of-esdhc.c | 3 ++-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 83d178b..e0fa1f3 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -170,7 +170,8 @@ static void esdhc_pltfm_exit(struct sdhci_host *host)
> }
>
> struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = {
> - .quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA,
> + .quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA
> + | SDHCI_QUIRK_BROKEN_CARD_DETECTION,
> /* ADMA has issues. Might be fixable */
> .ops = &sdhci_esdhc_ops,
> .init = esdhc_pltfm_init,
> diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h
> index afaf1bc..c55aae8 100644
> --- a/drivers/mmc/host/sdhci-esdhc.h
> +++ b/drivers/mmc/host/sdhci-esdhc.h
> @@ -19,7 +19,6 @@
> */
>
> #define ESDHC_DEFAULT_QUIRKS (SDHCI_QUIRK_FORCE_BLK_SZ_2048 | \
> - SDHCI_QUIRK_BROKEN_CARD_DETECTION | \
> SDHCI_QUIRK_NO_BUSY_IRQ | \
> SDHCI_QUIRK_NONSTANDARD_CLOCK | \
> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | \
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index fcd0e1f..08161f6 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -73,7 +73,8 @@ static unsigned int esdhc_of_get_min_clock(struct sdhci_host *host)
> }
>
> struct sdhci_of_data sdhci_esdhc = {
> - .quirks = ESDHC_DEFAULT_QUIRKS,
> + /* card detection could be handled via GPIO */
> + .quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_CARD_DETECTION,
> .ops = {
> .read_l = sdhci_be32bs_readl,
> .read_w = esdhc_readw,
> --
> 1.7.2.3
>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk
Date: Thu, 10 Feb 2011 20:18:21 +0100 [thread overview]
Message-ID: <20110210191821.GD2206@pengutronix.de> (raw)
In-Reply-To: <1297365291-1038-3-git-send-email-w.sang@pengutronix.de>
Adding Anton to Cc...
On Thu, Feb 10, 2011 at 08:14:48PM +0100, Wolfram Sang wrote:
> It can be worked around using a GPIO which will be done for i.MX later.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++-
> drivers/mmc/host/sdhci-esdhc.h | 1 -
> drivers/mmc/host/sdhci-of-esdhc.c | 3 ++-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 83d178b..e0fa1f3 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -170,7 +170,8 @@ static void esdhc_pltfm_exit(struct sdhci_host *host)
> }
>
> struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = {
> - .quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA,
> + .quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA
> + | SDHCI_QUIRK_BROKEN_CARD_DETECTION,
> /* ADMA has issues. Might be fixable */
> .ops = &sdhci_esdhc_ops,
> .init = esdhc_pltfm_init,
> diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h
> index afaf1bc..c55aae8 100644
> --- a/drivers/mmc/host/sdhci-esdhc.h
> +++ b/drivers/mmc/host/sdhci-esdhc.h
> @@ -19,7 +19,6 @@
> */
>
> #define ESDHC_DEFAULT_QUIRKS (SDHCI_QUIRK_FORCE_BLK_SZ_2048 | \
> - SDHCI_QUIRK_BROKEN_CARD_DETECTION | \
> SDHCI_QUIRK_NO_BUSY_IRQ | \
> SDHCI_QUIRK_NONSTANDARD_CLOCK | \
> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | \
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index fcd0e1f..08161f6 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -73,7 +73,8 @@ static unsigned int esdhc_of_get_min_clock(struct sdhci_host *host)
> }
>
> struct sdhci_of_data sdhci_esdhc = {
> - .quirks = ESDHC_DEFAULT_QUIRKS,
> + /* card detection could be handled via GPIO */
> + .quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_CARD_DETECTION,
> .ops = {
> .read_l = sdhci_be32bs_readl,
> .read_w = esdhc_readw,
> --
> 1.7.2.3
>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110210/398800b4/attachment-0001.sig>
next prev parent reply other threads:[~2011-02-10 19:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 19:14 [PATCH 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Wolfram Sang
2011-02-10 19:14 ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO Wolfram Sang
2011-02-10 19:14 ` Wolfram Sang
2011-02-10 22:24 ` Marc Reilly
2011-02-10 22:24 ` Marc Reilly
2011-02-11 9:42 ` Wolfram Sang
2011-02-11 9:42 ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk Wolfram Sang
2011-02-10 19:14 ` Wolfram Sang
2011-02-10 19:18 ` Wolfram Sang [this message]
2011-02-10 19:18 ` Wolfram Sang
2011-02-11 10:07 ` Anton Vorontsov
2011-02-11 10:07 ` Anton Vorontsov
2011-02-10 19:14 ` [PATCH 3/5] mmc: sdhci-esdhc-imx: add card detect on custom GPIO Wolfram Sang
2011-02-10 19:14 ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 4/5] arm: mach-mx3: pcm043: add write-protect and card-detect for SD1 Wolfram Sang
2011-02-10 19:14 ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 5/5] arm: mach-mx3: use IMX_GPIO_NR instead of hard-coded values Wolfram Sang
2011-02-10 19:14 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2011-02-22 12:58 [PATCH V2 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Wolfram Sang
2011-02-22 12:58 ` [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk Wolfram Sang
2011-02-22 12:58 ` Wolfram Sang
2011-02-23 13:51 [PATCH V3 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Wolfram Sang
2011-02-23 13:51 ` [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk Wolfram Sang
2011-02-23 13:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210191821.GD2206@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cbouatmailru@gmail.com \
--cc=eric@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r65037@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.