All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kernel@pengutronix.de, "Eric Bénard" <eric@eukrea.com>,
	"Zhu Richard-R65037" <r65037@freescale.com>
Subject: Re: [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk
Date: Fri, 11 Feb 2011 13:07:39 +0300	[thread overview]
Message-ID: <20110211100739.GA8965@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20110210191821.GD2206@pengutronix.de>

On Thu, Feb 10, 2011 at 08:18:21PM +0100, Wolfram Sang wrote:
> 
> Adding Anton to Cc...
[...]
> >  struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = {
> > -	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA,
> > +	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA
> > +			| SDHCI_QUIRK_BROKEN_CARD_DETECTION,

Minor nit: "|" should be on the previous line.

Otherwise,

Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

WARNING: multiple messages have this Message-ID (diff)
From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk
Date: Fri, 11 Feb 2011 13:07:39 +0300	[thread overview]
Message-ID: <20110211100739.GA8965@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20110210191821.GD2206@pengutronix.de>

On Thu, Feb 10, 2011 at 08:18:21PM +0100, Wolfram Sang wrote:
> 
> Adding Anton to Cc...
[...]
> >  struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = {
> > -	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA,
> > +	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA
> > +			| SDHCI_QUIRK_BROKEN_CARD_DETECTION,

Minor nit: "|" should be on the previous line.

Otherwise,

Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru at gmail.com

  reply	other threads:[~2011-02-11 10:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 19:14 [PATCH 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Wolfram Sang
2011-02-10 19:14 ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO Wolfram Sang
2011-02-10 19:14   ` Wolfram Sang
2011-02-10 22:24   ` Marc Reilly
2011-02-10 22:24     ` Marc Reilly
2011-02-11  9:42     ` Wolfram Sang
2011-02-11  9:42       ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk Wolfram Sang
2011-02-10 19:14   ` Wolfram Sang
2011-02-10 19:18   ` Wolfram Sang
2011-02-10 19:18     ` Wolfram Sang
2011-02-11 10:07     ` Anton Vorontsov [this message]
2011-02-11 10:07       ` Anton Vorontsov
2011-02-10 19:14 ` [PATCH 3/5] mmc: sdhci-esdhc-imx: add card detect on custom GPIO Wolfram Sang
2011-02-10 19:14   ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 4/5] arm: mach-mx3: pcm043: add write-protect and card-detect for SD1 Wolfram Sang
2011-02-10 19:14   ` Wolfram Sang
2011-02-10 19:14 ` [PATCH 5/5] arm: mach-mx3: use IMX_GPIO_NR instead of hard-coded values Wolfram Sang
2011-02-10 19:14   ` Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2011-02-22 12:58 [PATCH V2 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Wolfram Sang
2011-02-22 12:58 ` [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk Wolfram Sang
2011-02-22 12:58   ` Wolfram Sang
2011-02-23 13:51 [PATCH V3 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Wolfram Sang
2011-02-23 13:51 ` [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk Wolfram Sang
2011-02-23 13:51   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110211100739.GA8965@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=eric@eukrea.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=r65037@freescale.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.