From: Vasily Khoruzhick <anarsoul@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue.
Date: Thu, 17 Feb 2011 11:06:59 +0000 [thread overview]
Message-ID: <201102171306.59493.anarsoul@gmail.com> (raw)
In-Reply-To: <20110217110321.GF24627@n2100.arm.linux.org.uk>
On Thursday 17 February 2011 13:03:21 Russell King - ARM Linux wrote:
> On Thu, Feb 17, 2011 at 09:43:07AM +0200, Vasily Khoruzhick wrote:
> > From: Russell King - ARM Linux <linux@arm.linux.org.uk>
> >
> > From: Russell King - ARM Linux <linux@arm.linux.org.uk>
>
> No need for two From: lines.
It was added accidently, sorry
> > @@ -636,7 +639,8 @@ static void overlay1fb_disable(struct pxafb_layer
> > *ofb)
> >
> > lcd_writel(ofb->fbi, FBR1, ofb->fbi->fdadr[DMA_OV1] | 0x3);
> >
> > if (wait_for_completion_timeout(&ofb->branch_done, 1 * HZ) = 0)
> >
> > - pr_warning("%s: timeout disabling overlay1\n", __func__);
> > + pr_warning("%s: timeout disabling overlay1\n",
> > + __func__);
>
> No need for this change.
>
> > @@ -687,6 +691,9 @@ static void overlay2fb_disable(struct pxafb_layer
> > *ofb)
> >
> > {
> >
> > uint32_t lccr5 = lcd_readl(ofb->fbi, LCCR5);
> >
> > + if (!(lcd_readl(ofb->fbi, OVL2C1) & OVLxC1_OEN))
> > + return;
> > +
>
> You don't describe this change in the change log, and this wasn't in my
> patch.
I did, "- Disable overlay only if it was enabled."
> > @@ -696,7 +703,8 @@ static void overlay2fb_disable(struct pxafb_layer
> > *ofb)
> >
> > lcd_writel(ofb->fbi, FBR4, ofb->fbi->fdadr[DMA_OV2_Cr] | 0x3);
> >
> > if (wait_for_completion_timeout(&ofb->branch_done, 1 * HZ) = 0)
> >
> > - pr_warning("%s: timeout disabling overlay2\n", __func__);
> > + pr_warning("%s: timeout disabling overlay2\n",
> > + __func__);
>
> No need for this change.
Ok
WARNING: multiple messages have this Message-ID (diff)
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue.
Date: Thu, 17 Feb 2011 13:06:59 +0200 [thread overview]
Message-ID: <201102171306.59493.anarsoul@gmail.com> (raw)
In-Reply-To: <20110217110321.GF24627@n2100.arm.linux.org.uk>
On Thursday 17 February 2011 13:03:21 Russell King - ARM Linux wrote:
> On Thu, Feb 17, 2011 at 09:43:07AM +0200, Vasily Khoruzhick wrote:
> > From: Russell King - ARM Linux <linux@arm.linux.org.uk>
> >
> > From: Russell King - ARM Linux <linux@arm.linux.org.uk>
>
> No need for two From: lines.
It was added accidently, sorry
> > @@ -636,7 +639,8 @@ static void overlay1fb_disable(struct pxafb_layer
> > *ofb)
> >
> > lcd_writel(ofb->fbi, FBR1, ofb->fbi->fdadr[DMA_OV1] | 0x3);
> >
> > if (wait_for_completion_timeout(&ofb->branch_done, 1 * HZ) == 0)
> >
> > - pr_warning("%s: timeout disabling overlay1\n", __func__);
> > + pr_warning("%s: timeout disabling overlay1\n",
> > + __func__);
>
> No need for this change.
>
> > @@ -687,6 +691,9 @@ static void overlay2fb_disable(struct pxafb_layer
> > *ofb)
> >
> > {
> >
> > uint32_t lccr5 = lcd_readl(ofb->fbi, LCCR5);
> >
> > + if (!(lcd_readl(ofb->fbi, OVL2C1) & OVLxC1_OEN))
> > + return;
> > +
>
> You don't describe this change in the change log, and this wasn't in my
> patch.
I did, "- Disable overlay only if it was enabled."
> > @@ -696,7 +703,8 @@ static void overlay2fb_disable(struct pxafb_layer
> > *ofb)
> >
> > lcd_writel(ofb->fbi, FBR4, ofb->fbi->fdadr[DMA_OV2_Cr] | 0x3);
> >
> > if (wait_for_completion_timeout(&ofb->branch_done, 1 * HZ) == 0)
> >
> > - pr_warning("%s: timeout disabling overlay2\n", __func__);
> > + pr_warning("%s: timeout disabling overlay2\n",
> > + __func__);
>
> No need for this change.
Ok
next prev parent reply other threads:[~2011-02-17 11:06 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 20:46 [PATCH] ARM: PXA: Make PXA27x/PXA3xx overlay actually work Vasily Khoruzhick
2011-02-02 20:46 ` Vasily Khoruzhick
2011-02-13 13:31 ` Russell King - ARM Linux
2011-02-13 13:31 ` Russell King - ARM Linux
2011-02-15 7:35 ` Eric Miao
2011-02-15 7:35 ` Eric Miao
2011-02-15 8:41 ` Vasily Khoruzhick
2011-02-15 8:41 ` Vasily Khoruzhick
2011-02-15 11:51 ` Eric Miao
2011-02-15 11:51 ` Eric Miao
2011-02-15 11:58 ` Vasily Khoruzhick
2011-02-15 11:58 ` Vasily Khoruzhick
2011-02-15 13:36 ` Eric Miao
2011-02-15 13:36 ` Eric Miao
2011-02-15 13:51 ` Vasily Khoruzhick
2011-02-15 13:51 ` Vasily Khoruzhick
2011-02-15 15:12 ` Eric Miao
2011-02-15 15:12 ` Eric Miao
2011-02-15 15:18 ` Vasily Khoruzhick
2011-02-15 15:18 ` Vasily Khoruzhick
2011-02-17 7:43 ` [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue Vasily Khoruzhick
2011-02-17 7:43 ` Vasily Khoruzhick
2011-02-17 7:43 ` [PATCH 2/2] ARM: PXA: PXAFB: fix plane Z-ordering problem Vasily Khoruzhick
2011-02-17 7:43 ` Vasily Khoruzhick
2011-02-17 11:03 ` [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue Russell King - ARM Linux
2011-02-17 11:03 ` Russell King - ARM Linux
2011-02-17 11:06 ` Vasily Khoruzhick [this message]
2011-02-17 11:06 ` Vasily Khoruzhick
2011-02-20 15:02 ` [PATCH v2 1/3] " Vasily Khoruzhick
2011-02-20 15:02 ` Vasily Khoruzhick
2011-02-20 15:02 ` [PATCH v2 2/3] ARM: PXA: PXAFB: Fix plane Z-ordering problem Vasily Khoruzhick
2011-02-20 15:02 ` Vasily Khoruzhick
2011-02-20 15:02 ` [PATCH v2 3/3] ARM: PXA: PXAFB: Fix typo in ypos assignment Vasily Khoruzhick
2011-02-20 15:02 ` Vasily Khoruzhick
2011-02-20 18:47 ` Marek Vasut
2011-02-20 18:47 ` Marek Vasut
2011-02-20 18:46 ` [PATCH v2 1/3] ARM: PXA: PXAFB: Fix double-free issue Marek Vasut
2011-02-20 18:46 ` Marek Vasut
2011-02-26 16:39 ` Vasily Khoruzhick
2011-02-26 16:39 ` Vasily Khoruzhick
2011-03-05 22:30 ` Vasily Khoruzhick
2011-03-05 22:30 ` Vasily Khoruzhick
2011-03-11 9:20 ` [PATCH 1/4] ARM: PXA: PXAFB: rework pxafb overlay memory management Vasily Khoruzhick
2011-03-11 9:20 ` Vasily Khoruzhick
2011-03-11 9:20 ` [PATCH 2/4] ARM: PXA: PXAFB: Fix plane Z-ordering problem Vasily Khoruzhick
2011-03-11 9:20 ` Vasily Khoruzhick
2011-03-16 13:16 ` Eric Miao
2011-03-16 13:16 ` Eric Miao
2011-03-11 9:20 ` [PATCH 3/4] ARM: PXA: PXAFB: Fix typo in ypos assignment Vasily Khoruzhick
2011-03-11 9:20 ` Vasily Khoruzhick
2011-03-11 21:35 ` Marek Vasut
2011-03-11 21:35 ` Marek Vasut
2011-03-16 13:15 ` Eric Miao
2011-03-16 13:15 ` Eric Miao
2011-03-11 9:20 ` [PATCH 4/4] ARM: PXA: PXAFB: don't disable controller on cpufreq transition if overlay is in use Vasily Khoruzhick
2011-03-11 9:20 ` Vasily Khoruzhick
2011-03-16 13:16 ` [PATCH 4/4] ARM: PXA: PXAFB: don't disable controller on cpufreq Eric Miao
2011-03-16 13:16 ` [PATCH 4/4] ARM: PXA: PXAFB: don't disable controller on cpufreq transition if overlay is in use Eric Miao
2011-03-11 21:34 ` [PATCH 1/4] ARM: PXA: PXAFB: rework pxafb overlay memory management Marek Vasut
2011-03-11 21:34 ` Marek Vasut
2011-03-11 21:46 ` Vasily Khoruzhick
2011-03-11 21:46 ` Vasily Khoruzhick
2011-03-16 11:17 ` Eric Miao
2011-03-16 11:17 ` Eric Miao
2011-02-17 18:17 ` [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue Marek Vasut
2011-02-17 18:17 ` Marek Vasut
2011-02-17 18:56 ` Russell King - ARM Linux
2011-02-17 18:56 ` Russell King - ARM Linux
2011-02-18 2:24 ` Eric Miao
2011-02-18 2:24 ` Eric Miao
2011-02-15 9:48 ` [PATCH] ARM: PXA: Make PXA27x/PXA3xx overlay actually work Russell King - ARM Linux
2011-02-15 9:48 ` Russell King - ARM Linux
2011-02-15 11:43 ` Eric Miao
2011-02-15 11:43 ` Eric Miao
2011-02-18 10:07 ` Sascha Hauer
2011-02-18 10:07 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102171306.59493.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.