All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: PXA: Make PXA27x/PXA3xx overlay actually work
Date: Fri, 18 Feb 2011 10:07:01 +0000	[thread overview]
Message-ID: <20110218100701.GA24655@pengutronix.de> (raw)
In-Reply-To: <1296679619-32666-1-git-send-email-anarsoul@gmail.com>

Hi Vasily,

On Wed, Feb 02, 2011 at 10:46:59PM +0200, Vasily Khoruzhick wrote:
> From: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
> 
> Release callback tries to free memory even if it was not allocated in
> map_video_memory. Fix PXA27x/3xx overlay memory management and make overlay
> actually work.

While at pxa overlay support you also might to fix that the xpos field
in var->nonstd is also used for ypos in two places:

ypos = NONSTD_TO_XPOS(var->nonstd);
                ^^^

I stumbled upon this but was not interested enough that moment to create
a patch.

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: PXA: Make PXA27x/PXA3xx overlay actually work
Date: Fri, 18 Feb 2011 11:07:01 +0100	[thread overview]
Message-ID: <20110218100701.GA24655@pengutronix.de> (raw)
In-Reply-To: <1296679619-32666-1-git-send-email-anarsoul@gmail.com>

Hi Vasily,

On Wed, Feb 02, 2011 at 10:46:59PM +0200, Vasily Khoruzhick wrote:
> From: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
> 
> Release callback tries to free memory even if it was not allocated in
> map_video_memory. Fix PXA27x/3xx overlay memory management and make overlay
> actually work.

While at pxa overlay support you also might to fix that the xpos field
in var->nonstd is also used for ypos in two places:

ypos = NONSTD_TO_XPOS(var->nonstd);
                ^^^

I stumbled upon this but was not interested enough that moment to create
a patch.

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2011-02-18 10:07 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 20:46 [PATCH] ARM: PXA: Make PXA27x/PXA3xx overlay actually work Vasily Khoruzhick
2011-02-02 20:46 ` Vasily Khoruzhick
2011-02-13 13:31 ` Russell King - ARM Linux
2011-02-13 13:31   ` Russell King - ARM Linux
2011-02-15  7:35 ` Eric Miao
2011-02-15  7:35   ` Eric Miao
2011-02-15  8:41   ` Vasily Khoruzhick
2011-02-15  8:41     ` Vasily Khoruzhick
2011-02-15 11:51     ` Eric Miao
2011-02-15 11:51       ` Eric Miao
2011-02-15 11:58       ` Vasily Khoruzhick
2011-02-15 11:58         ` Vasily Khoruzhick
2011-02-15 13:36         ` Eric Miao
2011-02-15 13:36           ` Eric Miao
2011-02-15 13:51           ` Vasily Khoruzhick
2011-02-15 13:51             ` Vasily Khoruzhick
2011-02-15 15:12             ` Eric Miao
2011-02-15 15:12               ` Eric Miao
2011-02-15 15:18               ` Vasily Khoruzhick
2011-02-15 15:18                 ` Vasily Khoruzhick
2011-02-17  7:43                 ` [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue Vasily Khoruzhick
2011-02-17  7:43                   ` Vasily Khoruzhick
2011-02-17  7:43                   ` [PATCH 2/2] ARM: PXA: PXAFB: fix plane Z-ordering problem Vasily Khoruzhick
2011-02-17  7:43                     ` Vasily Khoruzhick
2011-02-17 11:03                   ` [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue Russell King - ARM Linux
2011-02-17 11:03                     ` Russell King - ARM Linux
2011-02-17 11:06                     ` Vasily Khoruzhick
2011-02-17 11:06                       ` Vasily Khoruzhick
2011-02-20 15:02                     ` [PATCH v2 1/3] " Vasily Khoruzhick
2011-02-20 15:02                       ` Vasily Khoruzhick
2011-02-20 15:02                       ` [PATCH v2 2/3] ARM: PXA: PXAFB: Fix plane Z-ordering problem Vasily Khoruzhick
2011-02-20 15:02                         ` Vasily Khoruzhick
2011-02-20 15:02                       ` [PATCH v2 3/3] ARM: PXA: PXAFB: Fix typo in ypos assignment Vasily Khoruzhick
2011-02-20 15:02                         ` Vasily Khoruzhick
2011-02-20 18:47                         ` Marek Vasut
2011-02-20 18:47                           ` Marek Vasut
2011-02-20 18:46                       ` [PATCH v2 1/3] ARM: PXA: PXAFB: Fix double-free issue Marek Vasut
2011-02-20 18:46                         ` Marek Vasut
2011-02-26 16:39                         ` Vasily Khoruzhick
2011-02-26 16:39                           ` Vasily Khoruzhick
2011-03-05 22:30                       ` Vasily Khoruzhick
2011-03-05 22:30                         ` Vasily Khoruzhick
2011-03-11  9:20                         ` [PATCH 1/4] ARM: PXA: PXAFB: rework pxafb overlay memory management Vasily Khoruzhick
2011-03-11  9:20                           ` Vasily Khoruzhick
2011-03-11  9:20                           ` [PATCH 2/4] ARM: PXA: PXAFB: Fix plane Z-ordering problem Vasily Khoruzhick
2011-03-11  9:20                             ` Vasily Khoruzhick
2011-03-16 13:16                             ` Eric Miao
2011-03-16 13:16                               ` Eric Miao
2011-03-11  9:20                           ` [PATCH 3/4] ARM: PXA: PXAFB: Fix typo in ypos assignment Vasily Khoruzhick
2011-03-11  9:20                             ` Vasily Khoruzhick
2011-03-11 21:35                             ` Marek Vasut
2011-03-11 21:35                               ` Marek Vasut
2011-03-16 13:15                             ` Eric Miao
2011-03-16 13:15                               ` Eric Miao
2011-03-11  9:20                           ` [PATCH 4/4] ARM: PXA: PXAFB: don't disable controller on cpufreq transition if overlay is in use Vasily Khoruzhick
2011-03-11  9:20                             ` Vasily Khoruzhick
2011-03-16 13:16                             ` [PATCH 4/4] ARM: PXA: PXAFB: don't disable controller on cpufreq Eric Miao
2011-03-16 13:16                               ` [PATCH 4/4] ARM: PXA: PXAFB: don't disable controller on cpufreq transition if overlay is in use Eric Miao
2011-03-11 21:34                           ` [PATCH 1/4] ARM: PXA: PXAFB: rework pxafb overlay memory management Marek Vasut
2011-03-11 21:34                             ` Marek Vasut
2011-03-11 21:46                             ` Vasily Khoruzhick
2011-03-11 21:46                               ` Vasily Khoruzhick
2011-03-16 11:17                               ` Eric Miao
2011-03-16 11:17                                 ` Eric Miao
2011-02-17 18:17                   ` [PATCH 1/2] ARM: PXA: PXAFB: Fix double-free issue Marek Vasut
2011-02-17 18:17                     ` Marek Vasut
2011-02-17 18:56                     ` Russell King - ARM Linux
2011-02-17 18:56                       ` Russell King - ARM Linux
2011-02-18  2:24                       ` Eric Miao
2011-02-18  2:24                         ` Eric Miao
2011-02-15  9:48   ` [PATCH] ARM: PXA: Make PXA27x/PXA3xx overlay actually work Russell King - ARM Linux
2011-02-15  9:48     ` Russell King - ARM Linux
2011-02-15 11:43     ` Eric Miao
2011-02-15 11:43       ` Eric Miao
2011-02-18 10:07 ` Sascha Hauer [this message]
2011-02-18 10:07   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110218100701.GA24655@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.